Skip to content

Commit 003a1bf

Browse files
committed
fix: disable warmup to prevent additional markers
When running the warmup, we already call `start/stop_benchmark` which creates two memory profiles per benchmark, which breaks our assumptions in the backend.
1 parent c6e8f77 commit 003a1bf

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

google_benchmark/src/benchmark_api_internal.cc

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -97,14 +97,6 @@ State BenchmarkInstance::RunSimulation(
9797
internal::ThreadManager* manager,
9898
internal::PerfCountersMeasurement* perf_counters_measurement,
9999
ProfilerManager* profiler_manager) const {
100-
// Do one repetition to avoid flakiness due to inconcistencies in CPU cache
101-
// from execution order
102-
103-
internal::ThreadTimer warmup_timer = internal::ThreadTimer::Create();
104-
State warmup_state(name_.function_name, 1, args_, 0, 1, &warmup_timer,
105-
manager, perf_counters_measurement, profiler_manager,
106-
NULL);
107-
benchmark_.Run(warmup_state);
108100

109101
State st(name().str(), 1, args_, 0, 1, timer, manager,
110102
perf_counters_measurement, profiler_manager, codspeed);

0 commit comments

Comments
 (0)