diff --git a/Reviews/267 - Casper .NET C# SDK/Differential evaluation of C# SDK/README.md b/Reviews/267 - Casper .NET C# SDK/Differential evaluation of C# SDK/README.md new file mode 100644 index 00000000..3b944458 --- /dev/null +++ b/Reviews/267 - Casper .NET C# SDK/Differential evaluation of C# SDK/README.md @@ -0,0 +1,19 @@ +# Casper C# checklist + +## Required methods + +| Method | Source | | Notes | +| ------------------------- |:--------------------------------------------------------------------------------------------------------------------------------:| --- |:-----------:| +| chain_get_block | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L241) | ✅ | | +| info_get_deploy | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L220) | ✅ | | +| account_put_deploy | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L205) | ✅ | | +| chain_get_state_root_hash | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L13) | ✅ | | +| state_get_account_info | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L101) | ✅ | | +| state_get_balance | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L188) | ✅ | | +| state_get_dictionary_item | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L352) | ✅ | | +| query_global_state | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L162) | ✅ | | + + +## Reviewer notes + +The SKD is aligned with the SDK standard. \ No newline at end of file diff --git a/Reviews/29 - Casper PHP SDK/Differential evaluation of PHP SDK/README.md b/Reviews/29 - Casper PHP SDK/Differential evaluation of PHP SDK/README.md new file mode 100644 index 00000000..8de8f33a --- /dev/null +++ b/Reviews/29 - Casper PHP SDK/Differential evaluation of PHP SDK/README.md @@ -0,0 +1,21 @@ +# Casper PHP checklist + +## Required methods + +| Method | Source | | Notes | +| ------------------------- |:--------------------------------------------------------------------------------------------------------------------------------:| --- |:-----------:| +| chain_get_block | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L111) | ✅ | Missing BlockIdentifier type Ets: 1hour | +| info_get_deploy | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L96) | ✅ | | +| account_put_deploy | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L76) | ✅ | | +| chain_get_state_root_hash | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L194) | ✅ | | +| state_get_account_info | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L204) | ✅ | | +| state_get_balance | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L222) | ✅ | | +| state_get_dictionary_item | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L329) | ✅ | | +| query_global_state | N/A | ❌ | Est: 4hours | + + +## Reviewer notes + +There is a missing method: `query_global_state`. The estimated implementation time for the method is 4 hours. +The implementation for `chain_get_block` should be merged to single function and take `BlockIdentifier` param. The estimated update time for the method is 1 hour +Other methods and types are aligned with the SDK standard.