From ff29a1313ec60a2f3579480b0f1d7f013908a6cb Mon Sep 17 00:00:00 2001 From: KienNguyen Date: Sun, 26 Jun 2022 13:54:07 +0700 Subject: [PATCH 1/3] Add differential evaluation of C#, PHP SDK --- .../README.md | 19 +++++++++++++++++ .../README.md | 21 +++++++++++++++++++ 2 files changed, 40 insertions(+) create mode 100644 Reviews/267 - Casper .NET C# SDK/Differential evaluation of C# SDK/README.md create mode 100644 Reviews/29 - Casper PHP SDK/Differential evaluation of PHP SDK/README.md diff --git a/Reviews/267 - Casper .NET C# SDK/Differential evaluation of C# SDK/README.md b/Reviews/267 - Casper .NET C# SDK/Differential evaluation of C# SDK/README.md new file mode 100644 index 00000000..3b944458 --- /dev/null +++ b/Reviews/267 - Casper .NET C# SDK/Differential evaluation of C# SDK/README.md @@ -0,0 +1,19 @@ +# Casper C# checklist + +## Required methods + +| Method | Source | | Notes | +| ------------------------- |:--------------------------------------------------------------------------------------------------------------------------------:| --- |:-----------:| +| chain_get_block | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L241) | ✅ | | +| info_get_deploy | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L220) | ✅ | | +| account_put_deploy | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L205) | ✅ | | +| chain_get_state_root_hash | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L13) | ✅ | | +| state_get_account_info | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L101) | ✅ | | +| state_get_balance | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L188) | ✅ | | +| state_get_dictionary_item | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L352) | ✅ | | +| query_global_state | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L162) | ✅ | | + + +## Reviewer notes + +The SKD is aligned with the SDK standard. \ No newline at end of file diff --git a/Reviews/29 - Casper PHP SDK/Differential evaluation of PHP SDK/README.md b/Reviews/29 - Casper PHP SDK/Differential evaluation of PHP SDK/README.md new file mode 100644 index 00000000..e365a2e3 --- /dev/null +++ b/Reviews/29 - Casper PHP SDK/Differential evaluation of PHP SDK/README.md @@ -0,0 +1,21 @@ +# Casper PHP checklist + +## Required methods + +| Method | Source | | Notes | +| ------------------------- |:--------------------------------------------------------------------------------------------------------------------------------:| --- |:-----------:| +| chain_get_block | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L111) | ✅ | Missing BlockIdentifier type Ets: 1hour | +| info_get_deploy | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L96) | ✅ | | +| account_put_deploy | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L76) | ✅ | | +| chain_get_state_root_hash | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L194) | ✅ | | +| state_get_account_info | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L204) | ✅ | | +| state_get_balance | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L222) | ✅ | | +| state_get_dictionary_item | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L329) | ✅ | | +| query_global_state | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L162) | ❌ | Est: 4hours | + + +## Reviewer notes + +There a missing method `query_global_state`. The estimated implementation time for the method is 4 hours. +The implementation for `chain_get_block` should be merged to single function and take `BlockIdentifier` param. The estimated update time for the method is 1 hour +Others methods and types are aligned with the SDK standard. \ No newline at end of file From 7af8f505d845736d89173a46d3b10a7566805394 Mon Sep 17 00:00:00 2001 From: KienNguyen Date: Sun, 26 Jun 2022 13:56:38 +0700 Subject: [PATCH 2/3] update php sdk review --- .../Differential evaluation of PHP SDK/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Reviews/29 - Casper PHP SDK/Differential evaluation of PHP SDK/README.md b/Reviews/29 - Casper PHP SDK/Differential evaluation of PHP SDK/README.md index e365a2e3..59445122 100644 --- a/Reviews/29 - Casper PHP SDK/Differential evaluation of PHP SDK/README.md +++ b/Reviews/29 - Casper PHP SDK/Differential evaluation of PHP SDK/README.md @@ -11,7 +11,7 @@ | state_get_account_info | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L204) | ✅ | | | state_get_balance | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L222) | ✅ | | | state_get_dictionary_item | [source](https://github.com/make-software/casper-php-sdk/blob/master/src/Rpc/RpcClient.php#L329) | ✅ | | -| query_global_state | [source](https://github.com/make-software/casper-net-sdk/blob/master/Casper.Network.SDK/JsonRpc/CasperMethods.cs#L162) | ❌ | Est: 4hours | +| query_global_state | N/A | ❌ | Est: 4hours | ## Reviewer notes From 6ed7ca4c68ad8a51afbadfbd1117d25d07cf084f Mon Sep 17 00:00:00 2001 From: kien nguyen Date: Thu, 30 Jun 2022 09:06:58 +0700 Subject: [PATCH 3/3] Update README.md --- .../Differential evaluation of PHP SDK/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Reviews/29 - Casper PHP SDK/Differential evaluation of PHP SDK/README.md b/Reviews/29 - Casper PHP SDK/Differential evaluation of PHP SDK/README.md index 59445122..8de8f33a 100644 --- a/Reviews/29 - Casper PHP SDK/Differential evaluation of PHP SDK/README.md +++ b/Reviews/29 - Casper PHP SDK/Differential evaluation of PHP SDK/README.md @@ -16,6 +16,6 @@ ## Reviewer notes -There a missing method `query_global_state`. The estimated implementation time for the method is 4 hours. +There is a missing method: `query_global_state`. The estimated implementation time for the method is 4 hours. The implementation for `chain_get_block` should be merged to single function and take `BlockIdentifier` param. The estimated update time for the method is 1 hour -Others methods and types are aligned with the SDK standard. \ No newline at end of file +Other methods and types are aligned with the SDK standard.