From a7e13d06a5cc12f4f50d75831b8d947c4a70acd1 Mon Sep 17 00:00:00 2001 From: KienNguyen Date: Sun, 26 Jun 2022 15:52:38 +0700 Subject: [PATCH 1/3] Add differential evaluation of Scala SDK --- .../Differential evaluation of Scala SDK/README.md | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 Reviews/295 - Casper Scala SDK/Differential evaluation of Scala SDK/README.md diff --git a/Reviews/295 - Casper Scala SDK/Differential evaluation of Scala SDK/README.md b/Reviews/295 - Casper Scala SDK/Differential evaluation of Scala SDK/README.md new file mode 100644 index 00000000..e69de29b From 6f205e9f7e1900517620cc9136be3b6df39068f0 Mon Sep 17 00:00:00 2001 From: KienNguyen Date: Sun, 26 Jun 2022 15:54:39 +0700 Subject: [PATCH 2/3] update scala sdk review --- .../README.md | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/Reviews/295 - Casper Scala SDK/Differential evaluation of Scala SDK/README.md b/Reviews/295 - Casper Scala SDK/Differential evaluation of Scala SDK/README.md index e69de29b..becc4a1f 100644 --- a/Reviews/295 - Casper Scala SDK/Differential evaluation of Scala SDK/README.md +++ b/Reviews/295 - Casper Scala SDK/Differential evaluation of Scala SDK/README.md @@ -0,0 +1,21 @@ +# Casper Scala SDK checklist + +## Required methods + +| Method | Source | | Notes | +| ------------------------- |:--------------------------------------------------------------------------------------------------------------------------------:| --- |:-----------:| +| chain_get_block | [source](https://github.com/caspercommunityio/casper-scala-sdk/blob/master/src/main/scala/com/casper/sdk/CasperSdk.scala#L43) | ✅ |Should merge into single function | +| info_get_deploy | [source](https://github.com/caspercommunityio/casper-scala-sdk/blob/master/src/main/scala/com/casper/sdk/CasperSdk.scala#L84) | ✅ | | +| account_put_deploy | [source](https://github.com/caspercommunityio/casper-scala-sdk/blob/master/src/main/scala/com/casper/sdk/CasperSdk.scala#L140) | ✅ | | +| chain_get_state_root_hash | [source](https://github.com/caspercommunityio/casper-scala-sdk/blob/master/src/main/scala/com/casper/sdk/CasperSdk.scala#L35) | ✅ | | +| state_get_account_info | N/A | ❌ | Est: 4hours | +| state_get_balance | [source](https://github.com/caspercommunityio/casper-scala-sdk/blob/master/src/main/scala/com/casper/sdk/CasperSdk.scala#L108) | ✅ | | +| state_get_dictionary_item | [source](https://github.com/caspercommunityio/casper-scala-sdk/blob/master/src/main/scala/com/casper/sdk/CasperSdk.scala#L124) | ✅ | | +| query_global_state | N/A | ❌ | Est: 4hours | + + +## Reviewer notes + +- There are 2 missing method `state_get_account_info` and `query_global_state`. The estimated implementation time for each method is 4 hours. +- The implementation for chain_get_block should be merged to single function and take BlockIdentifier param. The estimated update time for the method is 1 hour. +- Others methods and types are aligned with the SDK standard. From 109a5c963b5ec6d5c1bd3f21869cdf35e8bb4944 Mon Sep 17 00:00:00 2001 From: kien nguyen Date: Thu, 30 Jun 2022 09:05:18 +0700 Subject: [PATCH 3/3] Update README.md --- .../Differential evaluation of Scala SDK/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Reviews/295 - Casper Scala SDK/Differential evaluation of Scala SDK/README.md b/Reviews/295 - Casper Scala SDK/Differential evaluation of Scala SDK/README.md index becc4a1f..644f304c 100644 --- a/Reviews/295 - Casper Scala SDK/Differential evaluation of Scala SDK/README.md +++ b/Reviews/295 - Casper Scala SDK/Differential evaluation of Scala SDK/README.md @@ -16,6 +16,6 @@ ## Reviewer notes -- There are 2 missing method `state_get_account_info` and `query_global_state`. The estimated implementation time for each method is 4 hours. +- There are 2 missing methods: `state_get_account_info` and `query_global_state`. The estimated implementation time for each method is 4 hours. - The implementation for chain_get_block should be merged to single function and take BlockIdentifier param. The estimated update time for the method is 1 hour. -- Others methods and types are aligned with the SDK standard. +- Other methods and types are aligned with the SDK standard.