Skip to content

Commit 24c6ec3

Browse files
committed
edited submission instructions
1 parent 7055a43 commit 24c6ec3

File tree

1 file changed

+23
-21
lines changed

1 file changed

+23
-21
lines changed

โ€ŽREADME.mdโ€Ž

Lines changed: 23 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -8,26 +8,22 @@
88

99
https://discord.gg/6TwzdnW6ze
1010

11-
## ์Šคํ„ฐ๋”” ๋งด๋ฒ„
11+
## ์Šคํ„ฐ๋”” ๋ฉค๋ฒ„
1212

13-
- ๋ฆฌ๋” 1: [Bumsu-Yi](https://github.com/Bumsu-Yi)
14-
- ๋ฆฌ๋” 2: [leokim0922](https://github.com/leokim0922)
15-
- ๋งด๋ฒ„ 1: (์ถ”๊ฐ€ ๋ฐ”๋žŒ)
16-
- ๋งด๋ฒ„ 2: (์ถ”๊ฐ€ ๋ฐ”๋žŒ)
17-
- ๋งด๋ฒ„ 3: (์ถ”๊ฐ€ ๋ฐ”๋žŒ)
18-
- ๋งด๋ฒ„ 4: (์ถ”๊ฐ€ ๋ฐ”๋žŒ)
19-
- ๋งด๋ฒ„ 5: (์ถ”๊ฐ€ ๋ฐ”๋žŒ)
20-
- ๋งด๋ฒ„ 6: (์ถ”๊ฐ€ ๋ฐ”๋žŒ)
13+
https://github.com/DaleStudy/leetcode-study/issues/7
2114

2215
## ๋‹ต์•ˆ ์ฝ”๋“œ ์ž‘์„ฑ๋ฒ•
16+
์ฐธ์กฐ ๋งํฌ :
17+
https://seongjin.me/how-to-contribute-to-open-source/amp/
2318

24-
`main` ๋ธŒ๋žœ์น˜์—์„œ ์ตœ์‹  ์ฝ”๋“œ๋ฅผ ๋‚ด๋ ค ๋ฐ›์€ ํ›„์—, `<์ฃผ>-<GitHub ์œ ์ €๋„ค์ž„>` ํ˜•ํƒœ๋กœ ๋ธŒ๋žœ์น˜๋ฅผ ๋•๋‹ˆ๋‹ค.
2519

26-
์˜ˆ๋ฅผ ๋“ค์–ด,
20+
๋จผ์ €, ํ˜„์žฌ ํŽ˜์ด์ง€ ์šฐ์ƒ๋‹จ์— ์žˆ๋Š” ๋ฒ„ํŠผ๋“ค ์ค‘ `Fork` ๋ฒ„ํŠผ ํด๋ฆญํ•˜์—ฌ ๊ฐœ์ธ ์›๊ฒฉ ์ €์žฅ์†Œ๋กœ ๋ณต์‚ฌํ•ด์ค๋‹ˆ๋‹ค.
21+
22+
๊ฐœ์ธ ๋กœ์ปฌ ์ €์žฅ์†Œ๋กœ `Fork`ํ•œ ๊ฐœ์ธ ์›๊ฒฉ ์ €์žฅ์†Œ ์ฝ”๋“œ๋ฅผ ํด๋ก ํ•ฉ๋‹ˆ๋‹ค,
2723

24+
์˜ˆ๋ฅผ ๋“ค์–ด,
2825
```sh
29-
$ git pull
30-
$ git checkout -b week1-bumsu-yi
26+
$ git clone git@github.com:Bumsu-Yi/leetcode-study.git
3127
```
3228

3329
ํ‘ธ์‹œ๋ ค๋Š” ๋ฌธ์ œ์˜ ํด๋”์—์„œ ์ž๊ธฐ GitHub ์œ ์ €๋„ค์ž„์œผ๋กœ ํŒŒ์ผ์„ ์ƒ์„ฑํ•ฉ๋‹ˆ๋‹ค.
@@ -44,22 +40,28 @@ $ touch Bumsu-Yi.py
4440
์˜ˆ๋ฅผ ๋“ค์–ด,
4541

4642
```sh
43+
$ git add Bumsu_Yi.py
4744
$ git commit -am "two sum solution"
4845
```
4946

5047
## ๋‹ต์•ˆ ์ฝ”๋“œ ์ œ์ถœ๋ฒ•
5148

52-
์ž‘์„ฑํ•œ ๋‹ตํ•œ ์ฝ”๋“œ์— ๋Œ€ํ•ด์„œ ๋‹ค๋ฅธ ์Šคํ„ฐ๋”” ๋งด๋ฒ„๋กœ ๋ถ€ํ„ฐ ๋ฆฌ๋ทฐ๋ฅผ ๋ฐ›๊ณ  ์‹ถ๋‹ค๋ฉด ๋ณ€๊ฒฝ ์‚ฌํ•ญ์„ ์ €์žฅ์†Œ์— ์˜ฌ๋ฆฝ๋‹ˆ๋‹ค.
49+
์ž‘์„ฑํ•œ ๋‹ตํ•œ ์ฝ”๋“œ๋ฅผ ๊ฐœ์ธ ์›๊ฒฉ ์ €์žฅ์†Œ๋กœ push ํ•ฉ๋‹ˆ๋‹ค.
5350

5451
```sh
55-
$ git push origin week1-bumsu-yi
52+
$ git push origin main
5653
```
5754

58-
๊ทธ๋ฆฌ๊ณ  ๋ธŒ๋ผ์šฐ์ €์—์„œ ์ฝ”๋“œ ์ €์žฅ์†Œ๋ฅผ ๋ฐฉ๋ฌธํ•˜๋ฉด Pull Request๋ฅผ ์ƒ์„ฑํ•˜๋ผ๊ณ  ๋œฐ ๊ฒƒ์ž…๋‹ˆ๋‹ค.
59-
๊ทธ ๋ฒ„ํŠผ์„ ํด๋ฆญํ•˜๊ณ  Pull Request๋ฅผ ์ƒ์„ฑํ•ฉ๋‹ˆ๋‹ค.
60-
๊ทธ๋Ÿฌ๋ฉด ๋””์Šค์ฝ”๋“œ ์ฑ„๋„์— ์•Œ๋žŒ์ด ์˜ฌ๋ผ์˜ฌ ๊ฒƒ์ž…๋‹ˆ๋‹ค.
55+
๊ทธ ๋‹ค์Œ, ๊นƒํ—ˆ๋ธŒ ์›น์‚ฌ์ดํŠธ ๊ฐœ์ธ ์›๊ฒฉ์ €์žฅ์†Œ์— ๋“ค์–ด๊ฐ€ ์ขŒ์ƒ๋‹จ `Pull request`๋ฅผ ๋ˆ„๋ฅด๊ณ  `Pull request` ํƒญ์œผ๋กœ ์ด๋™ํ•œ ๋’ค, `New pull request` ๋ฒ„ํŠผ์„ ํด๋ฆญํ•ด์ค๋‹ˆ๋‹ค.
6156

62-
Pull Request ์„ค๋ช…๋ž€์— ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•˜๋ฉด์„œ ์–ด๋ ค์› ๋˜ ๋ถ€๋ถ„์ด๋‚˜ ๋„์›€์ด ํ•„์š”ํ•œ ๋ถ€๋ถ„์— ๋Œ€ํ•ด์„œ ๋‚จ๊ฒจ์ฃผ์‹œ๋ฉด ๋‹ค๋ฅธ ๋ถ„๋“ค์ด ๋ฆฌ๋ทฐํ•  ๋•Œ ์ฐธ๊ณ ํ•  ์ˆ˜ ์žˆ์–ด์„œ ์ข‹๊ฒ ์ฃ ?
57+
์ด์ œ ์ž‘์—…ํ•œ ์ฝ”๋“œ๋ฅผ ์›๋ณธ ์›๊ฒฉ ์ €์žฅ์†Œ๋กœ 'Merge' ํ•˜๊ธฐ ์œ„ํ•œ 'PR'์„ ์ƒ์„ฑํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
58+
59+
`Create pull request` ๋ฅผ ๋ˆ„๋ฅด๊ธฐ์— ์•ž์„œ, ์ƒ๋‹จ์— ์žˆ๋Š” `base repository` ์™€ `head repositry` ๊ฐ€ ๊ฐ๊ฐ ์›๋ณธ ์›๊ฒฝ ์ €์žฅ์†Œ์˜ main ๋ธŒ๋ Œ์น˜์™€ ๋ณธ์ธ์ด ์ž‘์—…ํ•œ ๋ธŒ๋ Œ์น˜๊ฐ€ ๋งž๋Š” ์ง€ ํ™•์ธํ•ด์ค๋‹ˆ๋‹ค.
6360

64-
๋ฆฌ๋ทฐ๋ฅผ ๋ฐ›๋Š” ๋™์•ˆ ๋‹ต์•ˆ ์ฝ”๋“œ๋Š” ์–ผ๋งˆ๋“ ์ง€ ์ถ”๊ฐ€ ์ž‘์„ฑํ•ด์„œ commit/push ํ•˜์‹ค ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
65-
push ํ•˜์‹œ๋Š” ์ฝ”๋“œ๋Š” ์ƒ์„ฑํ•œ Pull Request์— ๋ฐ”๋กœ ๋ฐ˜์˜์ด ๋  ๊ฒƒ์ž…๋‹ˆ๋‹ค.
61+
ํ™•์ธ์ด ๋˜์—ˆ์œผ๋ฉด, `Create pull request`๋ฅผ ๋ˆ„๋ฅด๊ณ , `Title`์— ๋ณธ์ธ์˜ ๋””์Šค์ฝ”๋“œ ๋‹‰๋„ค์ž„์„ ํฌํ•จ ์‹œ์ผœ์ฃผ๊ณ  `Create pull request` ๋ฒ„ํŠผ์„ ํด๋ฆญํ•ฉ๋‹ˆ๋‹ค.
62+
63+
๊ทธ๋Ÿฌ๋ฉด ๋””์Šค์ฝ”๋“œ์—๋„ ์•Œ๋ฆผ์ด ์˜ฌ๊ฒ๋‹ˆ๋‹ค.
64+
65+
์ด์ œ ๋ณธ์ธ์ด ์ž‘์„ฑํ•œ ์†”๋ฃจ์…˜์„ ๋ฆฌ๋ทฐ ๋ฐ›์„ ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค. ๋ฆฌ๋ทฐ๊ฐ€ `approved` ๋œ๋‹ค๋ฉด ๋ฉ”์ธ ์ €์žฅ์†Œ๋ฅผ `Merge` ํ•˜์‹ค ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
66+
67+
Pull Request ์„ค๋ช…๋ž€์— ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•˜๋ฉด์„œ ์–ด๋ ค์› ๋˜ ๋ถ€๋ถ„์ด๋‚˜ ๋„์›€์ด ํ•„์š”ํ•œ ๋ถ€๋ถ„์— ๋Œ€ํ•ด์„œ ๋‚จ๊ฒจ์ฃผ์‹œ๋ฉด ๋‹ค๋ฅธ ๋ถ„๋“ค์ด ๋ฆฌ๋ทฐํ•  ๋•Œ ์ฐธ๊ณ ํ•  ์ˆ˜ ์žˆ์–ด์„œ ์ข‹๊ฒ ์ฃ ?

0 commit comments

Comments
ย (0)