From 4a21829305a735463d6dc606a93bea2fa15553dd Mon Sep 17 00:00:00 2001 From: Braedon Wooding Date: Wed, 4 Feb 2026 00:36:15 +1100 Subject: [PATCH 1/3] Fix test --- R/DataMart.R | 2 +- tests/testthat/test-datamart.R | 19 ------------------- 2 files changed, 1 insertion(+), 20 deletions(-) diff --git a/R/DataMart.R b/R/DataMart.R index 16bb293..c15c08a 100644 --- a/R/DataMart.R +++ b/R/DataMart.R @@ -408,7 +408,7 @@ QGetSharedUrl <- function(filename) encode = "raw")) has.errored <- inherits(res, "try-error") - if (res$status_code == 404) + if (res$status_code == 404 || httr::content(res, as = "text") == "File not found") { stop("QGetSharedUrl has encountered an unknown error. ", "404: No such file exists. ", diff --git a/tests/testthat/test-datamart.R b/tests/testthat/test-datamart.R index 1fb0182..650194c 100644 --- a/tests/testthat/test-datamart.R +++ b/tests/testthat/test-datamart.R @@ -179,25 +179,6 @@ test_that("QGetSharedUrl: bad cases", { QGetSharedUrl("file_that_does_not_exist.rds"), "404: No such file exists" ) - - # 404 error with mocked POST - mocked.post <- function(...) { - list(status_code = 404) - } - with_mocked_bindings( - POST = mocked.post, - QGetSharedUrl("any_file.rds"), - .package = "httr" - ) |> - expect_error( - paste0( - "QGetSharedUrl has encountered an unknown error. ", - "404: No such file exists. ", - "The likely cause was an incorrect path preceding the filename, ", - "or insufficient access to the file path." - ), - fixed = TRUE - ) }) test_that("Delete Data", From 7d996ac72cbbab9a74cd4d58448f2a256332932c Mon Sep 17 00:00:00 2001 From: Braedon Wooding Date: Wed, 4 Feb 2026 09:24:46 +1100 Subject: [PATCH 2/3] Export new API --- NAMESPACE | 1 + 1 file changed, 1 insertion(+) diff --git a/NAMESPACE b/NAMESPACE index 2c778f1..4a45798 100644 --- a/NAMESPACE +++ b/NAMESPACE @@ -16,6 +16,7 @@ export(QFileExists) export(QFileOpen) export(QLoadData) export(QSaveData) +export(QGetSharedUrl) export(RunSQL) export(UpdateFactbasePenetrationFormula) export(UpdateFactbaseRatioFormula) From 6af759701cc27dfaf560826a2fb4297205a4d6c5 Mon Sep 17 00:00:00 2001 From: jrwishart Date: Wed, 4 Feb 2026 09:41:50 +1100 Subject: [PATCH 3/3] Update Rd files --- NAMESPACE | 2 +- man/QGetSharedUrl.Rd | 22 ++++++++++++++++++++++ 2 files changed, 23 insertions(+), 1 deletion(-) create mode 100644 man/QGetSharedUrl.Rd diff --git a/NAMESPACE b/NAMESPACE index 4a45798..16de0f1 100644 --- a/NAMESPACE +++ b/NAMESPACE @@ -14,9 +14,9 @@ export(IsDisplayrCloudDriveAvailable) export(QDeleteFiles) export(QFileExists) export(QFileOpen) +export(QGetSharedUrl) export(QLoadData) export(QSaveData) -export(QGetSharedUrl) export(RunSQL) export(UpdateFactbasePenetrationFormula) export(UpdateFactbaseRatioFormula) diff --git a/man/QGetSharedUrl.Rd b/man/QGetSharedUrl.Rd new file mode 100644 index 0000000..e71827b --- /dev/null +++ b/man/QGetSharedUrl.Rd @@ -0,0 +1,22 @@ +% Generated by roxygen2: do not edit by hand +% Please edit documentation in R/DataMart.R +\name{QGetSharedUrl} +\alias{QGetSharedUrl} +\title{Share an object} +\usage{ +QGetSharedUrl(filename) +} +\arguments{ +\item{filename}{character string. Name of the file that is being shared. +To reference a file in a subdirectory, use double backslashes after each folder (e.g "subdir\\file.csv").} +} +\value{ +Share URL as a string +} +\description{ +Gets the cloud drive share url for an object saved to the Displayr Cloud Drive. +} +\details{ +If the file has not previously been shared it will be shared else the already existing +share url will be returned. +}