-
Notifications
You must be signed in to change notification settings - Fork 33
Description
Hi, thank you for sharing this amazing work! While reading through the code, I noticed a potential inconsistency in the eval_nvs.py regarding the handling of pred_context_pose and pred_all_context_extrinsic/pred_all_context_intrinsic. I would like to clarify this with you.
In the evaluate function:
pred_context_poseis obtained from the encoder output and is aligned with thegaussians.pred_all_context_extrinsicandpred_all_context_intrinsicare decoded frompose_encoding_to_extri_intri.
Although the code performs scale alignment for the translation part of pred_all_context_extrinsic, the rotation matrices and intrinsic matrices are not explicitly aligned. This raises the following concerns:
- Training view rendering: If the rotation matrices in
pred_context_pose['extrinsic']andpred_all_context_extrinsicare inconsistent, could this lead to a mismatch between the training views and the Gaussian point cloud? If the intrinsic matrices inpred_context_pose['intrinsic']andpred_all_context_intrinsicare inconsistent, could this cause the rendered views to deviate from the training views? - Output vs. target views: Since
pred_context_poseandpred_all_context_extrinsic/pred_all_context_intrinsicare not fully aligned, could the renderedoutputviews differ from the intendedtargetviews?
Here is the relevant code snippet from the evaluate function:
scale_factor = pred_context_pose['extrinsic'][:, :, :3, 3].mean() / pred_all_context_extrinsic[:, :, :3, 3].mean()
pred_all_target_extrinsic[..., :3, 3] = pred_all_target_extrinsic[..., :3, 3] * scale_factor
pred_all_context_extrinsic[..., :3, 3] = pred_all_context_extrinsic[..., :3, 3] * scale_factorThe code aligns the translation part of pred_all_context_extrinsic with pred_context_pose['extrinsic'], but the rotation matrices and intrinsic matrices are not aligned.
Questions
- Should the rotation matrices in
pred_all_context_extrinsicbe aligned withpred_context_pose['extrinsic']? - Should the intrinsic matrices in
pred_all_context_intrinsicbe aligned withpred_context_pose['intrinsic']? - If no alignment is performed, could this affect the accuracy of the rendered training and testing views?
Thank you for your time and assistance! Looking forward to your response. 😊