From 6080f51064ae71bf83b10e04749fd2ce0f75a3da Mon Sep 17 00:00:00 2001 From: lkno0705 Date: Thu, 27 May 2021 22:10:45 +0200 Subject: [PATCH 01/19] Add equippedItem stats manipulation --- .../entities/CeInventory.java | 21 +++++++++- .../calculationEngine/entities/CePlayer.java | 2 +- .../calculationEngine/entities/CeStats.java | 33 +++++++++++++-- .../calculationEngine/environment/CeItem.java | 2 + .../environment/CeItemEffects.java | 41 +++++++++++++++++++ .../environment/TestItems.java | 4 +- src/main/resources/items.JSON | 6 ++- .../CeInventoryTest.java | 6 +-- 8 files changed, 103 insertions(+), 12 deletions(-) create mode 100644 src/main/java/calculationEngine/environment/CeItemEffects.java diff --git a/src/main/java/calculationEngine/entities/CeInventory.java b/src/main/java/calculationEngine/entities/CeInventory.java index 0ef9dc2..148c93b 100644 --- a/src/main/java/calculationEngine/entities/CeInventory.java +++ b/src/main/java/calculationEngine/entities/CeInventory.java @@ -18,6 +18,8 @@ public class CeInventory { CeItem equippedArmorHead; CeItem equippedWeapon; + CeStats playerStats; + int maxItemSlots = 10; CeSlot[] slots = new CeSlot[maxItemSlots]; @@ -31,10 +33,11 @@ public void loadSaveInventory(CeItem armorShoulder, CeItem armorShoes, CeItem ar this.equippedWeapon = weapon; } - public CeInventory() { + public CeInventory(CeStats ceStats) { for (int i = 0; i < slots.length; i++) { slots[i] = new CeSlot(); } + this.playerStats = ceStats; } public void addItemToInventory(CeItem item) throws NoPlaceInInventoryException { @@ -132,55 +135,67 @@ public void setEquippedItem(CeItem equippedItem) throws WrongItemException { private void setEquippedArmorShoulder(CeItem equippedArmorShoulder) throws WrongItemException { if (this.equippedArmorShoulder != null) + this.playerStats.removeBonusStats(this.equippedArmorShoulder.getItemBonusStats()); this.equippedArmorShoulder.unequip(); if (equippedArmorShoulder.getType() == armorShoulder) { this.equippedArmorShoulder = equippedArmorShoulder; this.equippedArmorShoulder.equip(); + this.playerStats.applyBonusStats(equippedArmorShoulder.getItemBonusStats()); } else throw new WrongItemException(equippedArmorShoulder, "Armor type shoulderArmor"); } private void setEquippedArmorShoes(CeItem equippedArmorShoes) throws WrongItemException { if (this.equippedArmorShoes != null) + this.playerStats.removeBonusStats(this.equippedArmorShoes.getItemBonusStats()); this.equippedArmorShoes.unequip(); if (equippedArmorShoes.getType() == armorShoes) { this.equippedArmorShoes = equippedArmorShoes; this.equippedArmorShoes.equip(); + this.playerStats.applyBonusStats(equippedArmorShoes.getItemBonusStats()); } else throw new WrongItemException(equippedArmorShoes, "Armor type armorShoes"); } private void setEquippedArmorLegs(CeItem equippedArmorLegs) throws WrongItemException { if (this.equippedArmorLegs != null) + this.playerStats.removeBonusStats(this.equippedArmorLegs.getItemBonusStats()); this.equippedArmorLegs.unequip(); if (equippedArmorLegs.getType() == armorLegs) { this.equippedArmorLegs = equippedArmorLegs; this.equippedArmorLegs.equip(); + this.playerStats.applyBonusStats(equippedArmorLegs.getItemBonusStats()); } else throw new WrongItemException(equippedArmorLegs, "Armor type ArmorLegs"); } private void setEquippedArmorChest(CeItem equippedArmorChest) throws WrongItemException { if (this.equippedArmorChest != null) + this.playerStats.removeBonusStats(this.equippedArmorChest.getItemBonusStats()); this.equippedArmorChest.unequip(); if (equippedArmorChest.getType() == armorChest) { this.equippedArmorChest = equippedArmorChest; this.equippedArmorChest.equip(); + this.playerStats.applyBonusStats(equippedArmorChest.getItemBonusStats()); } else throw new WrongItemException(equippedArmorChest, "Armor type ArmorChest"); } private void setEquippedArmorHead(CeItem equippedArmorHead) throws WrongItemException { if (this.equippedArmorHead != null) + this.playerStats.removeBonusStats(this.equippedArmorHead.getItemBonusStats()); this.equippedArmorHead.unequip(); if (equippedArmorHead.getType() == armorHead) { this.equippedArmorHead = equippedArmorHead; this.equippedArmorHead.equip(); + this.playerStats.applyBonusStats(equippedArmorHead.getItemBonusStats()); } else throw new WrongItemException(equippedArmorHead, "Armor type armorHead"); } private void setEquippedWeapon(CeItem equippedWeapon) throws WrongItemException { if (this.equippedWeapon != null) + this.playerStats.removeBonusStats(this.equippedWeapon.getItemBonusStats()); this.equippedWeapon.unequip(); if (equippedWeapon.getType() == weapon) { this.equippedWeapon = equippedWeapon; this.equippedWeapon.equip(); + this.playerStats.applyBonusStats(equippedWeapon.getItemBonusStats()); } else throw new WrongItemException(equippedWeapon, "Armor type weapon"); } @@ -215,4 +230,8 @@ public CeSlot[] getSlots() { public int getMaxItemSlots() { return maxItemSlots; } + + public void setPlayerStats(CeStats playerStats) { + this.playerStats = playerStats; + } } diff --git a/src/main/java/calculationEngine/entities/CePlayer.java b/src/main/java/calculationEngine/entities/CePlayer.java index 7ec563a..2b857a9 100644 --- a/src/main/java/calculationEngine/entities/CePlayer.java +++ b/src/main/java/calculationEngine/entities/CePlayer.java @@ -17,7 +17,7 @@ public CePlayer(CeStats ceStats, List ceAttacks, List team, super(ceStats, ceAttacks, Integer.MAX_VALUE, false); this.team = team; this.isAI = isAI; - this.inventory = new CeInventory(); + this.inventory = new CeInventory(this.getCeStats()); } // Constructor for AI diff --git a/src/main/java/calculationEngine/entities/CeStats.java b/src/main/java/calculationEngine/entities/CeStats.java index bb7ccec..2a09620 100644 --- a/src/main/java/calculationEngine/entities/CeStats.java +++ b/src/main/java/calculationEngine/entities/CeStats.java @@ -1,5 +1,7 @@ package calculationEngine.entities; +import calculationEngine.environment.CeItem; +import calculationEngine.environment.CeItemBonusStats; import config.AiConstants; import config.EntityConstants; import config.PlayerConfig; @@ -18,6 +20,7 @@ public class CeStats { private int attack; private int defense; private int friendshipPoints; + private int critBonus = 0; private Random random = new Random(); @@ -36,7 +39,7 @@ public CeStats(CeBeastTypes type, CeNature nature, int level, int currentHitPoin } // Constructor for a new random Beast - public CeStats(CeBeasts beast, int playerLvl){ + public CeStats(CeBeasts beast, int playerLvl) { // calculate Level this.level = calcLvl(playerLvl); this.nature = CeNature.getRandomNature(); @@ -50,7 +53,7 @@ public CeStats(CeBeasts beast, int playerLvl){ this.defense = scaleOnLvl(beast.getBaseDefense(), this.level, beast.getDefenseLvlScaling()) + (random.nextInt(EntityConstants.DEFENSE_RANGE * 2) - EntityConstants.DEFENSE_RANGE); } - public CeStats(CeBeasts beast){ // dev constructor + public CeStats(CeBeasts beast) { // dev constructor this.type = beast.getType(); this.nature = CeNature.getRandomNature(); this.currentHitPoints = beast.getBaseHp(); @@ -64,7 +67,7 @@ public CeStats(CeBeasts beast){ // dev constructor } // AI NPC Constructor - public CeStats(int playerLvl, CeBeastTypes type){ + public CeStats(int playerLvl, CeBeastTypes type) { this.level = calcLvl(playerLvl); this.type = type; this.nature = CeNature.getRandomNature(); @@ -78,7 +81,7 @@ public CeStats(int playerLvl, CeBeastTypes type){ this.friendshipPoints = 0; } - public CeStats(CeStats ceStats){ + public CeStats(CeStats ceStats) { this.level = ceStats.getLevel(); this.currentHitPoints = ceStats.getCurrentHitPoints(); this.maxHitPoints = ceStats.getMaxHitPoints(); @@ -98,6 +101,24 @@ private int calcLvl(int playerLvl) { } + public void applyBonusStats(CeItemBonusStats ceItemBonusStats) { + this.attack += ceItemBonusStats.getAttack(); + this.defense += ceItemBonusStats.getDefense(); + this.maxHitPoints += ceItemBonusStats.getHealthPoints(); + this.speed += ceItemBonusStats.getSpeed(); + this.stamina += ceItemBonusStats.getStamina(); + this.critBonus += ceItemBonusStats.getCritBonus(); + } + + public void removeBonusStats(CeItemBonusStats ceItemBonusStats) { + this.attack -= ceItemBonusStats.getAttack(); + this.defense -= ceItemBonusStats.getDefense(); + this.maxHitPoints -= ceItemBonusStats.getHealthPoints(); + this.speed -= ceItemBonusStats.getSpeed(); + this.stamina -= ceItemBonusStats.getStamina(); + this.critBonus -= ceItemBonusStats.getCritBonus(); + } + public static int scaleOnLvl(int base, int lvl, int lvlScaling) { return base + lvl * lvlScaling; } @@ -153,4 +174,8 @@ public void setCurrentHitPoints(int currentHitPoints) { public void setMaxHitPoints(int maxHitPoints) { this.maxHitPoints = maxHitPoints; } + + public int getCritBonus() { + return critBonus; + } } diff --git a/src/main/java/calculationEngine/environment/CeItem.java b/src/main/java/calculationEngine/environment/CeItem.java index a71e451..7e76c0c 100644 --- a/src/main/java/calculationEngine/environment/CeItem.java +++ b/src/main/java/calculationEngine/environment/CeItem.java @@ -12,6 +12,7 @@ public class CeItem { private int uses; private CeItemBonusStats itemBonusStats; private String description; + private CeItemEffects effect; public CeItem() { } @@ -34,6 +35,7 @@ private void setItem(JSONObject itemJson) { this.uses = itemJson.getInt("uses"); this.itemBonusStats = new CeItemBonusStats(CeLoot.jsonArrayToIntArray(itemJson.getJSONArray("bonusStats"))); this.description = itemJson.getString("description"); + this.effect = new CeItemEffects(itemJson.getJSONObject("effects")); } public void equip() { diff --git a/src/main/java/calculationEngine/environment/CeItemEffects.java b/src/main/java/calculationEngine/environment/CeItemEffects.java new file mode 100644 index 0000000..e2c1659 --- /dev/null +++ b/src/main/java/calculationEngine/environment/CeItemEffects.java @@ -0,0 +1,41 @@ +package calculationEngine.environment; + +import calculationEngine.entities.CeStats; +import org.json.JSONObject; + +public class CeItemEffects { + + effects effect; + String description; + int value; + + private enum effects{ + heal, + increaseDamage, + increaseSpeed, + increaseAttack, + increaseCritBonus, + increaseDefense; + } + + public CeItemEffects(JSONObject effectObject){ + this.effect = effects.valueOf(effectObject.getString("type")); + this.value = effectObject.getInt("value"); + } + + public void use(CeStats ceStats, CeItemBonusStats ceItemBonusStats){ + switch (this.name()){ + case "heal": + int hitPoints = ceStats.getCurrentHitPoints(); + hitPoints += ceItemBonusStats.getHealthPoints(); + } + } + +} + +class a{ + public static void main(String[] args) { + CeItemEffects effect = CeItemEffects.heal; + System.out.println(effect.name()); + } +} diff --git a/src/main/java/calculationEngine/environment/TestItems.java b/src/main/java/calculationEngine/environment/TestItems.java index a22cd98..14e391b 100644 --- a/src/main/java/calculationEngine/environment/TestItems.java +++ b/src/main/java/calculationEngine/environment/TestItems.java @@ -1,12 +1,14 @@ package calculationEngine.environment; +import calculationEngine.entities.CeBeasts; import calculationEngine.entities.CeInventory; +import calculationEngine.entities.CeStats; import calculationEngine.entities.NoPlaceInInventoryException; public class TestItems { public static void main(String[] args) throws NoPlaceInInventoryException { System.out.println(CeLoot.lootItem("cage").toString()); - CeInventory inventory = new CeInventory(); + CeInventory inventory = new CeInventory(new CeStats(CeBeasts.StinkenderFeuerFurz)); inventory.addItemToInventory(CeLoot.lootItem("cage")); System.out.println("Amount: " + inventory.getSlots()[0].getAmount()); // should be 1 inventory.addItemToInventory(CeLoot.lootItem("cage")); diff --git a/src/main/resources/items.JSON b/src/main/resources/items.JSON index a74b79b..064fcb9 100644 --- a/src/main/resources/items.JSON +++ b/src/main/resources/items.JSON @@ -27,7 +27,11 @@ "description": "Heals a portion of your life", "probability": "80", "uses": 1, - "effects": "Heals 10HP", + "effects": { + "description": "Heals 10HP", + "type": "healing", + "value": 10 + }, "unique": false, "type": "consumable", "bonusStats":[ diff --git a/src/test/java/calculationEngine.enviroment/CeInventoryTest.java b/src/test/java/calculationEngine.enviroment/CeInventoryTest.java index 9b8b408..6e72052 100644 --- a/src/test/java/calculationEngine.enviroment/CeInventoryTest.java +++ b/src/test/java/calculationEngine.enviroment/CeInventoryTest.java @@ -1,8 +1,6 @@ package calculationEngine.enviroment; -import calculationEngine.entities.CeInventory; -import calculationEngine.entities.CeSlot; -import calculationEngine.entities.NoPlaceInInventoryException; +import calculationEngine.entities.*; import calculationEngine.environment.CeItem; import org.json.JSONObject; import org.junit.Before; @@ -17,7 +15,7 @@ public class CeInventoryTest { @Before public void setUp() { - ceInventory = new CeInventory(); + ceInventory = new CeInventory(new CeStats(CeBeasts.StinkenderFeuerFurz)); } @Test From 94a23b14dd7b140c34d4ac3a200e22c27853ba93 Mon Sep 17 00:00:00 2001 From: lkno0705 Date: Thu, 27 May 2021 22:40:40 +0200 Subject: [PATCH 02/19] Add Itemeffects, itemBonusStats Stat manipulation test, use healing Potion test (without Junit) --- .../entities/CeInventory.java | 19 ++++-- .../calculationEngine/entities/CeStats.java | 42 ++++++++++++ .../calculationEngine/environment/CeItem.java | 4 +- .../environment/CeItemEffects.java | 65 ++++++++++++++----- .../environment/TestItems.java | 30 +++++++-- src/main/resources/items.JSON | 36 ++++++++-- 6 files changed, 163 insertions(+), 33 deletions(-) diff --git a/src/main/java/calculationEngine/entities/CeInventory.java b/src/main/java/calculationEngine/entities/CeInventory.java index 148c93b..1d0e2a0 100644 --- a/src/main/java/calculationEngine/entities/CeInventory.java +++ b/src/main/java/calculationEngine/entities/CeInventory.java @@ -75,6 +75,7 @@ public void useItem(CeItem item) throws ItemNotInInventoryException { if (slotItem != null) { if (slotItem.compareTo(item)) { matchingItem = true; + slotItem.use(this.playerStats); int remainingAmount = slot.decreaseAmount(); if (remainingAmount <= 0) { slot.reset(); @@ -134,9 +135,10 @@ public void setEquippedItem(CeItem equippedItem) throws WrongItemException { } private void setEquippedArmorShoulder(CeItem equippedArmorShoulder) throws WrongItemException { - if (this.equippedArmorShoulder != null) + if (this.equippedArmorShoulder != null) { this.playerStats.removeBonusStats(this.equippedArmorShoulder.getItemBonusStats()); this.equippedArmorShoulder.unequip(); + } if (equippedArmorShoulder.getType() == armorShoulder) { this.equippedArmorShoulder = equippedArmorShoulder; this.equippedArmorShoulder.equip(); @@ -145,9 +147,10 @@ private void setEquippedArmorShoulder(CeItem equippedArmorShoulder) throws Wrong } private void setEquippedArmorShoes(CeItem equippedArmorShoes) throws WrongItemException { - if (this.equippedArmorShoes != null) + if (this.equippedArmorShoes != null) { this.playerStats.removeBonusStats(this.equippedArmorShoes.getItemBonusStats()); this.equippedArmorShoes.unequip(); + } if (equippedArmorShoes.getType() == armorShoes) { this.equippedArmorShoes = equippedArmorShoes; this.equippedArmorShoes.equip(); @@ -156,9 +159,10 @@ private void setEquippedArmorShoes(CeItem equippedArmorShoes) throws WrongItemEx } private void setEquippedArmorLegs(CeItem equippedArmorLegs) throws WrongItemException { - if (this.equippedArmorLegs != null) + if (this.equippedArmorLegs != null) { this.playerStats.removeBonusStats(this.equippedArmorLegs.getItemBonusStats()); this.equippedArmorLegs.unequip(); + } if (equippedArmorLegs.getType() == armorLegs) { this.equippedArmorLegs = equippedArmorLegs; this.equippedArmorLegs.equip(); @@ -167,9 +171,10 @@ private void setEquippedArmorLegs(CeItem equippedArmorLegs) throws WrongItemExce } private void setEquippedArmorChest(CeItem equippedArmorChest) throws WrongItemException { - if (this.equippedArmorChest != null) + if (this.equippedArmorChest != null) { this.playerStats.removeBonusStats(this.equippedArmorChest.getItemBonusStats()); this.equippedArmorChest.unequip(); + } if (equippedArmorChest.getType() == armorChest) { this.equippedArmorChest = equippedArmorChest; this.equippedArmorChest.equip(); @@ -178,9 +183,10 @@ private void setEquippedArmorChest(CeItem equippedArmorChest) throws WrongItemEx } private void setEquippedArmorHead(CeItem equippedArmorHead) throws WrongItemException { - if (this.equippedArmorHead != null) + if (this.equippedArmorHead != null) { this.playerStats.removeBonusStats(this.equippedArmorHead.getItemBonusStats()); this.equippedArmorHead.unequip(); + } if (equippedArmorHead.getType() == armorHead) { this.equippedArmorHead = equippedArmorHead; this.equippedArmorHead.equip(); @@ -189,9 +195,10 @@ private void setEquippedArmorHead(CeItem equippedArmorHead) throws WrongItemExce } private void setEquippedWeapon(CeItem equippedWeapon) throws WrongItemException { - if (this.equippedWeapon != null) + if (this.equippedWeapon != null) { this.playerStats.removeBonusStats(this.equippedWeapon.getItemBonusStats()); this.equippedWeapon.unequip(); + } if (equippedWeapon.getType() == weapon) { this.equippedWeapon = equippedWeapon; this.equippedWeapon.equip(); diff --git a/src/main/java/calculationEngine/entities/CeStats.java b/src/main/java/calculationEngine/entities/CeStats.java index 2a09620..58388f6 100644 --- a/src/main/java/calculationEngine/entities/CeStats.java +++ b/src/main/java/calculationEngine/entities/CeStats.java @@ -178,4 +178,46 @@ public void setMaxHitPoints(int maxHitPoints) { public int getCritBonus() { return critBonus; } + + public void setSpeed(int speed) { + this.speed = speed; + } + + public void setStamina(int stamina) { + this.stamina = stamina; + } + + public void setAttack(int attack) { + this.attack = attack; + } + + public void setDefense(int defense) { + this.defense = defense; + } + + public void setFriendshipPoints(int friendshipPoints) { + this.friendshipPoints = friendshipPoints; + } + + public void setCritBonus(int critBonus) { + this.critBonus = critBonus; + } + + @Override + public String toString() { + return "CeStats{" + + "type=" + type + + ", nature=" + nature + + ", level=" + level + + ", currentHitPoints=" + currentHitPoints + + ", maxHitPoints=" + maxHitPoints + + ", speed=" + speed + + ", stamina=" + stamina + + ", attack=" + attack + + ", defense=" + defense + + ", friendshipPoints=" + friendshipPoints + + ", critBonus=" + critBonus + + ", random=" + random + + '}'; + } } diff --git a/src/main/java/calculationEngine/environment/CeItem.java b/src/main/java/calculationEngine/environment/CeItem.java index 7e76c0c..5b6f29e 100644 --- a/src/main/java/calculationEngine/environment/CeItem.java +++ b/src/main/java/calculationEngine/environment/CeItem.java @@ -1,5 +1,6 @@ package calculationEngine.environment; +import calculationEngine.entities.CeStats; import org.json.JSONObject; public class CeItem { @@ -46,7 +47,8 @@ public void unequip() { this.equipped = false; } - public int use() { + public int use(CeStats ceStats) { + this.effect.use(ceStats); this.uses--; return this.uses; //return remaining uses, so they can be handled in the iventory handler } diff --git a/src/main/java/calculationEngine/environment/CeItemEffects.java b/src/main/java/calculationEngine/environment/CeItemEffects.java index e2c1659..b11df65 100644 --- a/src/main/java/calculationEngine/environment/CeItemEffects.java +++ b/src/main/java/calculationEngine/environment/CeItemEffects.java @@ -1,41 +1,74 @@ package calculationEngine.environment; import calculationEngine.entities.CeStats; +import config.BattleConstants; +import config.LootConfig; import org.json.JSONObject; public class CeItemEffects { - effects effect; - String description; - int value; + private effects effect; + private String description; + private int value; + + private static final boolean debug = BattleConstants.battleDebug; private enum effects{ - heal, - increaseDamage, + healing, increaseSpeed, increaseAttack, increaseCritBonus, - increaseDefense; + increaseDefense, + catchBeast, + defaultEffect } public CeItemEffects(JSONObject effectObject){ this.effect = effects.valueOf(effectObject.getString("type")); this.value = effectObject.getInt("value"); + this.description = effectObject.getString("description"); } - public void use(CeStats ceStats, CeItemBonusStats ceItemBonusStats){ - switch (this.name()){ - case "heal": + public void use(CeStats ceStats){ + switch (this.effect.name()){ + case "healing": int hitPoints = ceStats.getCurrentHitPoints(); - hitPoints += ceItemBonusStats.getHealthPoints(); + hitPoints += this.value; + ceStats.setCurrentHitPoints(hitPoints); + if (debug) System.out.println("[CeItemEffects] healing by " + this.value + " points"); + break; + case "increaseSpeed": + int speed = ceStats.getSpeed(); + speed += this.value; + ceStats.setSpeed(speed); + break; + case "increaseAttack": + int attack = ceStats.getAttack(); + attack += this.value; + ceStats.setAttack(attack); + break; + case "increaseCritBonus": + int critBonus = ceStats.getCritBonus(); + critBonus += this.value; + ceStats.setCritBonus(critBonus); + break; + case "increaseDefense": + int defense = ceStats.getDefense(); + defense += this.value; + ceStats.setDefense(defense); + break; } } -} + public effects getEffect() { + return effect; + } + + public String getDescription() { + return description; + } -class a{ - public static void main(String[] args) { - CeItemEffects effect = CeItemEffects.heal; - System.out.println(effect.name()); + public int getValue() { + return value; } -} +} \ No newline at end of file diff --git a/src/main/java/calculationEngine/environment/TestItems.java b/src/main/java/calculationEngine/environment/TestItems.java index 14e391b..39daa85 100644 --- a/src/main/java/calculationEngine/environment/TestItems.java +++ b/src/main/java/calculationEngine/environment/TestItems.java @@ -1,9 +1,10 @@ package calculationEngine.environment; -import calculationEngine.entities.CeBeasts; -import calculationEngine.entities.CeInventory; -import calculationEngine.entities.CeStats; -import calculationEngine.entities.NoPlaceInInventoryException; +import calculationEngine.battle.WrongItemException; +import calculationEngine.entities.*; + +import java.util.ArrayList; +import java.util.List; public class TestItems { public static void main(String[] args) throws NoPlaceInInventoryException { @@ -16,5 +17,26 @@ public static void main(String[] args) throws NoPlaceInInventoryException { inventory.addItemToInventory(CeLoot.lootItem("aHealingPotion")); System.out.println(inventory.getSlots()[1].getItem().toString()); + List team = new ArrayList<>(); + List attacks = new ArrayList<>(); + attacks.add(new CeAttack(CeAttacks.Punch)); + CePlayer cePlayer1 = new CePlayer(new CeStats(CeBeastTypes.PlayerStandard, CeNature.ANGRY, 1, 100, 100, 50, 200, 200, 200, 1), attacks, team, false); + + System.out.println(cePlayer1.getCeStats().getCurrentHitPoints()); + System.out.println(cePlayer1.getCeStats().toString()); + cePlayer1.getInventory().addItemToInventory(CeLoot.lootItem("aGreaterHealingPotion")); + try { + cePlayer1.getInventory().useItem(CeLoot.lootItem("aGreaterHealingPotion")); + System.out.println(cePlayer1.getCeStats().getCurrentHitPoints()); + } catch (ItemNotInInventoryException itemNotInInventoryException) { + itemNotInInventoryException.printStackTrace(); + } + cePlayer1.getInventory().addItemToInventory(CeLoot.lootItem("stickOfBeating")); + try { + cePlayer1.getInventory().setEquippedItem(CeLoot.lootItem("stickOfBeating")); + } catch (WrongItemException wrongItemException) { + wrongItemException.printStackTrace(); + } + System.out.println(cePlayer1.getCeStats().toString()); } } diff --git a/src/main/resources/items.JSON b/src/main/resources/items.JSON index 064fcb9..34b5f06 100644 --- a/src/main/resources/items.JSON +++ b/src/main/resources/items.JSON @@ -6,7 +6,11 @@ "description": "Cage to catch a litteBeast", "probability": "90", "uses": 1, - "effects": "Catch", + "effects": { + "description": "Catch a beast", + "type": "catchBeast", + "value": 0 + }, "unique": false, "type": "cage", "bonusStats":[ @@ -52,7 +56,11 @@ "description": "Heals a portion of your life", "probability": "20", "uses": 1, - "effects": "Heals 10HP", + "effects": { + "description": "Heals 10HP", + "type": "healing", + "value": 10 + }, "type": "consumable", "unique": false, "bonusStats":[ @@ -73,7 +81,11 @@ "description": "It's a stick, you can hit someone with it. Don't.", "probability": "80", "uses": 1, - "effects": "It hurts.", + "effects": { + "description": "It Hurts", + "type": "defaultEffect", + "value": 0 + }, "type": "weapon", "unique": false, "bonusStats":[ @@ -94,7 +106,11 @@ "description": "It's a stick, you can hit someone with it. Do.", "probability": "20", "uses": 1, - "effects": "It hurts.", + "effects": { + "description": "It hurts", + "type": "defaultEffect", + "value": 0 + }, "type": "weapon", "unique": false, "bonusStats":[ @@ -115,7 +131,11 @@ "description": "It's Zordons Hammer, what do you think it will do?", "probability": "90", "uses": 1, - "effects": "Hammers like crazy", + "effects": { + "description": "Hammers like crazy", + "type": "defaultEffect", + "value": 0 + }, "type": "weapon", "unique": false, "bonusStats":[ @@ -136,7 +156,11 @@ "description": "It's Karls Hammer, it hammers", "probability": "10", "uses": 1, - "effects": "Hammers like totally crazy", + "effects": { + "description": "Hammers like totally crazy", + "type": "defaultEffect", + "value": 0 + }, "type": "weapon", "unique": false, "bonusStats":[ From b2df374c9af4e275c86d9686d7d9f9c9264b9f7e Mon Sep 17 00:00:00 2001 From: lkno0705 Date: Thu, 27 May 2021 22:44:21 +0200 Subject: [PATCH 03/19] fix unitTests --- src/test/resources/items.JSON | 42 +++++++++++++++++++++++++++++------ 1 file changed, 35 insertions(+), 7 deletions(-) diff --git a/src/test/resources/items.JSON b/src/test/resources/items.JSON index a74b79b..34b5f06 100644 --- a/src/test/resources/items.JSON +++ b/src/test/resources/items.JSON @@ -6,7 +6,11 @@ "description": "Cage to catch a litteBeast", "probability": "90", "uses": 1, - "effects": "Catch", + "effects": { + "description": "Catch a beast", + "type": "catchBeast", + "value": 0 + }, "unique": false, "type": "cage", "bonusStats":[ @@ -27,7 +31,11 @@ "description": "Heals a portion of your life", "probability": "80", "uses": 1, - "effects": "Heals 10HP", + "effects": { + "description": "Heals 10HP", + "type": "healing", + "value": 10 + }, "unique": false, "type": "consumable", "bonusStats":[ @@ -48,7 +56,11 @@ "description": "Heals a portion of your life", "probability": "20", "uses": 1, - "effects": "Heals 10HP", + "effects": { + "description": "Heals 10HP", + "type": "healing", + "value": 10 + }, "type": "consumable", "unique": false, "bonusStats":[ @@ -69,7 +81,11 @@ "description": "It's a stick, you can hit someone with it. Don't.", "probability": "80", "uses": 1, - "effects": "It hurts.", + "effects": { + "description": "It Hurts", + "type": "defaultEffect", + "value": 0 + }, "type": "weapon", "unique": false, "bonusStats":[ @@ -90,7 +106,11 @@ "description": "It's a stick, you can hit someone with it. Do.", "probability": "20", "uses": 1, - "effects": "It hurts.", + "effects": { + "description": "It hurts", + "type": "defaultEffect", + "value": 0 + }, "type": "weapon", "unique": false, "bonusStats":[ @@ -111,7 +131,11 @@ "description": "It's Zordons Hammer, what do you think it will do?", "probability": "90", "uses": 1, - "effects": "Hammers like crazy", + "effects": { + "description": "Hammers like crazy", + "type": "defaultEffect", + "value": 0 + }, "type": "weapon", "unique": false, "bonusStats":[ @@ -132,7 +156,11 @@ "description": "It's Karls Hammer, it hammers", "probability": "10", "uses": 1, - "effects": "Hammers like totally crazy", + "effects": { + "description": "Hammers like totally crazy", + "type": "defaultEffect", + "value": 0 + }, "type": "weapon", "unique": false, "bonusStats":[ From 0382d6142100e6778739b53177902863edc79a48 Mon Sep 17 00:00:00 2001 From: lkno0705 Date: Fri, 28 May 2021 13:33:02 +0200 Subject: [PATCH 04/19] add default case --- src/main/java/calculationEngine/environment/CeItemEffects.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/calculationEngine/environment/CeItemEffects.java b/src/main/java/calculationEngine/environment/CeItemEffects.java index b11df65..4d108e6 100644 --- a/src/main/java/calculationEngine/environment/CeItemEffects.java +++ b/src/main/java/calculationEngine/environment/CeItemEffects.java @@ -57,6 +57,7 @@ public void use(CeStats ceStats){ defense += this.value; ceStats.setDefense(defense); break; + default: break; } } From 736be04e8c5ef3d1088995f2e7ec0f82dc6e6405 Mon Sep 17 00:00:00 2001 From: lkno0705 Date: Fri, 28 May 2021 13:43:44 +0200 Subject: [PATCH 05/19] change some codacy bs --- src/main/java/calculationEngine/entities/CeStats.java | 2 -- src/main/java/calculationEngine/environment/CeItemEffects.java | 1 - src/test/java/calculationEngine.enviroment/CeInventoryTest.java | 1 - 3 files changed, 4 deletions(-) diff --git a/src/main/java/calculationEngine/entities/CeStats.java b/src/main/java/calculationEngine/entities/CeStats.java index 58388f6..3838a0c 100644 --- a/src/main/java/calculationEngine/entities/CeStats.java +++ b/src/main/java/calculationEngine/entities/CeStats.java @@ -1,10 +1,8 @@ package calculationEngine.entities; -import calculationEngine.environment.CeItem; import calculationEngine.environment.CeItemBonusStats; import config.AiConstants; import config.EntityConstants; -import config.PlayerConfig; import java.util.Random; diff --git a/src/main/java/calculationEngine/environment/CeItemEffects.java b/src/main/java/calculationEngine/environment/CeItemEffects.java index 4d108e6..ae9d331 100644 --- a/src/main/java/calculationEngine/environment/CeItemEffects.java +++ b/src/main/java/calculationEngine/environment/CeItemEffects.java @@ -2,7 +2,6 @@ import calculationEngine.entities.CeStats; import config.BattleConstants; -import config.LootConfig; import org.json.JSONObject; public class CeItemEffects { diff --git a/src/test/java/calculationEngine.enviroment/CeInventoryTest.java b/src/test/java/calculationEngine.enviroment/CeInventoryTest.java index 6e72052..60bfd50 100644 --- a/src/test/java/calculationEngine.enviroment/CeInventoryTest.java +++ b/src/test/java/calculationEngine.enviroment/CeInventoryTest.java @@ -5,7 +5,6 @@ import org.json.JSONObject; import org.junit.Before; import org.junit.Test; -import org.mockito.Mockito; import static config.LootConfig.itemList; import static org.junit.Assert.*; From 5f515b680d3e2c5609c1fe846fca9082fc9a8982 Mon Sep 17 00:00:00 2001 From: lkno0705 Date: Fri, 28 May 2021 13:47:35 +0200 Subject: [PATCH 06/19] change some more codacy bs --- .../java/calculationEngine/environment/CeItemEffects.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/calculationEngine/environment/CeItemEffects.java b/src/main/java/calculationEngine/environment/CeItemEffects.java index ae9d331..b3caf2f 100644 --- a/src/main/java/calculationEngine/environment/CeItemEffects.java +++ b/src/main/java/calculationEngine/environment/CeItemEffects.java @@ -6,13 +6,13 @@ public class CeItemEffects { - private effects effect; + private Effects effect; private String description; private int value; private static final boolean debug = BattleConstants.battleDebug; - private enum effects{ + private enum Effects { healing, increaseSpeed, increaseAttack, @@ -23,7 +23,7 @@ private enum effects{ } public CeItemEffects(JSONObject effectObject){ - this.effect = effects.valueOf(effectObject.getString("type")); + this.effect = Effects.valueOf(effectObject.getString("type")); this.value = effectObject.getInt("value"); this.description = effectObject.getString("description"); } @@ -60,7 +60,7 @@ public void use(CeStats ceStats){ } } - public effects getEffect() { + public Effects getEffect() { return effect; } From 25762aed3edc649893b8bec28bb0bb59f0e17b3b Mon Sep 17 00:00:00 2001 From: lkno0705 Date: Fri, 28 May 2021 13:59:13 +0200 Subject: [PATCH 07/19] change some more codacy bs --- .../calculationEngine/entities/CeInventory.java | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/main/java/calculationEngine/entities/CeInventory.java b/src/main/java/calculationEngine/entities/CeInventory.java index 1d0e2a0..a1ace77 100644 --- a/src/main/java/calculationEngine/entities/CeInventory.java +++ b/src/main/java/calculationEngine/entities/CeInventory.java @@ -11,14 +11,14 @@ public class CeInventory { - CeItem equippedArmorShoulder; - CeItem equippedArmorShoes; - CeItem equippedArmorLegs; - CeItem equippedArmorChest; - CeItem equippedArmorHead; - CeItem equippedWeapon; - - CeStats playerStats; + private CeItem equippedArmorShoulder; + private CeItem equippedArmorShoes; + private CeItem equippedArmorLegs; + private CeItem equippedArmorChest; + private CeItem equippedArmorHead; + private CeItem equippedWeapon; + + private CeStats playerStats; int maxItemSlots = 10; CeSlot[] slots = new CeSlot[maxItemSlots]; From a1938791bcb714faa4fd99744aae81be688b996b Mon Sep 17 00:00:00 2001 From: lkno0705 Date: Sat, 29 May 2021 15:31:57 +0200 Subject: [PATCH 08/19] delete the best constructor in history --- src/main/java/calculationEngine/entities/CeAi.java | 2 +- .../calculationEngine/entities/CeInventory.java | 2 ++ .../java/calculationEngine/entities/CeStats.java | 13 ------------- 3 files changed, 3 insertions(+), 14 deletions(-) diff --git a/src/main/java/calculationEngine/entities/CeAi.java b/src/main/java/calculationEngine/entities/CeAi.java index 66019b6..8a6e637 100644 --- a/src/main/java/calculationEngine/entities/CeAi.java +++ b/src/main/java/calculationEngine/entities/CeAi.java @@ -45,7 +45,7 @@ private void finishAIConstruction(CeEntity ceBeast){ ); this.setTeam(team); if (debug) System.out.println("[AI Construction]: AI CREATION: " + ceBeast.toString()); - this.setCeStats(new CeStats(ceBeast.getCeStats())); + this.setCeStats(ceBeast.getCeStats()); this.getCeStats().setMaxHitPoints(0); this.getCeStats().setCurrentHitPoints(0); this.currentMonster = this.getTeam().get(0); diff --git a/src/main/java/calculationEngine/entities/CeInventory.java b/src/main/java/calculationEngine/entities/CeInventory.java index a1ace77..e043f3e 100644 --- a/src/main/java/calculationEngine/entities/CeInventory.java +++ b/src/main/java/calculationEngine/entities/CeInventory.java @@ -75,6 +75,7 @@ public void useItem(CeItem item) throws ItemNotInInventoryException { if (slotItem != null) { if (slotItem.compareTo(item)) { matchingItem = true; + //TODO: Add switch case for item type and call correct Methods slotItem.use(this.playerStats); int remainingAmount = slot.decreaseAmount(); if (remainingAmount <= 0) { @@ -138,6 +139,7 @@ private void setEquippedArmorShoulder(CeItem equippedArmorShoulder) throws Wrong if (this.equippedArmorShoulder != null) { this.playerStats.removeBonusStats(this.equippedArmorShoulder.getItemBonusStats()); this.equippedArmorShoulder.unequip(); + // TODO: set to null } if (equippedArmorShoulder.getType() == armorShoulder) { this.equippedArmorShoulder = equippedArmorShoulder; diff --git a/src/main/java/calculationEngine/entities/CeStats.java b/src/main/java/calculationEngine/entities/CeStats.java index 3838a0c..3edc9c2 100644 --- a/src/main/java/calculationEngine/entities/CeStats.java +++ b/src/main/java/calculationEngine/entities/CeStats.java @@ -79,19 +79,6 @@ public CeStats(int playerLvl, CeBeastTypes type) { this.friendshipPoints = 0; } - public CeStats(CeStats ceStats) { - this.level = ceStats.getLevel(); - this.currentHitPoints = ceStats.getCurrentHitPoints(); - this.maxHitPoints = ceStats.getMaxHitPoints(); - this.speed = ceStats.getSpeed(); - this.stamina = ceStats.getStamina(); - this.attack = ceStats.getAttack(); - this.defense = ceStats.getDefense(); - this.friendshipPoints = ceStats.getFriendshipPoints(); - this.type = ceStats.getType(); - this.nature = ceStats.getNature(); - } - private int calcLvl(int playerLvl) { int tmpLevel = playerLvl + (random.nextInt(EntityConstants.LVL_RANGE * 2) - EntityConstants.LVL_RANGE); boolean lvlInRange = EntityConstants.MAX_LVL >= tmpLevel && EntityConstants.START_LVL <= tmpLevel; From e46b6cd810f2ef3d884d2a483a2a261a7d556467 Mon Sep 17 00:00:00 2001 From: lkno0705 Date: Mon, 31 May 2021 12:55:44 +0200 Subject: [PATCH 09/19] Codacy BS --- .../CeExecuterService.java | 2 +- .../battle/CeBattle.java | 10 +++++----- .../battle/CeCatching.java | 16 ++++++++-------- .../battle/CeDamage.java | 10 +++++----- .../battle/WrongItemException.java | 4 ++-- .../battle/testBattle.java | 10 +++++----- .../entities/CeAi.java | 6 +++--- .../entities/CeAttack.java | 2 +- .../entities/CeAttacks.java | 2 +- .../entities/CeBeastTypes.java | 2 +- .../entities/CeBeasts.java | 4 ++-- .../entities/CeEntity.java | 4 ++-- .../entities/CeInventory.java | 12 ++++++------ .../entities/CeNature.java | 2 +- .../entities/CePlayer.java | 2 +- .../entities/CeSlot.java | 4 ++-- .../entities/CeStats.java | 4 ++-- .../entities/ItemNotInInventoryException.java | 4 ++-- .../entities/NoPlaceInInventoryException.java | 4 +--- .../environment/CeItem.java | 4 ++-- .../environment/CeItemBonusStats.java | 2 +- .../environment/CeItemEffects.java | 4 ++-- .../environment/CeItemTypes.java | 2 +- .../environment/CeLoot.java | 4 ++-- .../environment/CeRegions.java | 2 +- .../environment/TestItems.java | 6 +++--- src/main/java/config/BattleConstants.java | 2 +- .../{GlobalConfig.java => GlobalConstants.java} | 2 +- .../{LootConfig.java => LootConstants.java} | 2 +- src/main/java/config/PlayerConfig.java | 4 ++-- .../CeInventoryTest.java | 8 ++++---- 31 files changed, 72 insertions(+), 74 deletions(-) rename src/main/java/{calculationEngine => calculationengine}/CeExecuterService.java (97%) rename src/main/java/{calculationEngine => calculationengine}/battle/CeBattle.java (97%) rename src/main/java/{calculationEngine => calculationengine}/battle/CeCatching.java (83%) rename src/main/java/{calculationEngine => calculationengine}/battle/CeDamage.java (92%) rename src/main/java/{calculationEngine => calculationengine}/battle/WrongItemException.java (71%) rename src/main/java/{calculationEngine => calculationengine}/battle/testBattle.java (95%) rename src/main/java/{calculationEngine => calculationengine}/entities/CeAi.java (93%) rename src/main/java/{calculationEngine => calculationengine}/entities/CeAttack.java (98%) rename src/main/java/{calculationEngine => calculationengine}/entities/CeAttacks.java (98%) rename src/main/java/{calculationEngine => calculationengine}/entities/CeBeastTypes.java (96%) rename src/main/java/{calculationEngine => calculationengine}/entities/CeBeasts.java (97%) rename src/main/java/{calculationEngine => calculationengine}/entities/CeEntity.java (98%) rename src/main/java/{calculationEngine => calculationengine}/entities/CeInventory.java (96%) rename src/main/java/{calculationEngine => calculationengine}/entities/CeNature.java (89%) rename src/main/java/{calculationEngine => calculationengine}/entities/CePlayer.java (97%) rename src/main/java/{calculationEngine => calculationengine}/entities/CeSlot.java (89%) rename src/main/java/{calculationEngine => calculationengine}/entities/CeStats.java (98%) rename src/main/java/{calculationEngine => calculationengine}/entities/ItemNotInInventoryException.java (70%) rename src/main/java/{calculationEngine => calculationengine}/entities/NoPlaceInInventoryException.java (63%) rename src/main/java/{calculationEngine => calculationengine}/environment/CeItem.java (97%) rename src/main/java/{calculationEngine => calculationengine}/environment/CeItemBonusStats.java (97%) rename src/main/java/{calculationEngine => calculationengine}/environment/CeItemEffects.java (96%) rename src/main/java/{calculationEngine => calculationengine}/environment/CeItemTypes.java (79%) rename src/main/java/{calculationEngine => calculationengine}/environment/CeLoot.java (95%) rename src/main/java/{calculationEngine => calculationengine}/environment/CeRegions.java (71%) rename src/main/java/{calculationEngine => calculationengine}/environment/TestItems.java (94%) rename src/main/java/config/{GlobalConfig.java => GlobalConstants.java} (80%) rename src/main/java/config/{LootConfig.java => LootConstants.java} (91%) diff --git a/src/main/java/calculationEngine/CeExecuterService.java b/src/main/java/calculationengine/CeExecuterService.java similarity index 97% rename from src/main/java/calculationEngine/CeExecuterService.java rename to src/main/java/calculationengine/CeExecuterService.java index 10d6ff4..33cf799 100644 --- a/src/main/java/calculationEngine/CeExecuterService.java +++ b/src/main/java/calculationengine/CeExecuterService.java @@ -1,4 +1,4 @@ -package calculationEngine; +package calculationengine; import config.BattleConstants; diff --git a/src/main/java/calculationEngine/battle/CeBattle.java b/src/main/java/calculationengine/battle/CeBattle.java similarity index 97% rename from src/main/java/calculationEngine/battle/CeBattle.java rename to src/main/java/calculationengine/battle/CeBattle.java index 2579a86..68da43f 100644 --- a/src/main/java/calculationEngine/battle/CeBattle.java +++ b/src/main/java/calculationengine/battle/CeBattle.java @@ -1,9 +1,9 @@ -package calculationEngine.battle; +package calculationengine.battle; -import calculationEngine.CeExecuterService; -import calculationEngine.entities.*; -import calculationEngine.environment.CeItem; -import calculationEngine.environment.CeItemTypes; +import calculationengine.CeExecuterService; +import calculationengine.entities.*; +import calculationengine.environment.CeItem; +import calculationengine.environment.CeItemTypes; import config.BattleConstants; import java.util.Random; diff --git a/src/main/java/calculationEngine/battle/CeCatching.java b/src/main/java/calculationengine/battle/CeCatching.java similarity index 83% rename from src/main/java/calculationEngine/battle/CeCatching.java rename to src/main/java/calculationengine/battle/CeCatching.java index 0834b12..9b0edec 100644 --- a/src/main/java/calculationEngine/battle/CeCatching.java +++ b/src/main/java/calculationengine/battle/CeCatching.java @@ -1,18 +1,18 @@ -package calculationEngine.battle; +package calculationengine.battle; -import calculationEngine.entities.CeAttack; -import calculationEngine.entities.CeBeastTypes; -import calculationEngine.entities.CeEntity; -import calculationEngine.entities.CePlayer; -import calculationEngine.environment.CeItem; -import config.GlobalConfig; +import calculationengine.entities.CeAttack; +import calculationengine.entities.CeBeastTypes; +import calculationengine.entities.CeEntity; +import calculationengine.entities.CePlayer; +import calculationengine.environment.CeItem; +import config.GlobalConstants; import java.util.Random; public class CeCatching { private static Random random = new Random(); private static String debugInfo; - private final static boolean bDebug = GlobalConfig.DEBUG_CONSOLE_OUT; + private final static boolean bDebug = GlobalConstants.DEBUG_CONSOLE_OUT; public static boolean isCaught(CePlayer player, CeEntity beast, CeItem cage) { diff --git a/src/main/java/calculationEngine/battle/CeDamage.java b/src/main/java/calculationengine/battle/CeDamage.java similarity index 92% rename from src/main/java/calculationEngine/battle/CeDamage.java rename to src/main/java/calculationengine/battle/CeDamage.java index da6578e..4878b16 100644 --- a/src/main/java/calculationEngine/battle/CeDamage.java +++ b/src/main/java/calculationengine/battle/CeDamage.java @@ -1,15 +1,15 @@ -package calculationEngine.battle; +package calculationengine.battle; -import calculationEngine.entities.CeAttack; -import calculationEngine.entities.CeEntity; -import config.GlobalConfig; +import calculationengine.entities.CeAttack; +import calculationengine.entities.CeEntity; +import config.GlobalConstants; import java.util.Random; public class CeDamage { private static Random random = new Random(); private static String debugInfo; - private final static boolean bDebug = GlobalConfig.DEBUG_CONSOLE_OUT; + private final static boolean bDebug = GlobalConstants.DEBUG_CONSOLE_OUT; public static int calculateDamage(CeEntity attacker, CeEntity defender, CeAttack ceAttack) { //roll to d50 to get a quasi normal distribution diff --git a/src/main/java/calculationEngine/battle/WrongItemException.java b/src/main/java/calculationengine/battle/WrongItemException.java similarity index 71% rename from src/main/java/calculationEngine/battle/WrongItemException.java rename to src/main/java/calculationengine/battle/WrongItemException.java index cbec3d0..96c8e5f 100644 --- a/src/main/java/calculationEngine/battle/WrongItemException.java +++ b/src/main/java/calculationengine/battle/WrongItemException.java @@ -1,6 +1,6 @@ -package calculationEngine.battle; +package calculationengine.battle; -import calculationEngine.environment.CeItem; +import calculationengine.environment.CeItem; public class WrongItemException extends Exception{ public WrongItemException(CeItem item, String expected) { diff --git a/src/main/java/calculationEngine/battle/testBattle.java b/src/main/java/calculationengine/battle/testBattle.java similarity index 95% rename from src/main/java/calculationEngine/battle/testBattle.java rename to src/main/java/calculationengine/battle/testBattle.java index a2daac8..0d6340c 100644 --- a/src/main/java/calculationEngine/battle/testBattle.java +++ b/src/main/java/calculationengine/battle/testBattle.java @@ -1,9 +1,9 @@ -package calculationEngine.battle; +package calculationengine.battle; -import calculationEngine.CeExecuterService; -import calculationEngine.entities.*; -import calculationEngine.environment.CeLoot; -import calculationEngine.environment.CeRegions; +import calculationengine.CeExecuterService; +import calculationengine.entities.*; +import calculationengine.environment.CeLoot; +import calculationengine.environment.CeRegions; import java.util.ArrayList; import java.util.List; diff --git a/src/main/java/calculationEngine/entities/CeAi.java b/src/main/java/calculationengine/entities/CeAi.java similarity index 93% rename from src/main/java/calculationEngine/entities/CeAi.java rename to src/main/java/calculationengine/entities/CeAi.java index 8a6e637..15591bd 100644 --- a/src/main/java/calculationEngine/entities/CeAi.java +++ b/src/main/java/calculationengine/entities/CeAi.java @@ -1,7 +1,7 @@ -package calculationEngine.entities; +package calculationengine.entities; -import calculationEngine.battle.CeBattle; -import calculationEngine.environment.CeRegions; +import calculationengine.battle.CeBattle; +import calculationengine.environment.CeRegions; import config.BattleConstants; import java.util.ArrayList; diff --git a/src/main/java/calculationEngine/entities/CeAttack.java b/src/main/java/calculationengine/entities/CeAttack.java similarity index 98% rename from src/main/java/calculationEngine/entities/CeAttack.java rename to src/main/java/calculationengine/entities/CeAttack.java index 9eaea81..f3b958f 100644 --- a/src/main/java/calculationEngine/entities/CeAttack.java +++ b/src/main/java/calculationengine/entities/CeAttack.java @@ -1,4 +1,4 @@ -package calculationEngine.entities; +package calculationengine.entities; import config.EntityConstants; diff --git a/src/main/java/calculationEngine/entities/CeAttacks.java b/src/main/java/calculationengine/entities/CeAttacks.java similarity index 98% rename from src/main/java/calculationEngine/entities/CeAttacks.java rename to src/main/java/calculationengine/entities/CeAttacks.java index 79130fa..18369ca 100644 --- a/src/main/java/calculationEngine/entities/CeAttacks.java +++ b/src/main/java/calculationengine/entities/CeAttacks.java @@ -1,4 +1,4 @@ -package calculationEngine.entities; +package calculationengine.entities; public enum CeAttacks { diff --git a/src/main/java/calculationEngine/entities/CeBeastTypes.java b/src/main/java/calculationengine/entities/CeBeastTypes.java similarity index 96% rename from src/main/java/calculationEngine/entities/CeBeastTypes.java rename to src/main/java/calculationengine/entities/CeBeastTypes.java index 2c138ab..5a5e4cc 100644 --- a/src/main/java/calculationEngine/entities/CeBeastTypes.java +++ b/src/main/java/calculationengine/entities/CeBeastTypes.java @@ -1,4 +1,4 @@ -package calculationEngine.entities; +package calculationengine.entities; public enum CeBeastTypes { diff --git a/src/main/java/calculationEngine/entities/CeBeasts.java b/src/main/java/calculationengine/entities/CeBeasts.java similarity index 97% rename from src/main/java/calculationEngine/entities/CeBeasts.java rename to src/main/java/calculationengine/entities/CeBeasts.java index 54045e7..02ba964 100644 --- a/src/main/java/calculationEngine/entities/CeBeasts.java +++ b/src/main/java/calculationengine/entities/CeBeasts.java @@ -1,6 +1,6 @@ -package calculationEngine.entities; +package calculationengine.entities; -import calculationEngine.environment.CeRegions; +import calculationengine.environment.CeRegions; public enum CeBeasts { diff --git a/src/main/java/calculationEngine/entities/CeEntity.java b/src/main/java/calculationengine/entities/CeEntity.java similarity index 98% rename from src/main/java/calculationEngine/entities/CeEntity.java rename to src/main/java/calculationengine/entities/CeEntity.java index 64337fe..f79ff1d 100644 --- a/src/main/java/calculationEngine/entities/CeEntity.java +++ b/src/main/java/calculationengine/entities/CeEntity.java @@ -1,6 +1,6 @@ -package calculationEngine.entities; +package calculationengine.entities; -import calculationEngine.environment.CeRegions; +import calculationengine.environment.CeRegions; import java.util.ArrayList; import java.util.Arrays; diff --git a/src/main/java/calculationEngine/entities/CeInventory.java b/src/main/java/calculationengine/entities/CeInventory.java similarity index 96% rename from src/main/java/calculationEngine/entities/CeInventory.java rename to src/main/java/calculationengine/entities/CeInventory.java index e043f3e..6398caf 100644 --- a/src/main/java/calculationEngine/entities/CeInventory.java +++ b/src/main/java/calculationengine/entities/CeInventory.java @@ -1,13 +1,13 @@ -package calculationEngine.entities; +package calculationengine.entities; -import calculationEngine.battle.WrongItemException; -import calculationEngine.environment.CeItem; -import calculationEngine.environment.CeItemTypes; +import calculationengine.battle.WrongItemException; +import calculationengine.environment.CeItem; +import calculationengine.environment.CeItemTypes; import java.util.ArrayList; -import static calculationEngine.environment.CeItemTypes.*; -import static calculationEngine.environment.CeItemTypes.armorShoulder; +import static calculationengine.environment.CeItemTypes.*; +import static calculationengine.environment.CeItemTypes.armorShoulder; public class CeInventory { diff --git a/src/main/java/calculationEngine/entities/CeNature.java b/src/main/java/calculationengine/entities/CeNature.java similarity index 89% rename from src/main/java/calculationEngine/entities/CeNature.java rename to src/main/java/calculationengine/entities/CeNature.java index a3192c4..db0bdcc 100644 --- a/src/main/java/calculationEngine/entities/CeNature.java +++ b/src/main/java/calculationengine/entities/CeNature.java @@ -1,4 +1,4 @@ -package calculationEngine.entities; +package calculationengine.entities; import java.util.Random; diff --git a/src/main/java/calculationEngine/entities/CePlayer.java b/src/main/java/calculationengine/entities/CePlayer.java similarity index 97% rename from src/main/java/calculationEngine/entities/CePlayer.java rename to src/main/java/calculationengine/entities/CePlayer.java index 2b857a9..e006fa3 100644 --- a/src/main/java/calculationEngine/entities/CePlayer.java +++ b/src/main/java/calculationengine/entities/CePlayer.java @@ -1,4 +1,4 @@ -package calculationEngine.entities; +package calculationengine.entities; import config.PlayerConfig; diff --git a/src/main/java/calculationEngine/entities/CeSlot.java b/src/main/java/calculationengine/entities/CeSlot.java similarity index 89% rename from src/main/java/calculationEngine/entities/CeSlot.java rename to src/main/java/calculationengine/entities/CeSlot.java index 54b8c14..18d0374 100644 --- a/src/main/java/calculationEngine/entities/CeSlot.java +++ b/src/main/java/calculationengine/entities/CeSlot.java @@ -1,6 +1,6 @@ -package calculationEngine.entities; +package calculationengine.entities; -import calculationEngine.environment.CeItem; +import calculationengine.environment.CeItem; public class CeSlot { diff --git a/src/main/java/calculationEngine/entities/CeStats.java b/src/main/java/calculationengine/entities/CeStats.java similarity index 98% rename from src/main/java/calculationEngine/entities/CeStats.java rename to src/main/java/calculationengine/entities/CeStats.java index 3edc9c2..bab1f5c 100644 --- a/src/main/java/calculationEngine/entities/CeStats.java +++ b/src/main/java/calculationengine/entities/CeStats.java @@ -1,6 +1,6 @@ -package calculationEngine.entities; +package calculationengine.entities; -import calculationEngine.environment.CeItemBonusStats; +import calculationengine.environment.CeItemBonusStats; import config.AiConstants; import config.EntityConstants; diff --git a/src/main/java/calculationEngine/entities/ItemNotInInventoryException.java b/src/main/java/calculationengine/entities/ItemNotInInventoryException.java similarity index 70% rename from src/main/java/calculationEngine/entities/ItemNotInInventoryException.java rename to src/main/java/calculationengine/entities/ItemNotInInventoryException.java index cb77e2a..a8cc786 100644 --- a/src/main/java/calculationEngine/entities/ItemNotInInventoryException.java +++ b/src/main/java/calculationengine/entities/ItemNotInInventoryException.java @@ -1,6 +1,6 @@ -package calculationEngine.entities; +package calculationengine.entities; -import calculationEngine.environment.CeItem; +import calculationengine.environment.CeItem; public class ItemNotInInventoryException extends Exception { public ItemNotInInventoryException(CeItem item){ diff --git a/src/main/java/calculationEngine/entities/NoPlaceInInventoryException.java b/src/main/java/calculationengine/entities/NoPlaceInInventoryException.java similarity index 63% rename from src/main/java/calculationEngine/entities/NoPlaceInInventoryException.java rename to src/main/java/calculationengine/entities/NoPlaceInInventoryException.java index c661d90..321c3e6 100644 --- a/src/main/java/calculationEngine/entities/NoPlaceInInventoryException.java +++ b/src/main/java/calculationengine/entities/NoPlaceInInventoryException.java @@ -1,6 +1,4 @@ -package calculationEngine.entities; - -import calculationEngine.environment.CeItem; +package calculationengine.entities; public class NoPlaceInInventoryException extends Exception{ public NoPlaceInInventoryException() { diff --git a/src/main/java/calculationEngine/environment/CeItem.java b/src/main/java/calculationengine/environment/CeItem.java similarity index 97% rename from src/main/java/calculationEngine/environment/CeItem.java rename to src/main/java/calculationengine/environment/CeItem.java index 5b6f29e..41c2bfe 100644 --- a/src/main/java/calculationEngine/environment/CeItem.java +++ b/src/main/java/calculationengine/environment/CeItem.java @@ -1,6 +1,6 @@ -package calculationEngine.environment; +package calculationengine.environment; -import calculationEngine.entities.CeStats; +import calculationengine.entities.CeStats; import org.json.JSONObject; public class CeItem { diff --git a/src/main/java/calculationEngine/environment/CeItemBonusStats.java b/src/main/java/calculationengine/environment/CeItemBonusStats.java similarity index 97% rename from src/main/java/calculationEngine/environment/CeItemBonusStats.java rename to src/main/java/calculationengine/environment/CeItemBonusStats.java index 02ba381..d682988 100644 --- a/src/main/java/calculationEngine/environment/CeItemBonusStats.java +++ b/src/main/java/calculationengine/environment/CeItemBonusStats.java @@ -1,4 +1,4 @@ -package calculationEngine.environment; +package calculationengine.environment; public class CeItemBonusStats { diff --git a/src/main/java/calculationEngine/environment/CeItemEffects.java b/src/main/java/calculationengine/environment/CeItemEffects.java similarity index 96% rename from src/main/java/calculationEngine/environment/CeItemEffects.java rename to src/main/java/calculationengine/environment/CeItemEffects.java index b3caf2f..ae1a423 100644 --- a/src/main/java/calculationEngine/environment/CeItemEffects.java +++ b/src/main/java/calculationengine/environment/CeItemEffects.java @@ -1,6 +1,6 @@ -package calculationEngine.environment; +package calculationengine.environment; -import calculationEngine.entities.CeStats; +import calculationengine.entities.CeStats; import config.BattleConstants; import org.json.JSONObject; diff --git a/src/main/java/calculationEngine/environment/CeItemTypes.java b/src/main/java/calculationengine/environment/CeItemTypes.java similarity index 79% rename from src/main/java/calculationEngine/environment/CeItemTypes.java rename to src/main/java/calculationengine/environment/CeItemTypes.java index e41017e..8d1c748 100644 --- a/src/main/java/calculationEngine/environment/CeItemTypes.java +++ b/src/main/java/calculationengine/environment/CeItemTypes.java @@ -1,4 +1,4 @@ -package calculationEngine.environment; +package calculationengine.environment; public enum CeItemTypes { diff --git a/src/main/java/calculationEngine/environment/CeLoot.java b/src/main/java/calculationengine/environment/CeLoot.java similarity index 95% rename from src/main/java/calculationEngine/environment/CeLoot.java rename to src/main/java/calculationengine/environment/CeLoot.java index 2707360..6e3eadf 100644 --- a/src/main/java/calculationEngine/environment/CeLoot.java +++ b/src/main/java/calculationengine/environment/CeLoot.java @@ -1,8 +1,8 @@ -package calculationEngine.environment; +package calculationengine.environment; import org.json.JSONArray; import org.json.JSONObject; -import static config.LootConfig.itemList; +import static config.LootConstants.itemList; public class CeLoot { diff --git a/src/main/java/calculationEngine/environment/CeRegions.java b/src/main/java/calculationengine/environment/CeRegions.java similarity index 71% rename from src/main/java/calculationEngine/environment/CeRegions.java rename to src/main/java/calculationengine/environment/CeRegions.java index ebb9743..2986bea 100644 --- a/src/main/java/calculationEngine/environment/CeRegions.java +++ b/src/main/java/calculationengine/environment/CeRegions.java @@ -1,4 +1,4 @@ -package calculationEngine.environment; +package calculationengine.environment; public enum CeRegions { IvoryForest, ArkhamCity, Dunwich, Marshlands, MiscatonicMountains; diff --git a/src/main/java/calculationEngine/environment/TestItems.java b/src/main/java/calculationengine/environment/TestItems.java similarity index 94% rename from src/main/java/calculationEngine/environment/TestItems.java rename to src/main/java/calculationengine/environment/TestItems.java index 39daa85..e35ed30 100644 --- a/src/main/java/calculationEngine/environment/TestItems.java +++ b/src/main/java/calculationengine/environment/TestItems.java @@ -1,7 +1,7 @@ -package calculationEngine.environment; +package calculationengine.environment; -import calculationEngine.battle.WrongItemException; -import calculationEngine.entities.*; +import calculationengine.battle.WrongItemException; +import calculationengine.entities.*; import java.util.ArrayList; import java.util.List; diff --git a/src/main/java/config/BattleConstants.java b/src/main/java/config/BattleConstants.java index bb37fa1..d77ef70 100644 --- a/src/main/java/config/BattleConstants.java +++ b/src/main/java/config/BattleConstants.java @@ -1,6 +1,6 @@ package config; -import calculationEngine.entities.CePlayer; +import calculationengine.entities.CePlayer; public class BattleConstants { diff --git a/src/main/java/config/GlobalConfig.java b/src/main/java/config/GlobalConstants.java similarity index 80% rename from src/main/java/config/GlobalConfig.java rename to src/main/java/config/GlobalConstants.java index 3ab5fbb..41fb7c8 100644 --- a/src/main/java/config/GlobalConfig.java +++ b/src/main/java/config/GlobalConstants.java @@ -1,6 +1,6 @@ package config; -public class GlobalConfig { +public class GlobalConstants { //ToDo: add if(DEBUG_CONSOLE_OUT) to all souts public static final boolean DEBUG_CONSOLE_OUT = false; } diff --git a/src/main/java/config/LootConfig.java b/src/main/java/config/LootConstants.java similarity index 91% rename from src/main/java/config/LootConfig.java rename to src/main/java/config/LootConstants.java index 350a351..9fb58e3 100644 --- a/src/main/java/config/LootConfig.java +++ b/src/main/java/config/LootConstants.java @@ -4,7 +4,7 @@ import static utilities.JsonReader.readJson; -public class LootConfig { +public class LootConstants { public static final int dropCommon = 60; public static final int dropRare = 35; diff --git a/src/main/java/config/PlayerConfig.java b/src/main/java/config/PlayerConfig.java index 50e887e..51ac25a 100644 --- a/src/main/java/config/PlayerConfig.java +++ b/src/main/java/config/PlayerConfig.java @@ -1,7 +1,7 @@ package config; -import calculationEngine.entities.CeAttack; -import calculationEngine.entities.CeAttacks; +import calculationengine.entities.CeAttack; +import calculationengine.entities.CeAttacks; public class PlayerConfig { diff --git a/src/test/java/calculationEngine.enviroment/CeInventoryTest.java b/src/test/java/calculationEngine.enviroment/CeInventoryTest.java index 60bfd50..4f1146f 100644 --- a/src/test/java/calculationEngine.enviroment/CeInventoryTest.java +++ b/src/test/java/calculationEngine.enviroment/CeInventoryTest.java @@ -1,12 +1,12 @@ -package calculationEngine.enviroment; +package calculationengine.enviroment; -import calculationEngine.entities.*; -import calculationEngine.environment.CeItem; +import calculationengine.entities.*; +import calculationengine.environment.CeItem; import org.json.JSONObject; import org.junit.Before; import org.junit.Test; -import static config.LootConfig.itemList; +import static config.LootConstants.itemList; import static org.junit.Assert.*; public class CeInventoryTest { From 2d05f16d011506ff920a0309cbd1e31c46a98290 Mon Sep 17 00:00:00 2001 From: lkno0705 Date: Mon, 31 May 2021 13:03:32 +0200 Subject: [PATCH 10/19] codacy bs --- .../calculationEngine/CeExecuterService.java | 2 +- .../java/calculationEngine/battle/CeBattle.java | 10 +++++----- .../calculationEngine/battle/CeCatching.java | 16 ++++++++-------- .../java/calculationEngine/battle/CeDamage.java | 10 +++++----- .../battle/WrongItemException.java | 4 ++-- .../calculationEngine/battle/testBattle.java | 10 +++++----- .../java/calculationEngine/entities/CeAi.java | 6 +++--- .../calculationEngine/entities/CeAttack.java | 2 +- .../calculationEngine/entities/CeAttacks.java | 2 +- .../calculationEngine/entities/CeBeastTypes.java | 2 +- .../calculationEngine/entities/CeBeasts.java | 4 ++-- .../calculationEngine/entities/CeEntity.java | 4 ++-- .../calculationEngine/entities/CeInventory.java | 12 ++++++------ .../calculationEngine/entities/CeNature.java | 2 +- .../calculationEngine/entities/CePlayer.java | 2 +- .../java/calculationEngine/entities/CeSlot.java | 4 ++-- .../java/calculationEngine/entities/CeStats.java | 4 ++-- .../entities/ItemNotInInventoryException.java | 4 ++-- .../entities/NoPlaceInInventoryException.java | 4 +--- .../calculationEngine/environment/CeItem.java | 4 ++-- .../environment/CeItemBonusStats.java | 2 +- .../environment/CeItemEffects.java | 4 ++-- .../environment/CeItemTypes.java | 2 +- .../calculationEngine/environment/CeLoot.java | 4 ++-- .../calculationEngine/environment/CeRegions.java | 2 +- .../calculationEngine/environment/TestItems.java | 6 +++--- src/main/java/config/BattleConstants.java | 2 +- src/main/java/config/GlobalConfig.java | 6 ------ src/main/java/config/LootConfig.java | 13 ------------- src/main/java/config/PlayerConfig.java | 4 ++-- .../enviroment}/CeInventoryTest.java | 8 ++++---- 31 files changed, 70 insertions(+), 91 deletions(-) delete mode 100644 src/main/java/config/GlobalConfig.java delete mode 100644 src/main/java/config/LootConfig.java rename src/test/java/{calculationEngine.enviroment => calculationengine/enviroment}/CeInventoryTest.java (93%) diff --git a/src/main/java/calculationEngine/CeExecuterService.java b/src/main/java/calculationEngine/CeExecuterService.java index 10d6ff4..33cf799 100644 --- a/src/main/java/calculationEngine/CeExecuterService.java +++ b/src/main/java/calculationEngine/CeExecuterService.java @@ -1,4 +1,4 @@ -package calculationEngine; +package calculationengine; import config.BattleConstants; diff --git a/src/main/java/calculationEngine/battle/CeBattle.java b/src/main/java/calculationEngine/battle/CeBattle.java index 2579a86..68da43f 100644 --- a/src/main/java/calculationEngine/battle/CeBattle.java +++ b/src/main/java/calculationEngine/battle/CeBattle.java @@ -1,9 +1,9 @@ -package calculationEngine.battle; +package calculationengine.battle; -import calculationEngine.CeExecuterService; -import calculationEngine.entities.*; -import calculationEngine.environment.CeItem; -import calculationEngine.environment.CeItemTypes; +import calculationengine.CeExecuterService; +import calculationengine.entities.*; +import calculationengine.environment.CeItem; +import calculationengine.environment.CeItemTypes; import config.BattleConstants; import java.util.Random; diff --git a/src/main/java/calculationEngine/battle/CeCatching.java b/src/main/java/calculationEngine/battle/CeCatching.java index 0834b12..9b0edec 100644 --- a/src/main/java/calculationEngine/battle/CeCatching.java +++ b/src/main/java/calculationEngine/battle/CeCatching.java @@ -1,18 +1,18 @@ -package calculationEngine.battle; +package calculationengine.battle; -import calculationEngine.entities.CeAttack; -import calculationEngine.entities.CeBeastTypes; -import calculationEngine.entities.CeEntity; -import calculationEngine.entities.CePlayer; -import calculationEngine.environment.CeItem; -import config.GlobalConfig; +import calculationengine.entities.CeAttack; +import calculationengine.entities.CeBeastTypes; +import calculationengine.entities.CeEntity; +import calculationengine.entities.CePlayer; +import calculationengine.environment.CeItem; +import config.GlobalConstants; import java.util.Random; public class CeCatching { private static Random random = new Random(); private static String debugInfo; - private final static boolean bDebug = GlobalConfig.DEBUG_CONSOLE_OUT; + private final static boolean bDebug = GlobalConstants.DEBUG_CONSOLE_OUT; public static boolean isCaught(CePlayer player, CeEntity beast, CeItem cage) { diff --git a/src/main/java/calculationEngine/battle/CeDamage.java b/src/main/java/calculationEngine/battle/CeDamage.java index da6578e..4878b16 100644 --- a/src/main/java/calculationEngine/battle/CeDamage.java +++ b/src/main/java/calculationEngine/battle/CeDamage.java @@ -1,15 +1,15 @@ -package calculationEngine.battle; +package calculationengine.battle; -import calculationEngine.entities.CeAttack; -import calculationEngine.entities.CeEntity; -import config.GlobalConfig; +import calculationengine.entities.CeAttack; +import calculationengine.entities.CeEntity; +import config.GlobalConstants; import java.util.Random; public class CeDamage { private static Random random = new Random(); private static String debugInfo; - private final static boolean bDebug = GlobalConfig.DEBUG_CONSOLE_OUT; + private final static boolean bDebug = GlobalConstants.DEBUG_CONSOLE_OUT; public static int calculateDamage(CeEntity attacker, CeEntity defender, CeAttack ceAttack) { //roll to d50 to get a quasi normal distribution diff --git a/src/main/java/calculationEngine/battle/WrongItemException.java b/src/main/java/calculationEngine/battle/WrongItemException.java index cbec3d0..96c8e5f 100644 --- a/src/main/java/calculationEngine/battle/WrongItemException.java +++ b/src/main/java/calculationEngine/battle/WrongItemException.java @@ -1,6 +1,6 @@ -package calculationEngine.battle; +package calculationengine.battle; -import calculationEngine.environment.CeItem; +import calculationengine.environment.CeItem; public class WrongItemException extends Exception{ public WrongItemException(CeItem item, String expected) { diff --git a/src/main/java/calculationEngine/battle/testBattle.java b/src/main/java/calculationEngine/battle/testBattle.java index a2daac8..0d6340c 100644 --- a/src/main/java/calculationEngine/battle/testBattle.java +++ b/src/main/java/calculationEngine/battle/testBattle.java @@ -1,9 +1,9 @@ -package calculationEngine.battle; +package calculationengine.battle; -import calculationEngine.CeExecuterService; -import calculationEngine.entities.*; -import calculationEngine.environment.CeLoot; -import calculationEngine.environment.CeRegions; +import calculationengine.CeExecuterService; +import calculationengine.entities.*; +import calculationengine.environment.CeLoot; +import calculationengine.environment.CeRegions; import java.util.ArrayList; import java.util.List; diff --git a/src/main/java/calculationEngine/entities/CeAi.java b/src/main/java/calculationEngine/entities/CeAi.java index 8a6e637..15591bd 100644 --- a/src/main/java/calculationEngine/entities/CeAi.java +++ b/src/main/java/calculationEngine/entities/CeAi.java @@ -1,7 +1,7 @@ -package calculationEngine.entities; +package calculationengine.entities; -import calculationEngine.battle.CeBattle; -import calculationEngine.environment.CeRegions; +import calculationengine.battle.CeBattle; +import calculationengine.environment.CeRegions; import config.BattleConstants; import java.util.ArrayList; diff --git a/src/main/java/calculationEngine/entities/CeAttack.java b/src/main/java/calculationEngine/entities/CeAttack.java index 9eaea81..f3b958f 100644 --- a/src/main/java/calculationEngine/entities/CeAttack.java +++ b/src/main/java/calculationEngine/entities/CeAttack.java @@ -1,4 +1,4 @@ -package calculationEngine.entities; +package calculationengine.entities; import config.EntityConstants; diff --git a/src/main/java/calculationEngine/entities/CeAttacks.java b/src/main/java/calculationEngine/entities/CeAttacks.java index 79130fa..18369ca 100644 --- a/src/main/java/calculationEngine/entities/CeAttacks.java +++ b/src/main/java/calculationEngine/entities/CeAttacks.java @@ -1,4 +1,4 @@ -package calculationEngine.entities; +package calculationengine.entities; public enum CeAttacks { diff --git a/src/main/java/calculationEngine/entities/CeBeastTypes.java b/src/main/java/calculationEngine/entities/CeBeastTypes.java index 2c138ab..5a5e4cc 100644 --- a/src/main/java/calculationEngine/entities/CeBeastTypes.java +++ b/src/main/java/calculationEngine/entities/CeBeastTypes.java @@ -1,4 +1,4 @@ -package calculationEngine.entities; +package calculationengine.entities; public enum CeBeastTypes { diff --git a/src/main/java/calculationEngine/entities/CeBeasts.java b/src/main/java/calculationEngine/entities/CeBeasts.java index 54045e7..02ba964 100644 --- a/src/main/java/calculationEngine/entities/CeBeasts.java +++ b/src/main/java/calculationEngine/entities/CeBeasts.java @@ -1,6 +1,6 @@ -package calculationEngine.entities; +package calculationengine.entities; -import calculationEngine.environment.CeRegions; +import calculationengine.environment.CeRegions; public enum CeBeasts { diff --git a/src/main/java/calculationEngine/entities/CeEntity.java b/src/main/java/calculationEngine/entities/CeEntity.java index 64337fe..f79ff1d 100644 --- a/src/main/java/calculationEngine/entities/CeEntity.java +++ b/src/main/java/calculationEngine/entities/CeEntity.java @@ -1,6 +1,6 @@ -package calculationEngine.entities; +package calculationengine.entities; -import calculationEngine.environment.CeRegions; +import calculationengine.environment.CeRegions; import java.util.ArrayList; import java.util.Arrays; diff --git a/src/main/java/calculationEngine/entities/CeInventory.java b/src/main/java/calculationEngine/entities/CeInventory.java index e043f3e..6398caf 100644 --- a/src/main/java/calculationEngine/entities/CeInventory.java +++ b/src/main/java/calculationEngine/entities/CeInventory.java @@ -1,13 +1,13 @@ -package calculationEngine.entities; +package calculationengine.entities; -import calculationEngine.battle.WrongItemException; -import calculationEngine.environment.CeItem; -import calculationEngine.environment.CeItemTypes; +import calculationengine.battle.WrongItemException; +import calculationengine.environment.CeItem; +import calculationengine.environment.CeItemTypes; import java.util.ArrayList; -import static calculationEngine.environment.CeItemTypes.*; -import static calculationEngine.environment.CeItemTypes.armorShoulder; +import static calculationengine.environment.CeItemTypes.*; +import static calculationengine.environment.CeItemTypes.armorShoulder; public class CeInventory { diff --git a/src/main/java/calculationEngine/entities/CeNature.java b/src/main/java/calculationEngine/entities/CeNature.java index a3192c4..db0bdcc 100644 --- a/src/main/java/calculationEngine/entities/CeNature.java +++ b/src/main/java/calculationEngine/entities/CeNature.java @@ -1,4 +1,4 @@ -package calculationEngine.entities; +package calculationengine.entities; import java.util.Random; diff --git a/src/main/java/calculationEngine/entities/CePlayer.java b/src/main/java/calculationEngine/entities/CePlayer.java index 2b857a9..e006fa3 100644 --- a/src/main/java/calculationEngine/entities/CePlayer.java +++ b/src/main/java/calculationEngine/entities/CePlayer.java @@ -1,4 +1,4 @@ -package calculationEngine.entities; +package calculationengine.entities; import config.PlayerConfig; diff --git a/src/main/java/calculationEngine/entities/CeSlot.java b/src/main/java/calculationEngine/entities/CeSlot.java index 54b8c14..18d0374 100644 --- a/src/main/java/calculationEngine/entities/CeSlot.java +++ b/src/main/java/calculationEngine/entities/CeSlot.java @@ -1,6 +1,6 @@ -package calculationEngine.entities; +package calculationengine.entities; -import calculationEngine.environment.CeItem; +import calculationengine.environment.CeItem; public class CeSlot { diff --git a/src/main/java/calculationEngine/entities/CeStats.java b/src/main/java/calculationEngine/entities/CeStats.java index 3edc9c2..bab1f5c 100644 --- a/src/main/java/calculationEngine/entities/CeStats.java +++ b/src/main/java/calculationEngine/entities/CeStats.java @@ -1,6 +1,6 @@ -package calculationEngine.entities; +package calculationengine.entities; -import calculationEngine.environment.CeItemBonusStats; +import calculationengine.environment.CeItemBonusStats; import config.AiConstants; import config.EntityConstants; diff --git a/src/main/java/calculationEngine/entities/ItemNotInInventoryException.java b/src/main/java/calculationEngine/entities/ItemNotInInventoryException.java index cb77e2a..a8cc786 100644 --- a/src/main/java/calculationEngine/entities/ItemNotInInventoryException.java +++ b/src/main/java/calculationEngine/entities/ItemNotInInventoryException.java @@ -1,6 +1,6 @@ -package calculationEngine.entities; +package calculationengine.entities; -import calculationEngine.environment.CeItem; +import calculationengine.environment.CeItem; public class ItemNotInInventoryException extends Exception { public ItemNotInInventoryException(CeItem item){ diff --git a/src/main/java/calculationEngine/entities/NoPlaceInInventoryException.java b/src/main/java/calculationEngine/entities/NoPlaceInInventoryException.java index c661d90..321c3e6 100644 --- a/src/main/java/calculationEngine/entities/NoPlaceInInventoryException.java +++ b/src/main/java/calculationEngine/entities/NoPlaceInInventoryException.java @@ -1,6 +1,4 @@ -package calculationEngine.entities; - -import calculationEngine.environment.CeItem; +package calculationengine.entities; public class NoPlaceInInventoryException extends Exception{ public NoPlaceInInventoryException() { diff --git a/src/main/java/calculationEngine/environment/CeItem.java b/src/main/java/calculationEngine/environment/CeItem.java index 5b6f29e..41c2bfe 100644 --- a/src/main/java/calculationEngine/environment/CeItem.java +++ b/src/main/java/calculationEngine/environment/CeItem.java @@ -1,6 +1,6 @@ -package calculationEngine.environment; +package calculationengine.environment; -import calculationEngine.entities.CeStats; +import calculationengine.entities.CeStats; import org.json.JSONObject; public class CeItem { diff --git a/src/main/java/calculationEngine/environment/CeItemBonusStats.java b/src/main/java/calculationEngine/environment/CeItemBonusStats.java index 02ba381..d682988 100644 --- a/src/main/java/calculationEngine/environment/CeItemBonusStats.java +++ b/src/main/java/calculationEngine/environment/CeItemBonusStats.java @@ -1,4 +1,4 @@ -package calculationEngine.environment; +package calculationengine.environment; public class CeItemBonusStats { diff --git a/src/main/java/calculationEngine/environment/CeItemEffects.java b/src/main/java/calculationEngine/environment/CeItemEffects.java index b3caf2f..ae1a423 100644 --- a/src/main/java/calculationEngine/environment/CeItemEffects.java +++ b/src/main/java/calculationEngine/environment/CeItemEffects.java @@ -1,6 +1,6 @@ -package calculationEngine.environment; +package calculationengine.environment; -import calculationEngine.entities.CeStats; +import calculationengine.entities.CeStats; import config.BattleConstants; import org.json.JSONObject; diff --git a/src/main/java/calculationEngine/environment/CeItemTypes.java b/src/main/java/calculationEngine/environment/CeItemTypes.java index e41017e..8d1c748 100644 --- a/src/main/java/calculationEngine/environment/CeItemTypes.java +++ b/src/main/java/calculationEngine/environment/CeItemTypes.java @@ -1,4 +1,4 @@ -package calculationEngine.environment; +package calculationengine.environment; public enum CeItemTypes { diff --git a/src/main/java/calculationEngine/environment/CeLoot.java b/src/main/java/calculationEngine/environment/CeLoot.java index 2707360..6e3eadf 100644 --- a/src/main/java/calculationEngine/environment/CeLoot.java +++ b/src/main/java/calculationEngine/environment/CeLoot.java @@ -1,8 +1,8 @@ -package calculationEngine.environment; +package calculationengine.environment; import org.json.JSONArray; import org.json.JSONObject; -import static config.LootConfig.itemList; +import static config.LootConstants.itemList; public class CeLoot { diff --git a/src/main/java/calculationEngine/environment/CeRegions.java b/src/main/java/calculationEngine/environment/CeRegions.java index ebb9743..2986bea 100644 --- a/src/main/java/calculationEngine/environment/CeRegions.java +++ b/src/main/java/calculationEngine/environment/CeRegions.java @@ -1,4 +1,4 @@ -package calculationEngine.environment; +package calculationengine.environment; public enum CeRegions { IvoryForest, ArkhamCity, Dunwich, Marshlands, MiscatonicMountains; diff --git a/src/main/java/calculationEngine/environment/TestItems.java b/src/main/java/calculationEngine/environment/TestItems.java index 39daa85..e35ed30 100644 --- a/src/main/java/calculationEngine/environment/TestItems.java +++ b/src/main/java/calculationEngine/environment/TestItems.java @@ -1,7 +1,7 @@ -package calculationEngine.environment; +package calculationengine.environment; -import calculationEngine.battle.WrongItemException; -import calculationEngine.entities.*; +import calculationengine.battle.WrongItemException; +import calculationengine.entities.*; import java.util.ArrayList; import java.util.List; diff --git a/src/main/java/config/BattleConstants.java b/src/main/java/config/BattleConstants.java index bb37fa1..d77ef70 100644 --- a/src/main/java/config/BattleConstants.java +++ b/src/main/java/config/BattleConstants.java @@ -1,6 +1,6 @@ package config; -import calculationEngine.entities.CePlayer; +import calculationengine.entities.CePlayer; public class BattleConstants { diff --git a/src/main/java/config/GlobalConfig.java b/src/main/java/config/GlobalConfig.java deleted file mode 100644 index 3ab5fbb..0000000 --- a/src/main/java/config/GlobalConfig.java +++ /dev/null @@ -1,6 +0,0 @@ -package config; - -public class GlobalConfig { - //ToDo: add if(DEBUG_CONSOLE_OUT) to all souts - public static final boolean DEBUG_CONSOLE_OUT = false; -} diff --git a/src/main/java/config/LootConfig.java b/src/main/java/config/LootConfig.java deleted file mode 100644 index 350a351..0000000 --- a/src/main/java/config/LootConfig.java +++ /dev/null @@ -1,13 +0,0 @@ -package config; - -import org.json.JSONObject; - -import static utilities.JsonReader.readJson; - -public class LootConfig { - - public static final int dropCommon = 60; - public static final int dropRare = 35; - public static final int dropLegendary = 5; - public static final JSONObject itemList = readJson("/items.JSON"); -} diff --git a/src/main/java/config/PlayerConfig.java b/src/main/java/config/PlayerConfig.java index 50e887e..51ac25a 100644 --- a/src/main/java/config/PlayerConfig.java +++ b/src/main/java/config/PlayerConfig.java @@ -1,7 +1,7 @@ package config; -import calculationEngine.entities.CeAttack; -import calculationEngine.entities.CeAttacks; +import calculationengine.entities.CeAttack; +import calculationengine.entities.CeAttacks; public class PlayerConfig { diff --git a/src/test/java/calculationEngine.enviroment/CeInventoryTest.java b/src/test/java/calculationengine/enviroment/CeInventoryTest.java similarity index 93% rename from src/test/java/calculationEngine.enviroment/CeInventoryTest.java rename to src/test/java/calculationengine/enviroment/CeInventoryTest.java index 60bfd50..4f1146f 100644 --- a/src/test/java/calculationEngine.enviroment/CeInventoryTest.java +++ b/src/test/java/calculationengine/enviroment/CeInventoryTest.java @@ -1,12 +1,12 @@ -package calculationEngine.enviroment; +package calculationengine.enviroment; -import calculationEngine.entities.*; -import calculationEngine.environment.CeItem; +import calculationengine.entities.*; +import calculationengine.environment.CeItem; import org.json.JSONObject; import org.junit.Before; import org.junit.Test; -import static config.LootConfig.itemList; +import static config.LootConstants.itemList; import static org.junit.Assert.*; public class CeInventoryTest { From ca210931b37461a79d526900aeea3f1dde44c2db Mon Sep 17 00:00:00 2001 From: lkno0705 Date: Mon, 31 May 2021 13:03:49 +0200 Subject: [PATCH 11/19] codacy bs --- src/main/java/config/GlobalConstants.java | 6 ++++++ src/main/java/config/LootConstants.java | 13 +++++++++++++ 2 files changed, 19 insertions(+) create mode 100644 src/main/java/config/GlobalConstants.java create mode 100644 src/main/java/config/LootConstants.java diff --git a/src/main/java/config/GlobalConstants.java b/src/main/java/config/GlobalConstants.java new file mode 100644 index 0000000..41fb7c8 --- /dev/null +++ b/src/main/java/config/GlobalConstants.java @@ -0,0 +1,6 @@ +package config; + +public class GlobalConstants { + //ToDo: add if(DEBUG_CONSOLE_OUT) to all souts + public static final boolean DEBUG_CONSOLE_OUT = false; +} diff --git a/src/main/java/config/LootConstants.java b/src/main/java/config/LootConstants.java new file mode 100644 index 0000000..9fb58e3 --- /dev/null +++ b/src/main/java/config/LootConstants.java @@ -0,0 +1,13 @@ +package config; + +import org.json.JSONObject; + +import static utilities.JsonReader.readJson; + +public class LootConstants { + + public static final int dropCommon = 60; + public static final int dropRare = 35; + public static final int dropLegendary = 5; + public static final JSONObject itemList = readJson("/items.JSON"); +} From 3f836f969f849f4e15379913e23a93c58e1b4cf0 Mon Sep 17 00:00:00 2001 From: lkno0705 Date: Mon, 31 May 2021 13:10:00 +0200 Subject: [PATCH 12/19] codacy bs --- .../java/calculationEngine/battle/testBattle.java | 14 +++++++++++--- .../config/{TestConfig.java => TestConstants.java} | 2 +- 2 files changed, 12 insertions(+), 4 deletions(-) rename src/main/java/config/{TestConfig.java => TestConstants.java} (67%) diff --git a/src/main/java/calculationEngine/battle/testBattle.java b/src/main/java/calculationEngine/battle/testBattle.java index 0d6340c..0f58ee1 100644 --- a/src/main/java/calculationEngine/battle/testBattle.java +++ b/src/main/java/calculationEngine/battle/testBattle.java @@ -1,17 +1,25 @@ package calculationengine.battle; import calculationengine.CeExecuterService; -import calculationengine.entities.*; +import calculationengine.entities.CeAi; +import calculationengine.entities.CeAttack; +import calculationengine.entities.CeAttacks; +import calculationengine.entities.CeBeastTypes; +import calculationengine.entities.CeEntity; +import calculationengine.entities.CeNature; +import calculationengine.entities.CePlayer; +import calculationengine.entities.CeStats; +import calculationengine.entities.ItemNotInInventoryException; import calculationengine.environment.CeLoot; import calculationengine.environment.CeRegions; import java.util.ArrayList; import java.util.List; -public class testBattle { +public class TestBattle { public static void main(String[] args) throws Exception { -// simulateAiBattle(); + simulateAiBattle(); simulateCatch(); CeExecuterService.shutdownExecutor(); } diff --git a/src/main/java/config/TestConfig.java b/src/main/java/config/TestConstants.java similarity index 67% rename from src/main/java/config/TestConfig.java rename to src/main/java/config/TestConstants.java index d371ceb..7fc781a 100644 --- a/src/main/java/config/TestConfig.java +++ b/src/main/java/config/TestConstants.java @@ -1,5 +1,5 @@ package config; -public class TestConfig { +public class TestConstants { public static int ROBOT_SLEEP = 1000; } From db012256f74e94cdaf6ac186cfdbbfef31b91ae7 Mon Sep 17 00:00:00 2001 From: lkno0705 Date: Mon, 31 May 2021 13:11:55 +0200 Subject: [PATCH 13/19] codacy bs --- src/main/java/calculationEngine/entities/CePlayer.java | 4 ++-- .../java/config/{PlayerConfig.java => PlayerConstants.java} | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) rename src/main/java/config/{PlayerConfig.java => PlayerConstants.java} (92%) diff --git a/src/main/java/calculationEngine/entities/CePlayer.java b/src/main/java/calculationEngine/entities/CePlayer.java index e006fa3..12cd21c 100644 --- a/src/main/java/calculationEngine/entities/CePlayer.java +++ b/src/main/java/calculationEngine/entities/CePlayer.java @@ -1,6 +1,6 @@ package calculationengine.entities; -import config.PlayerConfig; +import config.PlayerConstants; import java.util.List; @@ -10,7 +10,7 @@ public class CePlayer extends CeEntity { private boolean isAI; private int playerNumber; private int activeMonsterIndex = 0; - private final CeAttack[] playerStandardCeAttacks = PlayerConfig.PLAYER_STANDARD_CE_ATTACKS; + private final CeAttack[] playerStandardCeAttacks = PlayerConstants.PLAYER_STANDARD_CE_ATTACKS; private CeInventory inventory; public CePlayer(CeStats ceStats, List ceAttacks, List team, boolean isAI) { diff --git a/src/main/java/config/PlayerConfig.java b/src/main/java/config/PlayerConstants.java similarity index 92% rename from src/main/java/config/PlayerConfig.java rename to src/main/java/config/PlayerConstants.java index 51ac25a..4882164 100644 --- a/src/main/java/config/PlayerConfig.java +++ b/src/main/java/config/PlayerConstants.java @@ -3,7 +3,7 @@ import calculationengine.entities.CeAttack; import calculationengine.entities.CeAttacks; -public class PlayerConfig { +public class PlayerConstants { public static final String[] PLAYER_ACTIONS = new String[] {"Attack", "Catch", "Tame", "Pick Beast", "Item"}; public static final CeAttack[] PLAYER_STANDARD_CE_ATTACKS = new CeAttack[]{new CeAttack(CeAttacks.Catch), new CeAttack(CeAttacks.Flee), new CeAttack(CeAttacks.Punch)}; From d6f9ef0266368987f9e40116b1fe6298c44ca8a9 Mon Sep 17 00:00:00 2001 From: lkno0705 Date: Mon, 31 May 2021 15:20:39 +0200 Subject: [PATCH 14/19] codacy BS --- .../{testBattle.java => TestBattle.java} | 27 +++++++++---------- 1 file changed, 13 insertions(+), 14 deletions(-) rename src/main/java/calculationengine/battle/{testBattle.java => TestBattle.java} (86%) diff --git a/src/main/java/calculationengine/battle/testBattle.java b/src/main/java/calculationengine/battle/TestBattle.java similarity index 86% rename from src/main/java/calculationengine/battle/testBattle.java rename to src/main/java/calculationengine/battle/TestBattle.java index 0f58ee1..5afafb6 100644 --- a/src/main/java/calculationengine/battle/testBattle.java +++ b/src/main/java/calculationengine/battle/TestBattle.java @@ -26,14 +26,7 @@ public static void main(String[] args) throws Exception { private static void simulateCatch() throws Exception { - List team = new ArrayList<>(); - List attacks = new ArrayList<>(); - attacks.add(new CeAttack(CeAttacks.Punch)); - CePlayer cePlayer1 = new CePlayer(new CeStats(CeBeastTypes.PlayerStandard, CeNature.ANGRY, 1, 100, 100, 50, 200, 200, 200, 1), attacks, team, false); - - team.add(new CeEntity(CeRegions.ArkhamCity, cePlayer1)); - cePlayer1.setTeam(team); - cePlayer1.setActiveMonsterIndex(0); + CePlayer cePlayer1 = init(); for (int i = 0; i < 1; i++) { cePlayer1.getInventory().addItemToInventory(CeLoot.lootItem("cage")); } @@ -57,22 +50,28 @@ private static void simulateCatch() throws Exception { battle.endBatte(); } } } else { - System.out.println("[Test Battle]: End of fight"); - } - Thread.sleep(10); + System.out.println("[Test Battle]: End of fight"); } - System.out.println("[Test Battle]: End of fight"); + Thread.sleep(10); } + System.out.println("[Test Battle]: End of fight"); + } - private static void simulateAiBattle() throws InterruptedException { - + private static CePlayer init() { List team = new ArrayList<>(); List attacks = new ArrayList<>(); attacks.add(new CeAttack(CeAttacks.Punch)); CePlayer cePlayer1 = new CePlayer(new CeStats(CeBeastTypes.PlayerStandard, CeNature.ANGRY, 1, 100, 100, 50, 200, 200, 200, 1), attacks, team, false); + team.add(new CeEntity(CeRegions.ArkhamCity, cePlayer1)); cePlayer1.setTeam(team); cePlayer1.setActiveMonsterIndex(0); + return cePlayer1; + } + + private static void simulateAiBattle() throws InterruptedException { + + CePlayer cePlayer1 = init(); CeAi cePlayer2 = new CeAi(cePlayer1, CeRegions.ArkhamCity); CeBattle battle = new CeBattle(cePlayer1, cePlayer2); System.out.println("[Test Battle]: Battle started"); From 5fca4a3a41b676e72639e797ecb3cbe180f389fc Mon Sep 17 00:00:00 2001 From: lkno0705 Date: Mon, 31 May 2021 15:23:30 +0200 Subject: [PATCH 15/19] codacy BS --- .../calculationengine/enviroment/CeInventoryTest.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/test/java/calculationengine/enviroment/CeInventoryTest.java b/src/test/java/calculationengine/enviroment/CeInventoryTest.java index 4f1146f..c43777f 100644 --- a/src/test/java/calculationengine/enviroment/CeInventoryTest.java +++ b/src/test/java/calculationengine/enviroment/CeInventoryTest.java @@ -1,16 +1,20 @@ package calculationengine.enviroment; -import calculationengine.entities.*; +import calculationengine.entities.CeBeasts; +import calculationengine.entities.CeInventory; +import calculationengine.entities.CeSlot; +import calculationengine.entities.CeStats; +import calculationengine.entities.NoPlaceInInventoryException; import calculationengine.environment.CeItem; import org.json.JSONObject; import org.junit.Before; import org.junit.Test; import static config.LootConstants.itemList; -import static org.junit.Assert.*; +import static org.junit.Assert.assertEquals; public class CeInventoryTest { - CeInventory ceInventory; + private CeInventory ceInventory; @Before public void setUp() { From b767925d89d4ce3c13706560066dde75d5c28126 Mon Sep 17 00:00:00 2001 From: lkno0705 Date: Mon, 31 May 2021 15:34:19 +0200 Subject: [PATCH 16/19] codacy BS --- .../calculationengine/environment/TestItems.java | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/main/java/calculationengine/environment/TestItems.java b/src/main/java/calculationengine/environment/TestItems.java index e35ed30..454bf3d 100644 --- a/src/main/java/calculationengine/environment/TestItems.java +++ b/src/main/java/calculationengine/environment/TestItems.java @@ -1,7 +1,17 @@ package calculationengine.environment; import calculationengine.battle.WrongItemException; -import calculationengine.entities.*; +import calculationengine.entities.CeAttack; +import calculationengine.entities.CeAttacks; +import calculationengine.entities.CeBeastTypes; +import calculationengine.entities.CeBeasts; +import calculationengine.entities.CeEntity; +import calculationengine.entities.CeInventory; +import calculationengine.entities.CeNature; +import calculationengine.entities.CePlayer; +import calculationengine.entities.CeStats; +import calculationengine.entities.ItemNotInInventoryException; +import calculationengine.entities.NoPlaceInInventoryException; import java.util.ArrayList; import java.util.List; From d5a4a592b62669aab874db9a4c0670b37e1ca544 Mon Sep 17 00:00:00 2001 From: lkno0705 Date: Mon, 31 May 2021 15:37:03 +0200 Subject: [PATCH 17/19] codacy BS --- .../entities/CeInventory.java | 32 +++++++++++-------- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/src/main/java/calculationengine/entities/CeInventory.java b/src/main/java/calculationengine/entities/CeInventory.java index 6398caf..53f2b56 100644 --- a/src/main/java/calculationengine/entities/CeInventory.java +++ b/src/main/java/calculationengine/entities/CeInventory.java @@ -6,8 +6,14 @@ import java.util.ArrayList; -import static calculationengine.environment.CeItemTypes.*; +import static calculationengine.environment.CeItemTypes.armorChest; +import static calculationengine.environment.CeItemTypes.armorHead; +import static calculationengine.environment.CeItemTypes.armorLegs; +import static calculationengine.environment.CeItemTypes.armorShoes; import static calculationengine.environment.CeItemTypes.armorShoulder; +import static calculationengine.environment.CeItemTypes.cage; +import static calculationengine.environment.CeItemTypes.consumable; +import static calculationengine.environment.CeItemTypes.weapon; public class CeInventory { @@ -20,8 +26,8 @@ public class CeInventory { private CeStats playerStats; - int maxItemSlots = 10; - CeSlot[] slots = new CeSlot[maxItemSlots]; + private int maxItemSlots = 10; + private CeSlot[] slots = new CeSlot[maxItemSlots]; public void loadSaveInventory(CeItem armorShoulder, CeItem armorShoes, CeItem armorLegs, CeItem armorChest, CeItem armorHead, CeItem weapon, CeSlot[] slots) { this.slots = slots; @@ -42,7 +48,7 @@ public CeInventory(CeStats ceStats) { public void addItemToInventory(CeItem item) throws NoPlaceInInventoryException { if (item == null) { - throw new NullPointerException(); + throw new IllegalArgumentException(); } boolean foundSlot = false; boolean addedItem = false; @@ -72,17 +78,15 @@ public void useItem(CeItem item) throws ItemNotInInventoryException { for (CeSlot slot : slots) { CeItem slotItem = slot.getItem(); - if (slotItem != null) { - if (slotItem.compareTo(item)) { - matchingItem = true; - //TODO: Add switch case for item type and call correct Methods - slotItem.use(this.playerStats); - int remainingAmount = slot.decreaseAmount(); - if (remainingAmount <= 0) { - slot.reset(); - } - break; + if (slotItem != null && slotItem.compareTo(item)) { + matchingItem = true; + //TODO: Add switch case for item type and call correct Methods + slotItem.use(this.playerStats); + int remainingAmount = slot.decreaseAmount(); + if (remainingAmount <= 0) { + slot.reset(); } + break; } } if (!matchingItem) { From 59e5f3e06ae70b4d4623a0ff6e4f88f700c91ef6 Mon Sep 17 00:00:00 2001 From: lkno0705 Date: Mon, 31 May 2021 15:40:47 +0200 Subject: [PATCH 18/19] codacy BS --- ...rService.java => CeExecuterServiceUtils.java} | 2 +- .../java/calculationengine/battle/CeBattle.java | 10 +++++++--- .../calculationengine/battle/TestBattle.java | 10 +++++----- .../calculationengine/environment/CeItem.java | 5 +---- .../{CeLoot.java => CeLootUtils.java} | 2 +- .../calculationengine/environment/TestItems.java | 16 ++++++++-------- src/main/java/config/LootConstants.java | 2 +- .../{JsonReader.java => JsonReaderUtils.java} | 9 ++++++--- 8 files changed, 30 insertions(+), 26 deletions(-) rename src/main/java/calculationengine/{CeExecuterService.java => CeExecuterServiceUtils.java} (96%) rename src/main/java/calculationengine/environment/{CeLoot.java => CeLootUtils.java} (98%) rename src/main/java/utilities/{JsonReader.java => JsonReaderUtils.java} (76%) diff --git a/src/main/java/calculationengine/CeExecuterService.java b/src/main/java/calculationengine/CeExecuterServiceUtils.java similarity index 96% rename from src/main/java/calculationengine/CeExecuterService.java rename to src/main/java/calculationengine/CeExecuterServiceUtils.java index 33cf799..6a7fcf0 100644 --- a/src/main/java/calculationengine/CeExecuterService.java +++ b/src/main/java/calculationengine/CeExecuterServiceUtils.java @@ -4,7 +4,7 @@ import java.util.concurrent.*; -public class CeExecuterService { +public class CeExecuterServiceUtils { private static final ThreadPoolExecutor executorService = (ThreadPoolExecutor) Executors.newFixedThreadPool(4); private static final boolean debug = BattleConstants.battleDebug; diff --git a/src/main/java/calculationengine/battle/CeBattle.java b/src/main/java/calculationengine/battle/CeBattle.java index 68da43f..75c52ee 100644 --- a/src/main/java/calculationengine/battle/CeBattle.java +++ b/src/main/java/calculationengine/battle/CeBattle.java @@ -1,7 +1,11 @@ package calculationengine.battle; -import calculationengine.CeExecuterService; -import calculationengine.entities.*; +import calculationengine.CeExecuterServiceUtils; +import calculationengine.entities.CeAi; +import calculationengine.entities.CeAttack; +import calculationengine.entities.CeBeastTypes; +import calculationengine.entities.CeEntity; +import calculationengine.entities.CePlayer; import calculationengine.environment.CeItem; import calculationengine.environment.CeItemTypes; import config.BattleConstants; @@ -33,7 +37,7 @@ public CeBattle(CePlayer cePlayer1, CePlayer cePlayer2) { this.cePlayer2 = cePlayer2; this.cePlayer1.setNumber(1); this.cePlayer2.setNumber(2); - CeExecuterService.addThreadToExecutor(this); + CeExecuterServiceUtils.addThreadToExecutor(this); } public CeBattle(CePlayer cePlayer1, CeAi cePlayer2) { diff --git a/src/main/java/calculationengine/battle/TestBattle.java b/src/main/java/calculationengine/battle/TestBattle.java index 5afafb6..7c083ea 100644 --- a/src/main/java/calculationengine/battle/TestBattle.java +++ b/src/main/java/calculationengine/battle/TestBattle.java @@ -1,6 +1,6 @@ package calculationengine.battle; -import calculationengine.CeExecuterService; +import calculationengine.CeExecuterServiceUtils; import calculationengine.entities.CeAi; import calculationengine.entities.CeAttack; import calculationengine.entities.CeAttacks; @@ -10,7 +10,7 @@ import calculationengine.entities.CePlayer; import calculationengine.entities.CeStats; import calculationengine.entities.ItemNotInInventoryException; -import calculationengine.environment.CeLoot; +import calculationengine.environment.CeLootUtils; import calculationengine.environment.CeRegions; import java.util.ArrayList; @@ -21,14 +21,14 @@ public class TestBattle { public static void main(String[] args) throws Exception { simulateAiBattle(); simulateCatch(); - CeExecuterService.shutdownExecutor(); + CeExecuterServiceUtils.shutdownExecutor(); } private static void simulateCatch() throws Exception { CePlayer cePlayer1 = init(); for (int i = 0; i < 1; i++) { - cePlayer1.getInventory().addItemToInventory(CeLoot.lootItem("cage")); + cePlayer1.getInventory().addItemToInventory(CeLootUtils.lootItem("cage")); } CeAi cePlayer2 = new CeAi(cePlayer1, CeRegions.ArkhamCity); CeBattle battle = new CeBattle(cePlayer1, cePlayer2); @@ -39,7 +39,7 @@ private static void simulateCatch() throws Exception { if (battle.getTurn().getNumber() == cePlayer1.getNumber()) { System.out.println("[Test Battle]: Turn of: Player 1"); try { - boolean caught = battle.catchBeast(CeLoot.lootItem("cage")); + boolean caught = battle.catchBeast(CeLootUtils.lootItem("cage")); if (caught) System.out.println("[Test Battle]: Beast caught! CONGRATS"); else System.out.println("[Test Battle]: Beast doesn't like you"); } catch (ItemNotInInventoryException itemNotInInventoryException) { diff --git a/src/main/java/calculationengine/environment/CeItem.java b/src/main/java/calculationengine/environment/CeItem.java index 41c2bfe..7956337 100644 --- a/src/main/java/calculationengine/environment/CeItem.java +++ b/src/main/java/calculationengine/environment/CeItem.java @@ -15,9 +15,6 @@ public class CeItem { private String description; private CeItemEffects effect; - public CeItem() { - } - public void setItemFromSaveGame(JSONObject itemJson) { this.equipped = itemJson.getBoolean("equipped"); //TODO: needs to be in the savegame JSON setItem(itemJson); @@ -34,7 +31,7 @@ private void setItem(JSONObject itemJson) { this.unique = itemJson.getBoolean("unique"); this.type = CeItemTypes.valueOf(itemJson.getString("type")); this.uses = itemJson.getInt("uses"); - this.itemBonusStats = new CeItemBonusStats(CeLoot.jsonArrayToIntArray(itemJson.getJSONArray("bonusStats"))); + this.itemBonusStats = new CeItemBonusStats(CeLootUtils.jsonArrayToIntArray(itemJson.getJSONArray("bonusStats"))); this.description = itemJson.getString("description"); this.effect = new CeItemEffects(itemJson.getJSONObject("effects")); } diff --git a/src/main/java/calculationengine/environment/CeLoot.java b/src/main/java/calculationengine/environment/CeLootUtils.java similarity index 98% rename from src/main/java/calculationengine/environment/CeLoot.java rename to src/main/java/calculationengine/environment/CeLootUtils.java index 6e3eadf..f104d01 100644 --- a/src/main/java/calculationengine/environment/CeLoot.java +++ b/src/main/java/calculationengine/environment/CeLootUtils.java @@ -4,7 +4,7 @@ import org.json.JSONObject; import static config.LootConstants.itemList; -public class CeLoot { +public class CeLootUtils { public static CeItem lootItem(String itemKey) { JSONObject itemJson = new JSONObject(itemList.get(itemKey).toString()); diff --git a/src/main/java/calculationengine/environment/TestItems.java b/src/main/java/calculationengine/environment/TestItems.java index 454bf3d..23b9ca7 100644 --- a/src/main/java/calculationengine/environment/TestItems.java +++ b/src/main/java/calculationengine/environment/TestItems.java @@ -18,13 +18,13 @@ public class TestItems { public static void main(String[] args) throws NoPlaceInInventoryException { - System.out.println(CeLoot.lootItem("cage").toString()); + System.out.println(CeLootUtils.lootItem("cage").toString()); CeInventory inventory = new CeInventory(new CeStats(CeBeasts.StinkenderFeuerFurz)); - inventory.addItemToInventory(CeLoot.lootItem("cage")); + inventory.addItemToInventory(CeLootUtils.lootItem("cage")); System.out.println("Amount: " + inventory.getSlots()[0].getAmount()); // should be 1 - inventory.addItemToInventory(CeLoot.lootItem("cage")); + inventory.addItemToInventory(CeLootUtils.lootItem("cage")); System.out.println("Amount: " + inventory.getSlots()[0].getAmount()); // should be 2 - inventory.addItemToInventory(CeLoot.lootItem("aHealingPotion")); + inventory.addItemToInventory(CeLootUtils.lootItem("aHealingPotion")); System.out.println(inventory.getSlots()[1].getItem().toString()); List team = new ArrayList<>(); @@ -34,16 +34,16 @@ public static void main(String[] args) throws NoPlaceInInventoryException { System.out.println(cePlayer1.getCeStats().getCurrentHitPoints()); System.out.println(cePlayer1.getCeStats().toString()); - cePlayer1.getInventory().addItemToInventory(CeLoot.lootItem("aGreaterHealingPotion")); + cePlayer1.getInventory().addItemToInventory(CeLootUtils.lootItem("aGreaterHealingPotion")); try { - cePlayer1.getInventory().useItem(CeLoot.lootItem("aGreaterHealingPotion")); + cePlayer1.getInventory().useItem(CeLootUtils.lootItem("aGreaterHealingPotion")); System.out.println(cePlayer1.getCeStats().getCurrentHitPoints()); } catch (ItemNotInInventoryException itemNotInInventoryException) { itemNotInInventoryException.printStackTrace(); } - cePlayer1.getInventory().addItemToInventory(CeLoot.lootItem("stickOfBeating")); + cePlayer1.getInventory().addItemToInventory(CeLootUtils.lootItem("stickOfBeating")); try { - cePlayer1.getInventory().setEquippedItem(CeLoot.lootItem("stickOfBeating")); + cePlayer1.getInventory().setEquippedItem(CeLootUtils.lootItem("stickOfBeating")); } catch (WrongItemException wrongItemException) { wrongItemException.printStackTrace(); } diff --git a/src/main/java/config/LootConstants.java b/src/main/java/config/LootConstants.java index 9fb58e3..b226a84 100644 --- a/src/main/java/config/LootConstants.java +++ b/src/main/java/config/LootConstants.java @@ -2,7 +2,7 @@ import org.json.JSONObject; -import static utilities.JsonReader.readJson; +import static utilities.JsonReaderUtils.readJson; public class LootConstants { diff --git a/src/main/java/utilities/JsonReader.java b/src/main/java/utilities/JsonReaderUtils.java similarity index 76% rename from src/main/java/utilities/JsonReader.java rename to src/main/java/utilities/JsonReaderUtils.java index d9f1a32..176c6b6 100644 --- a/src/main/java/utilities/JsonReader.java +++ b/src/main/java/utilities/JsonReaderUtils.java @@ -2,13 +2,16 @@ import org.json.JSONObject; -import java.io.*; +import java.io.BufferedReader; +import java.io.IOException; +import java.io.InputStream; +import java.io.InputStreamReader; import java.nio.charset.StandardCharsets; -public class JsonReader { +public class JsonReaderUtils { public static JSONObject readJson(String fileName) { - InputStream inputStream = JsonReader.class.getResourceAsStream(fileName); + InputStream inputStream = JsonReaderUtils.class.getResourceAsStream(fileName); StringBuilder sJson = new StringBuilder(); try { assert inputStream != null; From 644ffd5a815c8d3bac8634a8fdee9e2ccb190657 Mon Sep 17 00:00:00 2001 From: lkno0705 Date: Mon, 31 May 2021 15:43:17 +0200 Subject: [PATCH 19/19] fix unittests --- .../java/calculationengine/enviroment/CeInventoryTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/java/calculationengine/enviroment/CeInventoryTest.java b/src/test/java/calculationengine/enviroment/CeInventoryTest.java index c43777f..1e5a040 100644 --- a/src/test/java/calculationengine/enviroment/CeInventoryTest.java +++ b/src/test/java/calculationengine/enviroment/CeInventoryTest.java @@ -55,8 +55,8 @@ public void addItemTwoTimesToInventory() throws NoPlaceInInventoryException { assertEquals(itemAmount, amountToAdd); } - @Test(expected = NullPointerException.class) - public void addNullToInventory() throws NoPlaceInInventoryException { + @Test(expected = IllegalArgumentException.class) + public void addNullToInventory() throws IllegalArgumentException, NoPlaceInInventoryException { ceInventory.addItemToInventory(null); }