[BUG] TypeError: Cannot read properties of undefined (reading 'trim')

[c-sunc6]

Problem (one or two sentences)

TypeError: Cannot read properties of undefined (reading 'trim')
at inputValue.trim (../../../../webview-ui/src/components/chat/ChatTextArea.tsx:262:21)
at ti (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:172:118)
at useMemo (../../../../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js:26:47)
at inputValue.trim (../../../../webview-ui/src/components/chat/ChatTextArea.tsx:261:26)
at Nh (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:160:136)
at Yi (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:192:56)
at f,b.memoizedState=f,b.flags&256){e=Ji(Error(p(423)),b);b=lj (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:293:274)
at tj (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:279:388)
at tj (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:279:319)
at tj (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:279:179)
组件堆栈：

at https://vscode-remote+attached-002dcontainer-002b7b22636f6e7461696e65724e616d65223a222f73696d5f7632227d.vscode-resource.vscode-cdn.net/root/.vscode-server/extensions/rooveterinaryinc.roo-cline-3.50.5/webview-ui/build/assets/index.js:2743:207656
at div

at alo (../../../../webview-ui/src/components/chat/ChatView.tsx:69:3)
at wbo (../../../../webview-ui/src/App.tsx:69:5)
at d (../../../../node_modules/.pnpm/@radix-ui+react-context@1.1.2_@types+react@18.3.23_react@18.3.1/node_modules/@radix-ui/react-context/dist/index.mjs:27:14)
at H3t (../../../../node_modules/.pnpm/@radix-ui+react-tooltip@1.2.6_@types+react-dom@18.3.7_@types+react@18.3.23__@types+reac_99504aa956c623e0884a4e3cb215669a/node_modules/@radix-ui/react-tooltip/dist/index.mjs:29:4)
at _3 (../../../../webview-ui/src/components/ui/tooltip.tsx:8:47704)
at B6t (../../../../node_modules/.pnpm/@TanStack+react-query@5.76.1_react@18.3.1/node_modules/@tanstack/react-query/build/modern/QueryClientProvider.js:20:2)
at sHt (../../../../webview-ui/src/i18n/TranslationContext.tsx:16:70)
at nHt (../../../../webview-ui/src/context/ExtensionStateContext.tsx:192:86)
at mbo (../../../../webview-ui/src/components/ErrorBoundary.tsx:18:2)
at i (../../../../node_modules/.pnpm/react-i18next@15.5.1_i18next@25.2.1_typescript@5.8.3__react-dom@18.3.1_react@18.3.1__react@18.3.1_typescript@5.8.3/node_modules/react-i18next/dist/es/withTranslation.js:6:4)
at _bo (../../../../webview-ui/src/App.tsx:319:25)

Context (who is affected and when)

TypeError: Cannot read properties of undefined (reading 'trim')

Reproduction steps

13.log

Expected result

12

Actual result

21

Variations tried (optional)

插件不能使用

App Version

(v3.50.5)

API Provider (optional)

OpenAI Compatible

Model Used (optional)

No response

Roo Code Task Links (optional)

No response

Relevant logs or errors (optional)

[roomote]

I've analyzed this issue and here's my proposed implementation plan:

Root Cause:
In webview-ui/src/components/chat/ChatTextArea.tsx, the inputValue prop is typed as string but can become undefined at runtime (likely due to a race condition during React state updates or message handling). When this happens, calling .trim() on undefined throws the TypeError: Cannot read properties of undefined (reading 'trim') seen in the stack trace at line 262.

Affected code locations in ChatTextArea.tsx:

1. Line 248: const trimmedInput = inputValue.trim() (in handleEnhancePrompt)
2. Line 262: inputValue.trim().length > 0 (in hasInputContent useMemo)

There are also multiple other places where inputValue is accessed with bracket notation (e.g., inputValue[cursorPosition - 1]) or .slice() that would similarly fail if inputValue is undefined.

Proposed Fix:
Add a default value for inputValue at the destructuring point inside the component, so all downstream usages are safe:

// In the component destructuring (around line 64):
const { inputValue: rawInputValue, ... } = props
const inputValue = rawInputValue ?? ""

Alternatively (simpler and less invasive), add a single line after destructuring:

const safeInputValue = inputValue ?? ""

However, the cleanest approach is to add a default value directly in the destructuring:

inputValue = "",  // default to empty string

This ensures all 22+ usages of inputValue within the component are protected without needing to change each individual call site.

Testing:

• Verify existing ChatTextArea tests still pass
• Confirm the hasInputContent memo returns false when inputValue is undefined/empty

This approach will fix the crash with minimal risk and no behavioral changes for the normal case where inputValue is already a string.

Please mention @roomote in a comment saying that you approve this plan, and I'll proceed with the implementation.