-
Notifications
You must be signed in to change notification settings - Fork 2
Description
Copy/pasting from @LiaHiscock's comments in #4 (comment):
"""
Off the top of my head, there are a couple complications with requiring only a manifest file. The main one brought up was that manifests can be served over different domains via CDN, which opens the door for spoofing issues, and would require additional validation, likely something like -
- Load the manifest file in the background.
- Parse the start_url, and load that in the background.
- Verify that the document at start_url contains a link back to same manifest from step 1.
This extra loading could be avoided but would exclude manifests served via CDN, as noted by Dan in his recent reply -
One thought for manifest_url only install - This seems maybe OK if we require the manifest is same-origin as the start_url. Most manifests we see satisfy this. I could see this simplifying the cross-origin install, although the tradeoff is potentially stale manifest urls.
We're definitely open to iterating on the attribute design, especially given that a direct manifesturl link would enable custom rendering in the button, but given that our mutually established goal was to OT/ship a basic element to start getting developer feedback, we thought proposing a 1:1 matching of declarative attributes to API parameters would make the most sense. This will also give us more time to discuss design, usability tradeoffs, and technical implementation with Dan and co, without holding up the initial declarative OT.
"""