From 448f66d94595144ff6e7fdfd205dbf436e1e2575 Mon Sep 17 00:00:00 2001 From: Sam Clegg Date: Wed, 18 Feb 2026 12:30:18 -0800 Subject: [PATCH] [test] Don't `--failfast` by default. Normally this option default to false, and it seems like binaryen doesn't have a good reason to differ. However, this setting (originally called `--abort-on-first-failure`) has always been enabled by default since its was first added back in #771. Also name the option `--failfast` to match the name it has in the python unittest framework. --- scripts/test/shared.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/test/shared.py b/scripts/test/shared.py index ad02b617d44..341b6af5f40 100644 --- a/scripts/test/shared.py +++ b/scripts/test/shared.py @@ -41,10 +41,10 @@ def parse_args(args): '--no-torture', dest='torture', action='store_false', help='Disables running the torture testcases.') parser.add_argument( - '--abort-on-first-failure', '--fail-fast', dest='abort_on_first_failure', - action=argparse.BooleanOptionalAction, default=True, + '--abort-on-first-failure', '--failfast', dest='abort_on_first_failure', + action=argparse.BooleanOptionalAction, help=('Specifies whether to halt test suite execution on first test error.' - ' Default: true.')) + ' Default: false.')) parser.add_argument( '--binaryen-bin', dest='binaryen_bin', default='', help=('Specifies the path to the Binaryen executables in the CMake build'