From 4008fa90f83d6f99c33fb83c650058bcb17023c2 Mon Sep 17 00:00:00 2001 From: Braelyn Boynton Date: Tue, 7 Jan 2025 19:13:31 +0000 Subject: [PATCH 1/2] stop test telemetry logging --- agentstack/telemetry.py | 8 +++++++- tox.ini | 3 ++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/agentstack/telemetry.py b/agentstack/telemetry.py index 92cc43ae..512218db 100644 --- a/agentstack/telemetry.py +++ b/agentstack/telemetry.py @@ -21,7 +21,7 @@ # cool of you to allow telemetry <3 # # - braelyn - +import os import platform import socket from typing import Optional @@ -76,6 +76,9 @@ def collect_machine_telemetry(command: str): def track_cli_command(command: str, args: Optional[str] = None): + if bool(os.environ['AGENTSTACK_NO_TEST_TELEMETRY']): + return + try: data = collect_machine_telemetry(command) headers = {} @@ -88,6 +91,9 @@ def track_cli_command(command: str, args: Optional[str] = None): pass def update_telemetry(id: int, result: int, message: Optional[str] = None): + if bool(os.environ['AGENTSTACK_NO_TEST_TELEMETRY']): + return + try: requests.put(TELEMETRY_URL, json={"id": id, "result": result, "message": message}) except Exception: diff --git a/tox.ini b/tox.ini index a29b10e8..c5419856 100644 --- a/tox.ini +++ b/tox.ini @@ -17,7 +17,8 @@ commands = coverage report -m coverage xml mypy: mypy agentstack -setenv = +setenv = + AGENTSTACK_NO_TEST_TELEMETRY = 1 AGENTSTACK_TELEMETRY_OPT_OUT = 1 AGENTSTACK_UPDATE_DISABLE = 1 From dd6b15bb275e2efda11303dfdbe12fadf39a93b0 Mon Sep 17 00:00:00 2001 From: Braelyn Boynton Date: Tue, 7 Jan 2025 20:02:33 +0000 Subject: [PATCH 2/2] env var name --- agentstack/telemetry.py | 4 ++-- tox.ini | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/agentstack/telemetry.py b/agentstack/telemetry.py index 512218db..0008efbc 100644 --- a/agentstack/telemetry.py +++ b/agentstack/telemetry.py @@ -76,7 +76,7 @@ def collect_machine_telemetry(command: str): def track_cli_command(command: str, args: Optional[str] = None): - if bool(os.environ['AGENTSTACK_NO_TEST_TELEMETRY']): + if bool(os.environ['AGENTSTATCK_IS_TEST_ENV']): return try: @@ -91,7 +91,7 @@ def track_cli_command(command: str, args: Optional[str] = None): pass def update_telemetry(id: int, result: int, message: Optional[str] = None): - if bool(os.environ['AGENTSTACK_NO_TEST_TELEMETRY']): + if bool(os.environ['AGENTSTATCK_IS_TEST_ENV']): return try: diff --git a/tox.ini b/tox.ini index c5419856..fd878735 100644 --- a/tox.ini +++ b/tox.ini @@ -18,7 +18,7 @@ commands = coverage xml mypy: mypy agentstack setenv = - AGENTSTACK_NO_TEST_TELEMETRY = 1 + AGENTSTATCK_IS_TEST_ENV = 1 AGENTSTACK_TELEMETRY_OPT_OUT = 1 AGENTSTACK_UPDATE_DISABLE = 1