Revert "fix(@angular/build): preserve names in esbuild for improved debugging in dev mode"

This reverts commit 48f425e.

Closes: angular#31198
(cherry picked from commit d0631c5)

Author: alan-agius4

packages/angular/build/src/tools/esbuild/application-code-bundle.ts

@@ -607,9 +607,6 @@ function getEsBuildCommonOptions(options: NormalizedApplicationBuildOptions): Bu
     }
   }
 
-  const minifySyntax = optimizationOptions.scripts;
-  const minifyIdentifiers = minifySyntax && allowMangle;
-
   return {
     absWorkingDir: workspaceRoot,
     format: 'esm',
@@ -621,10 +618,9 @@ function getEsBuildCommonOptions(options: NormalizedApplicationBuildOptions): Bu
     metafile: true,
     legalComments: options.extractLicenses ? 'none' : 'eof',
     logLevel: options.verbose && !jsonLogs ? 'debug' : 'silent',
-    keepNames: !minifyIdentifiers,
-    minifyIdentifiers,
-    minifySyntax,
-    minifyWhitespace: minifySyntax,
+    minifyIdentifiers: optimizationOptions.scripts && allowMangle,
+    minifySyntax: optimizationOptions.scripts,
+    minifyWhitespace: optimizationOptions.scripts,
     pure: ['forwardRef'],
     outdir: workspaceRoot,
     outExtension: outExtension ? { '.js': `.${outExtension}` } : undefined,
@@ -641,7 +637,7 @@ function getEsBuildCommonOptions(options: NormalizedApplicationBuildOptions): Bu
       // Only set to false when script optimizations are enabled. It should not be set to true because
       // Angular turns `ngDevMode` into an object for development debugging purposes when not defined
       // which a constant true value would break.
-      ...(minifySyntax ? { 'ngDevMode': 'false' } : undefined),
+      ...(optimizationOptions.scripts ? { 'ngDevMode': 'false' } : undefined),
       'ngJitMode': jit ? 'true' : 'false',
       'ngServerMode': 'false',
       'ngHmrMode': options.templateUpdates ? 'true' : 'false',

packages/angular/build/src/tools/vite/utils.ts

@@ -98,7 +98,6 @@ export function getDepOptimizationConfig({
     esbuildOptions: {
       // Set esbuild supported targets.
       target,
-      keepNames: true,
       supported: getFeatureSupport(target, zoneless),
       plugins,
       loader,

tests/legacy-cli/e2e/tests/build/prerender/error-with-sourcemaps.ts

@@ -48,6 +48,6 @@ export default async function () {
     message,
     // When babel is used it will add names to the sourcemap and `constructor` will be used in the stack trace.
     // This will currently only happen if AOT and script optimizations are set which enables advanced optimizations.
-    /window is not defined[.\s\S]*(?:constructor|App) \(.*app\.ts\:\d+:\d+\)/,
+    /window is not defined[.\s\S]*(?:constructor|_App) \(.*app\.ts\:\d+:\d+\)/,
   );
 }