From 8e5932cf0bf202cf4aca9c2c9a2f335b9a0480fd Mon Sep 17 00:00:00 2001 From: Charles Lyding <19598772+clydin@users.noreply.github.com> Date: Mon, 15 Dec 2025 17:33:36 -0500 Subject: [PATCH] refactor(@angular-devkit/build-angular): remove redundant spinner coloring This commit refactors the usage of the `Spinner` class in `@angular-devkit/build-angular` builders by removing explicit `colors.redBright` calls when invoking `spinner.fail()`. The `Spinner.fail()` method already applies red bright coloring internally. This change centralizes the styling logic within the `Spinner` class and prevents redundant coloring or unnecessary dependency usage at the call site. --- .../angular_devkit/build_angular/src/builders/browser/index.ts | 3 +-- .../angular_devkit/build_angular/src/builders/server/index.ts | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/angular_devkit/build_angular/src/builders/browser/index.ts b/packages/angular_devkit/build_angular/src/builders/browser/index.ts index 1052e2165587..9c1576251d74 100644 --- a/packages/angular_devkit/build_angular/src/builders/browser/index.ts +++ b/packages/angular_devkit/build_angular/src/builders/browser/index.ts @@ -43,7 +43,6 @@ import { normalizeOptimization, urlJoin, } from '../../utils'; -import { colors } from '../../utils/color'; import { copyAssets } from '../../utils/copy-assets'; import { assertIsError } from '../../utils/error'; import { i18nInlineEmittedFiles } from '../../utils/i18n-inlining'; @@ -280,7 +279,7 @@ export function buildWebpackBrowser( ); spinner.succeed('Copying assets complete.'); } catch (err) { - spinner.fail(colors.redBright('Copying of assets failed.')); + spinner.fail('Copying of assets failed.'); assertIsError(err); return { diff --git a/packages/angular_devkit/build_angular/src/builders/server/index.ts b/packages/angular_devkit/build_angular/src/builders/server/index.ts index 5a246178d10c..4903fe8e2403 100644 --- a/packages/angular_devkit/build_angular/src/builders/server/index.ts +++ b/packages/angular_devkit/build_angular/src/builders/server/index.ts @@ -28,7 +28,6 @@ import { deleteOutputDir, normalizeAssetPatterns, } from '../../utils'; -import { colors } from '../../utils/color'; import { copyAssets } from '../../utils/copy-assets'; import { assertIsError } from '../../utils/error'; import { i18nInlineEmittedFiles } from '../../utils/i18n-inlining'; @@ -121,7 +120,7 @@ export function execute( ); spinner.succeed('Copying assets complete.'); } catch (err) { - spinner.fail(colors.redBright('Copying of assets failed.')); + spinner.fail('Copying of assets failed.'); assertIsError(err); return {