scripting: assume XMLBeans 5.x, replace call to getXmlObject with toXMLString

Removes field scope from class JSOMElementConvertor. This field was created within an enter/exit block in the constructor, but after the exit block, its state was invalid.

Reduces try/catch scope when parsing xml object.

Author: lgayard-brex

modules/scripting/src/org/apache/axis2/scripting/convertors/JSOMElementConvertor.java

@@ -21,53 +21,38 @@
 
 import org.apache.axiom.om.OMElement;
 import org.apache.axiom.om.OMXMLBuilderFactory;
-import org.apache.axiom.om.OMXMLParserWrapper;
 import org.apache.xmlbeans.XmlObject;
 import org.mozilla.javascript.Context;
 import org.mozilla.javascript.Scriptable;
 import org.mozilla.javascript.ScriptableObject;
 import org.mozilla.javascript.Wrapper;
 import org.mozilla.javascript.xml.XMLObject;
 
-import java.io.StringReader;
-
 /**
  * JSObjectConvertor converts between OMElements and JavaScript E4X XML objects
  */
 public class JSOMElementConvertor extends DefaultOMElementConvertor {
+    public Object toScript(OMElement o) {
+        XmlObject xml;
+        try {
+            xml = XmlObject.Factory.parse(o.getXMLStreamReader());
+        } catch (Exception e) {
+            throw new RuntimeException("exception getting message XML: " + e);
+        }
 
-    protected Scriptable scope;
-
-    public JSOMElementConvertor() {
         Context cx = Context.enter();
         try {
-            this.scope = cx.initStandardObjects();
+            // Enable E4X support
+            cx.setLanguageVersion(Context.VERSION_1_6);
+            Scriptable tempScope = cx.initStandardObjects();
+
+            // Wrap the XmlObject directly
+            return cx.getWrapFactory().wrap(cx, tempScope, xml, XmlObject.class);
         } finally {
             Context.exit();
         }
     }
 
-    public Object toScript(OMElement o) {
-        try {
-            XmlObject xml = XmlObject.Factory.parse(o.getXMLStreamReader());
-            
-            Context cx = Context.enter();
-            try {
-                // Enable E4X support
-                cx.setLanguageVersion(Context.VERSION_1_6);
-                Scriptable tempScope = cx.initStandardObjects();
-                
-                // Wrap the XmlObject directly
-                return cx.getWrapFactory().wrap(cx, tempScope, xml, XmlObject.class);
-                
-            } finally {
-                Context.exit();
-            }
-        } catch (Exception e) {
-            throw new RuntimeException("exception getting message XML: " + e);
-        }
-    }
-
     public OMElement fromScript(Object o) {
         if (!(o instanceof XMLObject) && !(o instanceof Wrapper)) {
             return super.fromScript(o);
@@ -83,7 +68,7 @@ public OMElement fromScript(Object o) {
                     xmlObject = (XmlObject) unwrapped;
                 }
             }
-            
+
             // If we have an XMLObject but not a wrapped XmlObject, try the old approach
             if (xmlObject == null && o instanceof XMLObject) {
                 // TODO: E4X Bug? Shouldn't need this copy, but without it the outer element gets lost. See Mozilla bugzilla 361722
@@ -105,7 +90,7 @@ public OMElement fromScript(Object o) {
                     .createOMBuilder(new java.io.StringReader(normalizedXML))
                     .getDocumentElement();
             }
-            
+
             if (xmlObject != null) {
                 return OMXMLBuilderFactory
                     .createOMBuilder(xmlObject.newInputStream())