Code review comments

Author: yoavcloud

src/ast/mod.rs

@@ -695,8 +695,6 @@ pub enum Expr {
         // https://cloud.google.com/bigquery/docs/reference/standard-sql/format-elements#formatting_syntax
         format: Option<CastFormat>,
     },
-    /// `DEFAULT` value of a column e.g. INSERT INTO tbl (a, b) VALUES ('foo', DEFAULT)
-    Default,
     /// AT a timestamp to a different timezone e.g. `FROM_UNIXTIME(0) AT TIME ZONE 'UTC-06:00'`
     AtTimeZone {
         timestamp: Box<Expr>,
@@ -1451,7 +1449,6 @@ impl fmt::Display for Expr {
                     write!(f, "{expr}::{data_type}")
                 }
             },
-            Expr::Default => write!(f, "DEFAULT"),
             Expr::Extract {
                 field,
                 syntax,

src/dialect/mod.rs

@@ -657,7 +657,7 @@ pub trait Dialect: Debug + Any {
     fn supports_create_table_select(&self) -> bool {
         false
     }
-    
+
     /// Returns true if the specified keyword is reserved and cannot be
     /// used as an identifier without special handling like quoting.
     fn is_reserved_for_identifier(&self, kw: Keyword) -> bool {

src/parser/mod.rs

@@ -45,9 +45,6 @@ pub enum ParserError {
     TokenizerError(String),
     ParserError(String),
     RecursionLimitExceeded,
-    /// Error indicating that the parsing branch taken
-    /// did not yield a meaningful result
-    BranchAbandoned,
 }
 
 // avoid clippy type_complexity warnings
@@ -177,7 +174,6 @@ impl fmt::Display for ParserError {
                 ParserError::TokenizerError(s) => s,
                 ParserError::ParserError(s) => s,
                 ParserError::RecursionLimitExceeded => "recursion limit exceeded",
-                ParserError::BranchAbandoned => "branch abandoned",
             }
         )
     }
@@ -1013,45 +1009,48 @@ impl<'a> Parser<'a> {
         Ok(Statement::NOTIFY { channel, payload })
     }
 
-    fn parse_expr_by_keyword(&mut self, w: &Word) -> Result<Expr, ParserError> {
+    fn parse_expr_prefix_by_reserved_word(
+        &mut self,
+        w: &Word,
+    ) -> Result<Option<Expr>, ParserError> {
         match w.keyword {
             Keyword::TRUE | Keyword::FALSE if self.dialect.supports_boolean_literals() => {
                 self.prev_token();
-                Ok(Expr::Value(self.parse_value()?))
+                Ok(Some(Expr::Value(self.parse_value()?)))
             }
             Keyword::NULL => {
                 self.prev_token();
-                Ok(Expr::Value(self.parse_value()?))
+                Ok(Some(Expr::Value(self.parse_value()?)))
             }
             Keyword::CURRENT_CATALOG
             | Keyword::CURRENT_USER
             | Keyword::SESSION_USER
             | Keyword::USER
                 if dialect_of!(self is PostgreSqlDialect | GenericDialect) =>
             {
-                Ok(Expr::Function(Function {
+                Ok(Some(Expr::Function(Function {
                     name: ObjectName(vec![w.to_ident()]),
                     parameters: FunctionArguments::None,
                     args: FunctionArguments::None,
                     null_treatment: None,
                     filter: None,
                     over: None,
                     within_group: vec![],
-                }))
+                })))
             }
             Keyword::CURRENT_TIMESTAMP
             | Keyword::CURRENT_TIME
             | Keyword::CURRENT_DATE
             | Keyword::LOCALTIME
             | Keyword::LOCALTIMESTAMP => {
-                self.parse_time_functions(ObjectName(vec![w.to_ident()]))
-            }
-            Keyword::CASE => self.parse_case_expr(),
-            Keyword::CONVERT => self.parse_convert_expr(false),
-            Keyword::TRY_CONVERT if self.dialect.supports_try_convert() => self.parse_convert_expr(true),
-            Keyword::CAST => self.parse_cast_expr(CastKind::Cast),
-            Keyword::TRY_CAST => self.parse_cast_expr(CastKind::TryCast),
-            Keyword::SAFE_CAST => self.parse_cast_expr(CastKind::SafeCast),
+                Ok(Some(self.parse_time_functions(ObjectName(vec![w.to_ident()]))?))
+            }
+            Keyword::CASE => Ok(Some(self.parse_case_expr()?)),
+            Keyword::CONVERT => Ok(Some(self.parse_convert_expr(false)?)),
+            Keyword::TRY_CONVERT if self.dialect.supports_try_convert() => Ok(Some(self.parse_convert_expr(true)?)),
+            Keyword::CAST => Ok(Some(self.parse_cast_expr(CastKind::Cast)?)),
+            Keyword::TRY_CAST => Ok(Some(self.parse_cast_expr(CastKind::TryCast)?)),
+            Keyword::SAFE_CAST => Ok(Some(self.parse_cast_expr(CastKind::SafeCast)?)),
             Keyword::EXISTS
                 // Support parsing Databricks has a function named `exists`.
                 if !dialect_of!(self is DatabricksDialect)
@@ -1063,22 +1062,22 @@ impl<'a> Parser<'a> {
                         })
                     ) =>
             {
-                self.parse_exists_expr(false)
+                Ok(Some(self.parse_exists_expr(false)?))
             }
-            Keyword::EXTRACT => self.parse_extract_expr(),
-            Keyword::CEIL => self.parse_ceil_floor_expr(true),
-            Keyword::FLOOR => self.parse_ceil_floor_expr(false),
+            Keyword::EXTRACT => Ok(Some(self.parse_extract_expr()?)),
+            Keyword::CEIL => Ok(Some(self.parse_ceil_floor_expr(true)?)),
+            Keyword::FLOOR => Ok(Some(self.parse_ceil_floor_expr(false)?)),
             Keyword::POSITION if self.peek_token().token == Token::LParen => {
-                self.parse_position_expr(w.to_ident())
+                Ok(Some(self.parse_position_expr(w.to_ident())?))
             }
-            Keyword::SUBSTRING => self.parse_substring_expr(),
-            Keyword::OVERLAY => self.parse_overlay_expr(),
-            Keyword::TRIM => self.parse_trim_expr(),
-            Keyword::INTERVAL => self.parse_interval(),
+            Keyword::SUBSTRING => Ok(Some(self.parse_substring_expr()?)),
+            Keyword::OVERLAY => Ok(Some(self.parse_overlay_expr()?)),
+            Keyword::TRIM => Ok(Some(self.parse_trim_expr()?)),
+            Keyword::INTERVAL => Ok(Some(self.parse_interval()?)),
             // Treat ARRAY[1,2,3] as an array [1,2,3], otherwise try as subquery or a function call
             Keyword::ARRAY if self.peek_token() == Token::LBracket => {
                 self.expect_token(&Token::LBracket)?;
-                self.parse_array_expr(true)
+                Ok(Some(self.parse_array_expr(true)?))
             }
             Keyword::ARRAY
                 if self.peek_token() == Token::LParen
@@ -1087,37 +1086,36 @@ impl<'a> Parser<'a> {
                 self.expect_token(&Token::LParen)?;
                 let query = self.parse_query()?;
                 self.expect_token(&Token::RParen)?;
-                Ok(Expr::Function(Function {
+                Ok(Some(Expr::Function(Function {
                     name: ObjectName(vec![w.to_ident()]),
                     parameters: FunctionArguments::None,
                     args: FunctionArguments::Subquery(query),
                     filter: None,
                     null_treatment: None,
                     over: None,
                     within_group: vec![],
-                }))
+                })))
             }
-            Keyword::NOT => self.parse_not(),
+            Keyword::NOT => Ok(Some(self.parse_not()?)),
             Keyword::MATCH if dialect_of!(self is MySqlDialect | GenericDialect) => {
-                self.parse_match_against()
+                Ok(Some(self.parse_match_against()?))
             }
             Keyword::STRUCT if dialect_of!(self is BigQueryDialect | GenericDialect) => {
                 self.prev_token();
-                self.parse_bigquery_struct_literal()
+                Ok(Some(self.parse_bigquery_struct_literal()?))
             }
             Keyword::PRIOR if matches!(self.state, ParserState::ConnectBy) => {
                 let expr = self.parse_subexpr(self.dialect.prec_value(Precedence::PlusMinus))?;
-                Ok(Expr::Prior(Box::new(expr)))
+                Ok(Some(Expr::Prior(Box::new(expr))))
             }
             Keyword::MAP if self.peek_token() == Token::LBrace && self.dialect.support_map_literal_syntax() => {
-                self.parse_duckdb_map_literal()
+                Ok(Some(self.parse_duckdb_map_literal()?))
             }
-            Keyword::DEFAULT => Ok(Expr::Default),
-            _ => Err(ParserError::BranchAbandoned)
+            _ => Ok(None)
         }
     }
 
-    fn parse_ident_expr(&mut self, w: &Word) -> Result<Expr, ParserError> {
+    fn parse_expr_prefix_by_nonreserved_word(&mut self, w: &Word) -> Result<Expr, ParserError> {
         match self.peek_token().token {
             Token::LParen | Token::Period => {
                 let mut id_parts: Vec<Ident> = vec![w.to_ident()];
@@ -1233,23 +1231,33 @@ impl<'a> Parser<'a> {
 
         let next_token = self.next_token();
         let expr = match next_token.token {
-            // We first try to parse the word as the prefix of an expression.
-            // For example, the word INTERVAL in: SELECT INTERVAL '7' DAY
-            Token::Word(w) => match self.try_parse(|parser| parser.parse_expr_by_keyword(&w)) {
-                Ok(expr) => Ok(expr),
-                // Word does not indicate the start of a complex expression, try to parse as identifier
-                Err(ParserError::BranchAbandoned) => Ok(self.parse_ident_expr(&w)?),
-                // Word indicates the start of a complex expression, try to parse as identifier if the
-                // dialect does not reserve it, otherwise return the original error
-                Err(e) => {
-                    if !self.dialect.is_reserved_for_identifier(w.keyword) {
-                        if let Ok(expr) = self.try_parse(|parser| parser.parse_ident_expr(&w)) {
-                            return Ok(expr);
+            Token::Word(w) => {
+                // Save the parser index so we can rollback
+                let index_before = self.index;
+                // We first try to parse the word as the prefix of an expression.
+                // For example, the word INTERVAL in: SELECT INTERVAL '7' DAY
+                match self.parse_expr_prefix_by_reserved_word(&w) {
+                    // No expression prefix associated with this word
+                    Ok(None) => Ok(self.parse_expr_prefix_by_nonreserved_word(&w)?),
+                    // This word indicated an expression prefix and parsing was successful
+                    Ok(Some(expr)) => Ok(expr),
+                    // This word indicated an expression prefix but parsing failed. Two options:
+                    // 1. Malformed statement
+                    // 2. The dialect may allow this word as identifier as well as indicating an expression
+                    Err(e) => {
+                        let index_after_error = self.index;
+                        if !self.dialect.is_reserved_for_identifier(w.keyword) {
+                            // Rollback before trying to parse using a different approach
+                            self.index = index_before;
+                            if let Ok(expr) = self.parse_expr_prefix_by_nonreserved_word(&w) {
+                                return Ok(expr);
+                            }
                         }
+                        self.index = index_after_error;
+                        return Err(e);
                     }
-                    return Err(e);
                 }
-            }, // End of Token::Word
+            } // End of Token::Word
             // array `[1, 2, 3]`
             Token::LBracket => self.parse_array_expr(false),
             tok @ Token::Minus | tok @ Token::Plus => {
@@ -3680,24 +3688,6 @@ impl<'a> Parser<'a> {
         }
     }
 
-    /// Run a parser method `f`, reverting back to the current position if unsuccessful
-    /// but retaining the error message if such was raised by `f`
-    pub fn try_parse<T, F>(&mut self, mut f: F) -> Result<T, ParserError>
-    where
-        F: FnMut(&mut Parser) -> Result<T, ParserError>,
-    {
-        let index = self.index;
-        match f(self) {
-            Ok(t) => Ok(t),
-            // Unwind stack if limit exceeded
-            Err(ParserError::RecursionLimitExceeded) => Err(ParserError::RecursionLimitExceeded),
-            Err(e) => {
-                self.index = index;
-                Err(e)
-            }
-        }
-    }
-
     /// Parse either `ALL`, `DISTINCT` or `DISTINCT ON (...)`. Returns [`None`] if `ALL` is parsed
     /// and results in a [`ParserError`] if both `ALL` and `DISTINCT` are found.
     pub fn parse_all_or_distinct(&mut self) -> Result<Option<Distinct>, ParserError> {

tests/sqlparser_bigquery.rs

@@ -1744,7 +1744,10 @@ fn parse_merge() {
                             columns: vec![Ident::new("a"), Ident::new("b"),],
                             kind: MergeInsertKind::Values(Values {
                                 explicit_row: false,
-                                rows: vec![vec![Expr::Value(number("1")), Expr::Default,]]
+                                rows: vec![vec![
+                                    Expr::Value(number("1")),
+                                    Expr::Identifier(Ident::new("DEFAULT")),
+                                ]]
                             })
                         })
                     },
@@ -1755,7 +1758,10 @@ fn parse_merge() {
                             columns: vec![],
                             kind: MergeInsertKind::Values(Values {
                                 explicit_row: false,
-                                rows: vec![vec![Expr::Value(number("1")), Expr::Default,]]
+                                rows: vec![vec![
+                                    Expr::Value(number("1")),
+                                    Expr::Identifier(Ident::new("DEFAULT")),
+                                ]]
                             })
                         })
                     },

tests/sqlparser_common.rs

@@ -34,7 +34,7 @@ use sqlparser::dialect::{
     GenericDialect, HiveDialect, MsSqlDialect, MySqlDialect, PostgreSqlDialect, RedshiftSqlDialect,
     SQLiteDialect, SnowflakeDialect,
 };
-use sqlparser::keywords::{Keyword, ALL_KEYWORDS};
+use sqlparser::keywords::ALL_KEYWORDS;
 use sqlparser::parser::{Parser, ParserError, ParserOptions};
 use sqlparser::tokenizer::Tokenizer;
 use test_utils::{
@@ -5071,10 +5071,7 @@ fn parse_interval_dont_require_unit() {
 
 #[test]
 fn parse_interval_require_unit() {
-    let dialects = all_dialects_where(|d| {
-        d.require_interval_qualifier() && d.is_reserved_for_identifier(Keyword::INTERVAL)
-    });
-
+    let dialects = all_dialects_where(|d| d.require_interval_qualifier());
     let sql = "SELECT INTERVAL '1 DAY'";
     let err = dialects.parse_sql_statements(sql).unwrap_err();
     assert_eq!(

tests/sqlparser_postgres.rs

@@ -1352,7 +1352,7 @@ fn parse_set() {
             local: false,
             hivevar: false,
             variables: OneOrManyWithParens::One(ObjectName(vec![Ident::new("a")])),
-            value: vec![Expr::Default],
+            value: vec![Expr::Identifier(Ident::new("DEFAULT"))],
         }
     );
 
@@ -4225,7 +4225,7 @@ fn test_simple_postgres_insert_with_alias() {
                 body: Box::new(SetExpr::Values(Values {
                     explicit_row: false,
                     rows: vec![vec![
-                        Expr::Default,
+                        Expr::Identifier(Ident::new("DEFAULT")),
                         Expr::Value(Value::Number("123".to_string(), false))
                     ]]
                 })),
@@ -4288,7 +4288,7 @@ fn test_simple_postgres_insert_with_alias() {
                 body: Box::new(SetExpr::Values(Values {
                     explicit_row: false,
                     rows: vec![vec![
-                        Expr::Default,
+                        Expr::Identifier(Ident::new("DEFAULT")),
                         Expr::Value(Value::Number(
                             bigdecimal::BigDecimal::new(123.into(), 0),
                             false
@@ -4353,7 +4353,7 @@ fn test_simple_insert_with_quoted_alias() {
                 body: Box::new(SetExpr::Values(Values {
                     explicit_row: false,
                     rows: vec![vec![
-                        Expr::Default,
+                        Expr::Identifier(Ident::new("DEFAULT")),
                         Expr::Value(Value::SingleQuotedString("0123".to_string()))
                     ]]
                 })),