Skip to content

Commit 69b49c1

Browse files
authored
Use Array.values() for iteration (#1682)
Prevent issues when the user has added a function to the Array prototype
1 parent 850be4e commit 69b49c1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/Resources/queries/widget.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,7 @@
334334
const $li = $('<li />').addClass(csscls('table-list-item'));
335335
const $muted = $('<span />').addClass(css('text-muted'));
336336

337-
for (const i in values) {
337+
for (const i in values.values()) {
338338
if (showLineNumbers) {
339339
$ul.append($li.clone().append([$muted.clone().text(`${i}:`), '&nbsp;', $('<span/>').text(values[i])]));
340340
} else {
@@ -353,7 +353,7 @@
353353
const $muted = $('<span />').addClass(css('text-muted'));
354354

355355
const values = [];
356-
for (const trace of traces) {
356+
for (const trace of traces.values()) {
357357
const $span = $('<span/>').text(trace.name || trace.file);
358358
if (trace.namespace) {
359359
$span.prepend(`${trace.namespace}::`);

0 commit comments

Comments
 (0)