Skip to content

Commit ae97fca

Browse files
namenupuredanger
authored andcommitted
TDEPS-259 Improve error reporting on deps.edn spec errors
1 parent 87a170f commit ae97fca

File tree

2 files changed

+20
-1
lines changed

2 files changed

+20
-1
lines changed

src/main/clojure/clojure/tools/deps/specs.clj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@
139139
(sort-by #(- (count (:in %))))
140140
(sort-by #(- (count (:path %)))))
141141
{:keys [path pred val reason via in]} (first problems)]
142-
(str "Found: " (pr-str val) ", expected: " (if reason reason (s/abbrev pred)))))))
142+
(str "Found: " (pr-str val) ", expected: " (if reason reason (s/abbrev pred)) ", in: " (pr-str in))))))
143143

144144
;; API
145145

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
(ns clojure.tools.deps.test-specs
2+
(:require
3+
[clojure.test :refer [deftest is]]
4+
[clojure.tools.deps.specs :as specs]))
5+
6+
7+
(deftest test-explain-deps
8+
(let [deps-map {:mvn/repos {"myrepo" {:url "https://repo1.maven.org/maven2/"
9+
:snapshots true}}}]
10+
(is (= (specs/explain-deps deps-map)
11+
"Found: true, expected: map?, in: [:mvn/repos \"myrepo\" 1 :snapshots]")))
12+
13+
(let [deps-map {:tools/usage {:ns-default "some.ns"}}]
14+
(is (= (specs/explain-deps deps-map)
15+
"Found: \"some.ns\", expected: simple-symbol?, in: [:tools/usage :ns-default]"))))
16+
17+
(comment
18+
(test-explain-deps)
19+
)

0 commit comments

Comments
 (0)