Skip to content

Commit 6e66ea4

Browse files
author
John Doe
committed
refactor: fix unit-test
1 parent b8bf1de commit 6e66ea4

File tree

2 files changed

+0
-20
lines changed

2 files changed

+0
-20
lines changed

packages/utils/src/lib/performance-observer.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ export class PerformanceObserverHandle<T>
2121
#captureBuffered: boolean;
2222
#observedEntryCount: number;
2323
#flushThreshold: number;
24-
#processedEntries = new Set<string>();
2524
#sink: Sink<T, unknown>;
2625
#observer: PerformanceObserver | undefined;
2726
#closed = false;
@@ -68,23 +67,19 @@ export class PerformanceObserverHandle<T>
6867
// Process all entries
6968
entries
7069
.filter(e => e.entryType === 'mark' || e.entryType === 'measure')
71-
.filter(e => clear || !this.#processedEntries.has(e.name))
7270
.forEach(e => {
7371
const encoded = this.encode(e);
7472
encoded.forEach(item => {
7573
this.#sink.write(item);
7674
});
7775

7876
if (clear) {
79-
this.#processedEntries.delete(e.name);
8077
if (e.entryType === 'mark') {
8178
performance.clearMarks(e.name);
8279
}
8380
if (e.entryType === 'measure') {
8481
performance.clearMeasures(e.name);
8582
}
86-
} else {
87-
this.#processedEntries.add(e.name);
8883
}
8984
});
9085
}

packages/utils/src/lib/performance-observer.unit.test.ts

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -233,21 +233,6 @@ describe('PerformanceObserverHandle', () => {
233233
]);
234234
});
235235

236-
it('should skip already processed entries', () => {
237-
const observer = new PerformanceObserverHandle({
238-
sink: mockSink,
239-
encode: encodeFn,
240-
});
241-
242-
getEntriesByTypeSpy.mockReturnValue([mockMarkEntry]);
243-
244-
observer.flush();
245-
observer.flush();
246-
247-
expect(encodeFn).toHaveBeenCalledTimes(1);
248-
expect(mockSink.written).toStrictEqual(['test-mark:mark']);
249-
});
250-
251236
it('should clear processed entries when clear=true', () => {
252237
const observer = new PerformanceObserverHandle({
253238
sink: mockSink,

0 commit comments

Comments
 (0)