From ee3974e2b3ca408a405b639e6991ea5f9b1f5192 Mon Sep 17 00:00:00 2001 From: "Daniel (dB.) Doubrovkine" Date: Tue, 3 Feb 2026 08:48:31 -0500 Subject: [PATCH 1/3] Migrate Danger to use danger-pr-comment workflow Co-Authored-By: Claude Opus 4.5 --- .github/workflows/danger-comment.yml | 11 +++++++++++ .github/workflows/danger.yml | 25 ++++++++----------------- Dangerfile | 2 ++ Gemfile | 2 ++ 4 files changed, 23 insertions(+), 17 deletions(-) create mode 100644 .github/workflows/danger-comment.yml diff --git a/.github/workflows/danger-comment.yml b/.github/workflows/danger-comment.yml new file mode 100644 index 0000000..8e15cb6 --- /dev/null +++ b/.github/workflows/danger-comment.yml @@ -0,0 +1,11 @@ +name: Danger Comment + +on: + workflow_run: + workflows: [Danger] + types: [completed] + +jobs: + comment: + uses: numbata/danger-pr-comment/.github/workflows/danger-comment.yml@v0.1.0 + secrets: inherit diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index d8a4cff..bd89a88 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -1,22 +1,13 @@ ---- -name: danger +name: Danger + on: pull_request: types: [opened, reopened, edited, synchronize] + jobs: danger: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v3 - with: - fetch-depth: 0 - - name: Set up Ruby - uses: ruby/setup-ruby@v1 - with: - ruby-version: 3.4 - bundler-cache: true - - name: Run Danger - run: | - # the personal token is public, this is ok, base64 encode to avoid tripping Github - TOKEN=$(echo -n Z2hwX0xNQ3VmanBFeTBvYkZVTWh6NVNqVFFBOEUxU25abzBqRUVuaAo= | base64 --decode) - DANGER_GITHUB_API_TOKEN=$TOKEN bundle exec danger --verbose + uses: numbata/danger-pr-comment/.github/workflows/danger-run.yml@v0.1.0 + secrets: inherit + with: + ruby-version: '3.4' + bundler-cache: true diff --git a/Dangerfile b/Dangerfile index c7a9f9c..532532a 100644 --- a/Dangerfile +++ b/Dangerfile @@ -1,2 +1,4 @@ +danger.import_dangerfile(gem: 'danger-pr-comment') + changelog.check! toc.check! diff --git a/Gemfile b/Gemfile index 64e8cb6..ac5d835 100644 --- a/Gemfile +++ b/Gemfile @@ -21,7 +21,9 @@ group :development, :test do end group :test do + gem 'danger', '~> 9.5' gem 'danger-changelog', '~> 0.7.0' + gem 'danger-pr-comment', '~> 0.1.0' gem 'danger-toc', '~> 0.2.0' gem 'minitest' gem 'mocha' From 50a187be70d4403ac442e7291dd175d118f5ff2d Mon Sep 17 00:00:00 2001 From: "Daniel (dB.) Doubrovkine" Date: Tue, 3 Feb 2026 08:53:14 -0500 Subject: [PATCH 2/3] Upgrade danger-changelog to ~> 0.8.0 Fixes undefined method 'github' in dry_run mode used by danger-pr-comment workflow. Co-Authored-By: Claude Opus 4.5 --- Gemfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile b/Gemfile index ac5d835..868f6a2 100644 --- a/Gemfile +++ b/Gemfile @@ -22,7 +22,7 @@ end group :test do gem 'danger', '~> 9.5' - gem 'danger-changelog', '~> 0.7.0' + gem 'danger-changelog', '~> 0.8.0' gem 'danger-pr-comment', '~> 0.1.0' gem 'danger-toc', '~> 0.2.0' gem 'minitest' From dc21e63fa781322a2b5c7adb791cc39dd8f2f04f Mon Sep 17 00:00:00 2001 From: "Daniel (dB.) Doubrovkine" Date: Tue, 3 Feb 2026 08:56:58 -0500 Subject: [PATCH 3/3] Fix minitest compatibility with Ruby 3.x Remove `require 'minitest/unit'` which was removed in recent minitest versions, and use `Minitest::Assertions` instead of `MiniTest::Assertions`. Co-Authored-By: Claude Opus 4.5 --- test/test_helper.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/test_helper.rb b/test/test_helper.rb index f0a1d9c..413779d 100644 --- a/test/test_helper.rb +++ b/test/test_helper.rb @@ -17,14 +17,13 @@ require 'minitest/autorun' require 'minitest/pride' -require 'minitest/unit' require 'mocha/minitest' require 'json' require 'faraday' require 'faraday/request/instrumentation' -MiniTest::Assertions.class_eval do +Minitest::Assertions.class_eval do def stub_request(conn, adapter_class = Faraday::Adapter::Test, &stubs_block) adapter_handler = conn.builder.handlers.find { |h| h.klass < Faraday::Adapter } if adapter_handler