-
Notifications
You must be signed in to change notification settings - Fork 2
Open
Labels
GitlabOld issue moved over from Gitlab repositoryOld issue moved over from Gitlab repository
Description
(This issue has been imported from the Gitlab repository because it seems to not have been addressed yet)
Original Text (Issue 186)
Add Javadoc to GroupElement etc. It should state that
- for
op, we assume that right hand side to be in the right group, otherwise behavior is undefined (and may be a security risk) - document reasons why
getElement(Represenatation)should be used for untrusted Representations of GroupElements, and make clear that you would never trustGrouprepresentations from an untrusted source. (Basically, tell people not to send groups alongside their elements just so everything is neatlyStandaloneRepresentable). - Add some remarks about 3rd party serialization frameworks that use reflection magic to serialize group elements. Not a good idea. It would not be a breach of contract if each group element stored the exponents from which it was formed (i.e. you'd end up with some dlogs in your serialization). More realistically, we do have to normalize elements before sending them.
getRepresentation()makes sure that it's safe to send.
Metadata
Metadata
Assignees
Labels
GitlabOld issue moved over from Gitlab repositoryOld issue moved over from Gitlab repository