Removed text-shadow completely

The noshadows.py script now handles text-shadow also.

Fixes #153

Author: bmispelon

noshadows.py

@@ -49,16 +49,25 @@ def skip_whitespace(nodes):
     return filter(lambda node: node.type != "whitespace", nodes)
 
 
+SHADOW_CSS_PROPERTIES = {
+    "box-shadow",
+    "text-shadow",
+}
+
+
 def has_shadow(rule):
     if not rule.content:
         return False
 
     for a, b, c in tripletwise(skip_whitespace(rule.content)):
-        if isinstance(a, tokens.IdentToken) and a.value == "box-shadow":
+        if isinstance(a, tokens.IdentToken) and a.value in SHADOW_CSS_PROPERTIES:
             assert isinstance(
                 c, (tokens.IdentToken, tokens.DimensionToken, tokens.NumberToken)
             ), f"Unexpected node type {c.type}"
-            return isinstance(c, (tokens.DimensionToken, tokens.NumberToken))
+            if isinstance(c, (tokens.DimensionToken, tokens.NumberToken)):
+                return True
+
+    return False
 
 
 def find_shadow(rules):
@@ -140,8 +149,14 @@ def test_skip_whitespace(self):
     def test_has_shadow(self):
         for expected, css in [
             (True, "html {box-shadow: 10px 5px 5px red;}"),
+            (True, "html {text-shadow: 1px 1px 2px pink;}"),
+            (True, "html {text-shadow: 5px 5px #558ABB;}"),
             (False, "html {box-shadow: none;}"),
+            (False, "html {text-shadow: none;}"),
+            (True, "html {text-shadow: 5px 5px #558ABB; box-shadow: none;}"),
+            (True, "html {text-shadow: none; box-shadow: 10px 5px 5px red;}"),
             (False, "html {}"),
+            (False, "html {color: red; font-weight: bold;}"),
         ]:
             with self.subTest(css=css, expected=expected):
                 (rule,) = parse_stylesheet(css)
@@ -190,6 +205,7 @@ def test_selector_str_pseudoclass_nonstandard(self):
 // fit well with our design.
 @mixin noshadow {
     box-shadow: none;
+    text-shadow: none;
     border-radius: unset;
 }
 """

scss/_noshadows.scss

@@ -1,9 +1,10 @@
-// Generated by noshadows.py on 2024-01-18T15:52:50.928155
+// Generated by noshadows.py on 2024-01-26T15:44:23.711667
 
 // Trac uses box-shadow and text-shadow everywhere but their 90s look doesn't
 // fit well with our design.
 @mixin noshadow {
     box-shadow: none;
+    text-shadow: none;
     border-radius: unset;
 }
 
@@ -80,6 +81,7 @@ fieldset,
 #mainnav,
 div.trac-content,
 .foldable :link, .foldable :visited,
+fieldset > legend.foldable :link, fieldset > legend.foldable :visited,
 #prefs,
 pre.wiki, pre.literal-block,
 table.wiki,