fix(expert): don't crash on missing root_uri#412
Open
evnu wants to merge 1 commit intoelixir-lang:mainfrom
Open
fix(expert): don't crash on missing root_uri#412evnu wants to merge 1 commit intoelixir-lang:mainfrom
evnu wants to merge 1 commit intoelixir-lang:mainfrom
Conversation
The root_uri is allowed to be nil according to the spec. Fix elixir-lang#397.
Member
|
@katafrakt can you take a gander at this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening an
.exsfile outside of a mix project results in a crash as described in #397. As described inGenLSP.Structures.InitializeParams, the root_uri is allowed to be nil and must be handled accordingly. To avoid crashing on start up in such a case, this PR drops setting the workspace URI in this case. While this doesn't makeexpertfully functional in single-file mode, with this change allows debugging further problems in the case ofroot_urinot being set.Fix #397.