fix: support multiple elixir versions on multiroot projects#413
Open
fix: support multiple elixir versions on multiroot projects#413
Conversation
doorgan
force-pushed
the
doorgan/multiroot-ex-versions
branch
3 times, most recently
from
cd60477 to
3a54178
Compare
doorgan
force-pushed
the
doorgan/multiroot-ex-versions
branch
from
3a54178 to
245f890
Compare
Collaborator
Author
|
@giddie could you verify if this PR works in your setup? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#344 fixed the case when SHELL isn't available and we can't use it to find elixir, but apparently that change causes us to only be able to find a single elixir version in a multiroot project, so we need the shell approach too.
This PR reintroduces the shell approach, and adds the #344 as a fallback if SHELL is not available.
Testing this I also found that having multiple projects with different elixir versions made them download different hex versions, and that sporadically caused issues on my tests, so I had to make expert remove more environment variables than we did before.
Also on windows I am now using mise, which has the elixir shim as
elixir.cmdand Expert was struggling to find it even if it was in the path.