refactor(content_management): simplify country dropdown pagination

- Remove background fetching mechanism for countries list
- Load all countries at once in CreateHeadlineBloc initialization
- Remove unnecessary country-related state properties from CreateHeadlineState
- Update CreateHeadlinePage to use pre-loaded countries list
- Remove _FetchNextCountryPage event and related handling

Author: fulleni

lib/content_management/bloc/create_headline/create_headline_bloc.dart

@@ -8,10 +8,6 @@ import 'package:uuid/uuid.dart';
 part 'create_headline_event.dart';
 part 'create_headline_state.dart';
 
-final class _FetchNextCountryPage extends CreateHeadlineEvent {
-  const _FetchNextCountryPage();
-}
-
 /// A BLoC to manage the state of creating a new headline.
 class CreateHeadlineBloc
     extends Bloc<CreateHeadlineEvent, CreateHeadlineState> {
@@ -20,12 +16,11 @@ class CreateHeadlineBloc
     required DataRepository<Headline> headlinesRepository,
     required DataRepository<Source> sourcesRepository,
     required DataRepository<Topic> topicsRepository,
-    required DataRepository<Country> countriesRepository,
-  }) : _headlinesRepository = headlinesRepository,
-       _sourcesRepository = sourcesRepository,
-       _topicsRepository = topicsRepository,
-       _countriesRepository = countriesRepository,
-       super(const CreateHeadlineState()) {
+    required List<Country> countries,
+  })  : _headlinesRepository = headlinesRepository,
+        _sourcesRepository = sourcesRepository,
+        _topicsRepository = topicsRepository,
+        super(CreateHeadlineState(countries: countries)) {
     on<CreateHeadlineDataLoaded>(_onDataLoaded);
     on<CreateHeadlineTitleChanged>(_onTitleChanged);
     on<CreateHeadlineExcerptChanged>(_onExcerptChanged);
@@ -36,13 +31,11 @@ class CreateHeadlineBloc
     on<CreateHeadlineCountryChanged>(_onCountryChanged);
     on<CreateHeadlineStatusChanged>(_onStatusChanged);
     on<CreateHeadlineSubmitted>(_onSubmitted);
-    on<_FetchNextCountryPage>(_onFetchNextCountryPage);
   }
 
   final DataRepository<Headline> _headlinesRepository;
   final DataRepository<Source> _sourcesRepository;
   final DataRepository<Topic> _topicsRepository;
-  final DataRepository<Country> _countriesRepository;
   final _uuid = const Uuid();
 
   Future<void> _onDataLoaded(
@@ -65,26 +58,13 @@ class CreateHeadlineBloc
       final sources = (sourcesResponse as PaginatedResponse<Source>).items;
       final topics = (topicsResponse as PaginatedResponse<Topic>).items;
 
-      final countriesResponse = await _countriesRepository.readAll(
-        sort: [const SortOption('name', SortOrder.asc)],
-      );
-
       emit(
         state.copyWith(
           status: CreateHeadlineStatus.initial,
           sources: sources,
           topics: topics,
-          countries: countriesResponse.items,
-          countriesCursor: countriesResponse.cursor,
-          countriesHasMore: countriesResponse.hasMore,
         ),
       );
-
-      // After the initial page of countries is loaded, start a background
-      // process to fetch all remaining pages.
-      if (state.countriesHasMore) {
-        add(const _FetchNextCountryPage());
-      }
     } on HttpException catch (e) {
       emit(state.copyWith(status: CreateHeadlineStatus.failure, exception: e));
     } catch (e) {
@@ -159,49 +139,6 @@ class CreateHeadlineBloc
   }
 
   // --- Background Data Fetching for Dropdown ---
-  // The DropdownButtonFormField widget does not natively support on-scroll
-  // pagination. To preserve UI consistency across the application, this BLoC
-  // employs an event-driven background fetching mechanism.
-  //
-  // After the first page of items is loaded, a chain of events is initiated
-  // to progressively fetch all remaining pages. This process is throttled
-  // and runs in the background, ensuring the UI remains responsive while the
-  // full list of dropdown options is populated over time.
-  Future<void> _onFetchNextCountryPage(
-    _FetchNextCountryPage event,
-    Emitter<CreateHeadlineState> emit,
-  ) async {
-    if (!state.countriesHasMore || state.countriesIsLoadingMore) return;
-
-    try {
-      emit(state.copyWith(countriesIsLoadingMore: true));
-
-      // ignore: inference_failure_on_instance_creation
-      await Future.delayed(const Duration(milliseconds: 400));
-
-      final nextCountries = await _countriesRepository.readAll(
-        pagination: PaginationOptions(cursor: state.countriesCursor),
-        sort: [const SortOption('name', SortOrder.asc)],
-      );
-
-      emit(
-        state.copyWith(
-          countries: List.of(state.countries)..addAll(nextCountries.items),
-          countriesCursor: nextCountries.cursor,
-          countriesHasMore: nextCountries.hasMore,
-          countriesIsLoadingMore: false,
-        ),
-      );
-
-      if (nextCountries.hasMore) {
-        add(const _FetchNextCountryPage());
-      }
-    } catch (e) {
-      emit(state.copyWith(countriesIsLoadingMore: false));
-      // Optionally log the error without disrupting the user
-    }
-  }
-
   Future<void> _onSubmitted(
     CreateHeadlineSubmitted event,
     Emitter<CreateHeadlineState> emit,

lib/content_management/bloc/create_headline/create_headline_state.dart

@@ -32,9 +32,6 @@ final class CreateHeadlineState extends Equatable {
     this.sources = const [],
     this.topics = const [],
     this.countries = const [],
-    this.countriesHasMore = true,
-    this.countriesIsLoadingMore = false,
-    this.countriesCursor,
     this.contentStatus = ContentStatus.active,
     this.exception,
     this.createdHeadline,
@@ -51,9 +48,6 @@ final class CreateHeadlineState extends Equatable {
   final List<Source> sources;
   final List<Topic> topics;
   final List<Country> countries;
-  final bool countriesHasMore;
-  final bool countriesIsLoadingMore;
-  final String? countriesCursor;
   final ContentStatus contentStatus;
   final HttpException? exception;
   final Headline? createdHeadline;
@@ -80,9 +74,6 @@ final class CreateHeadlineState extends Equatable {
     List<Source>? sources,
     List<Topic>? topics,
     List<Country>? countries,
-    bool? countriesHasMore,
-    bool? countriesIsLoadingMore,
-    String? countriesCursor,
     ContentStatus? contentStatus,
     HttpException? exception,
     Headline? createdHeadline,
@@ -99,10 +90,6 @@ final class CreateHeadlineState extends Equatable {
       sources: sources ?? this.sources,
       topics: topics ?? this.topics,
       countries: countries ?? this.countries,
-      countriesHasMore: countriesHasMore ?? this.countriesHasMore,
-      countriesIsLoadingMore:
-          countriesIsLoadingMore ?? this.countriesIsLoadingMore,
-      countriesCursor: countriesCursor ?? this.countriesCursor,
       contentStatus: contentStatus ?? this.contentStatus,
       exception: exception,
       createdHeadline: createdHeadline ?? this.createdHeadline,
@@ -122,9 +109,6 @@ final class CreateHeadlineState extends Equatable {
     sources,
     topics,
     countries,
-    countriesHasMore,
-    countriesIsLoadingMore,
-    countriesCursor,
     contentStatus,
     exception,
     createdHeadline,

lib/content_management/view/create_headline_page.dart

@@ -20,12 +20,16 @@ class CreateHeadlinePage extends StatelessWidget {
 
   @override
   Widget build(BuildContext context) {
+    // The list of all countries is fetched once and cached in the
+    // ContentManagementBloc. We read it here and provide it to the
+    // CreateHeadlineBloc.
+    final allCountries = context.read<ContentManagementBloc>().state.allCountries;
     return BlocProvider(
       create: (context) => CreateHeadlineBloc(
         headlinesRepository: context.read<DataRepository<Headline>>(),
         sourcesRepository: context.read<DataRepository<Source>>(),
         topicsRepository: context.read<DataRepository<Topic>>(),
-        countriesRepository: context.read<DataRepository<Country>>(),
+        countries: allCountries,
       )..add(const CreateHeadlineDataLoaded()),
       child: const _CreateHeadlineView(),
     );
@@ -220,9 +224,6 @@ class _CreateHeadlineViewState extends State<_CreateHeadlineView> {
                       decoration: InputDecoration(
                         labelText: l10n.countryName,
                         border: const OutlineInputBorder(),
-                        helperText: state.countriesIsLoadingMore
-                            ? l10n.loadingFullList
-                            : null,
                       ),
                       items: [
                         DropdownMenuItem(value: null, child: Text(l10n.none)),
@@ -249,11 +250,9 @@ class _CreateHeadlineViewState extends State<_CreateHeadlineView> {
                           ),
                         ),
                       ],
-                      onChanged: state.countriesIsLoadingMore
-                          ? null
-                          : (value) => context.read<CreateHeadlineBloc>().add(
-                              CreateHeadlineCountryChanged(value),
-                            ),
+                      onChanged: (value) => context
+                          .read<CreateHeadlineBloc>()
+                          .add(CreateHeadlineCountryChanged(value)),
                     ),
                     const SizedBox(height: AppSpacing.lg),
                     DropdownButtonFormField<ContentStatus>(