Assertion error: splitOnDash.length <= 2

[rrousselGit]

Follow up to #9414

Whole working on devtool extensions using a non-stable Flutter channel, this keeps appearing.

splitOnDash.length <= 2
"version: 3.41.0-1.0.pre-173

I think the issue is fairly simple. The assertion assumes .pre.173, but the reality is .pre-173

This is not blocking development in any way, so it is very low priority to me.

[elliette]

I will publish devtools_shared, sorry for the inconvenience here!

[rrousselGit]

Looking at the current source, I don't think that the issue has been fixed:

devtools/packages/devtools_shared/lib/src/utils/semantic_version.dart

Line 24 in 95eda32

assert(splitOnDash.length <= 2, 'version: $version');

The code has changed, but 3.41.0-1.0.pre-173 would still be illegal based on that assert right?

[elliette]

We "sanitize" the version before that assert to change 3.41.0-1.0.pre-173 to 3.41.0-1.0.pre.173:

devtools/packages/devtools_shared/lib/src/utils/semantic_version.dart

Lines 120 to 122 in 95eda32

	// Canonicalize the version string to convert any prerelease suffix with a
	// "-" to a prerelease suffix with a ".".
	final canonicalized = _canonicalizeVersion(versionString);

I think all that's needed is to publish! I will do that early next week because I don't like publishing on a Friday. Will update here when the new devtools_shared is up

[rrousselGit]

No worries. Nothing urgent :)