From a3ba096c1d3abbeb22557fc2e8edd27939baf433 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Fri, 30 Jan 2026 13:33:21 -0800 Subject: [PATCH 1/3] Fix debugger panel test --- .../live_connection/debugger_panel_test.dart | 50 ++++++++++--------- 1 file changed, 26 insertions(+), 24 deletions(-) diff --git a/packages/devtools_app/integration_test/test/live_connection/debugger_panel_test.dart b/packages/devtools_app/integration_test/test/live_connection/debugger_panel_test.dart index 58b5a097344..c05059cc477 100644 --- a/packages/devtools_app/integration_test/test/live_connection/debugger_panel_test.dart +++ b/packages/devtools_app/integration_test/test/live_connection/debugger_panel_test.dart @@ -62,30 +62,32 @@ void main() { isTrue, ); - logStatus('Navigating to line 57...'); + logStatus('Navigating to line 55...'); - await goToLine(tester, lineNumber: 57); + await goToLine(tester, lineNumber: 55); - logStatus('looking for line 57'); + logStatus('looking for line 55'); - // Look for the line 57 gutter item: - final gutter57Finder = findGutterItemWithText('57'); - expect(gutter57Finder, findsOneWidget); + // Look for the line 55 gutter item: + final gutter55Finder = findGutterItemWithText('55'); + expect(gutter55Finder, findsOneWidget); - // Look for the line 57 line item: - final line57Finder = findLineItemWithText("print('Hello!');"); - expect(line57Finder, findsOneWidget); + // Look for the line 55 line item: + final line55Finder = findLineItemWithText("print('Hello!');"); + expect(line55Finder, findsOneWidget); + + await tester.pumpAndSettle(safePumpDuration); // Verify that the gutter item and line item are aligned: expect( - areHorizontallyAligned(gutter57Finder, line57Finder, tester: tester), + areHorizontallyAligned(gutter55Finder, line55Finder, tester: tester), isTrue, ); logStatus('setting a breakpoint'); // Tap on the gutter for the line to set a breakpoint: - await tester.tap(gutter57Finder); + await tester.tap(gutter55Finder); await tester.pumpAndSettle(longPumpDuration); logStatus('performing a hot restart'); @@ -93,42 +95,42 @@ void main() { await tester.tap(find.byType(HotRestartButton)); await tester.pumpAndSettle(longPumpDuration); - logStatus('Navigating to line 30...'); + logStatus('Navigating to line 28...'); - await goToLine(tester, lineNumber: 30); + await goToLine(tester, lineNumber: 28); - logStatus('looking for line 30'); + logStatus('looking for line 28'); // Look for the line 30 gutter item: - final gutter30Finder = findGutterItemWithText('30'); - expect(gutter30Finder, findsOneWidget); + final gutter28Finder = findGutterItemWithText('28'); + expect(gutter28Finder, findsOneWidget); - // Look for the line 30 line item: - final line30Finder = findLineItemWithText('count++;'); - expect(line30Finder, findsOneWidget); + // Look for the line 28 line item: + final line28Finder = findLineItemWithText('count++;'); + expect(line28Finder, findsOneWidget); // Verify that the gutter item and line item are aligned: expect( - areHorizontallyAligned(gutter30Finder, line30Finder, tester: tester), + areHorizontallyAligned(gutter28Finder, line28Finder, tester: tester), isTrue, ); logStatus('setting a breakpoint'); // Tap on the gutter for the line to set a breakpoint: - await tester.tap(gutter30Finder); + await tester.tap(gutter28Finder); await tester.pumpAndSettle(longPumpDuration); logStatus('verifying breakpoints'); - final bpSetBeforeRestart = findBreakpointWithText('main.dart:57'); + final bpSetBeforeRestart = findBreakpointWithText('main.dart:55'); expect(bpSetBeforeRestart, findsOneWidget); logStatus('pausing at breakpoint'); final topFrameFinder = findStackFrameWithText('incrementCounter'); expect(topFrameFinder, findsOneWidget); - expect(isLineFocused(line30Finder), isTrue); + expect(isLineFocused(line28Finder), isTrue); final countVariableFinder = find.textContaining('count:'); expect(countVariableFinder, findsOneWidget); @@ -237,4 +239,4 @@ Finder findStackFrameWithText(String text) => find.descendant( Finder findBreakpointWithText(String text) => find.descendant( of: find.byType(Breakpoints), matching: find.richTextContaining(text), -); +); \ No newline at end of file From 8a9388b939810fcd18ceb12ab934602e52db7300 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Fri, 30 Jan 2026 14:52:38 -0800 Subject: [PATCH 2/3] Re-enable test --- packages/devtools_app/integration_test/run_tests.dart | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/devtools_app/integration_test/run_tests.dart b/packages/devtools_app/integration_test/run_tests.dart index c66db56edf7..099a61a1f6f 100644 --- a/packages/devtools_app/integration_test/run_tests.dart +++ b/packages/devtools_app/integration_test/run_tests.dart @@ -36,8 +36,6 @@ final _disabledTestsForDevice = >{ 'export_snapshot_test.dart', // https://github.com/flutter/devtools/issues/9639 'network_screen_test.dart', - // https://github.com/flutter/devtools/issues/9640 - 'debugger_panel_test.dart', // https://github.com/flutter/devtools/issues/9641 'devtools_extensions_test.dart', // https://github.com/flutter/devtools/issues/9642 From 16296d4a3dea9f1fa939ad21803d89a3eb8a53a1 Mon Sep 17 00:00:00 2001 From: Elliott Brooks <21270878+elliette@users.noreply.github.com> Date: Fri, 30 Jan 2026 14:56:14 -0800 Subject: [PATCH 3/3] Add new line back --- .../test/live_connection/debugger_panel_test.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/devtools_app/integration_test/test/live_connection/debugger_panel_test.dart b/packages/devtools_app/integration_test/test/live_connection/debugger_panel_test.dart index c05059cc477..5321b55ba02 100644 --- a/packages/devtools_app/integration_test/test/live_connection/debugger_panel_test.dart +++ b/packages/devtools_app/integration_test/test/live_connection/debugger_panel_test.dart @@ -239,4 +239,4 @@ Finder findStackFrameWithText(String text) => find.descendant( Finder findBreakpointWithText(String text) => find.descendant( of: find.byType(Breakpoints), matching: find.richTextContaining(text), -); \ No newline at end of file +);