Skip to content

Commit f09caa6

Browse files
committed
fix: Logic while exporting session CSV and add tests
1 parent 3d2a1eb commit f09caa6

File tree

2 files changed

+20
-4
lines changed

2 files changed

+20
-4
lines changed

app/api/helpers/csv_jobs_util.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def export_sessions_csv(sessions):
6868
column.append(session.level)
6969
column.append(session.state)
7070
column.append(session.session_type if session.session_type else '')
71-
column.append(len(session.long_abstract))
71+
column.append(len(session.long_abstract) if session.long_abstract else None)
7272
rows.append(column)
7373

7474
return rows

tests/all/integration/api/helpers/test_csv_jobs_util.py

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,30 @@ def test_export_attendees_csv(self):
3737
self.assertEqual(field_data[1][3], common.string_)
3838
self.assertEqual(field_data[1][5], 'user0@example.com')
3939

40+
def _test_export_session_csv(self, test_session=None):
41+
with app.test_request_context():
42+
if not test_session:
43+
test_session = SessionFactory()
44+
field_data = export_sessions_csv([test_session])
45+
session_row = field_data[1]
46+
47+
self.assertEqual(session_row[0], 'example (accepted)')
48+
self.assertEqual(session_row[7], 'accepted')
49+
4050
def test_export_sessions_csv(self):
4151
"""Method to check sessions data export"""
4252

53+
with app.test_request_context():
54+
self._test_export_session_csv()
55+
56+
def test_export_sessions_none_csv(self):
57+
"""Method to check sessions data export with no abstract"""
58+
4359
with app.test_request_context():
4460
test_session = SessionFactory()
45-
field_data = export_sessions_csv([test_session])
46-
self.assertEqual(field_data[1][6], common.int_)
47-
self.assertEqual(field_data[1][7], 'accepted')
61+
test_session.long_abstract = None
62+
test_session.level = None
63+
self._test_export_session_csv(test_session)
4864

4965
def test_export_speakers_csv(self):
5066
"""Method to check speakers data export"""

0 commit comments

Comments
 (0)