Skip to content

Commit 4413ddb

Browse files
committed
commit: document that $command.signoff will not be added
Every now and then we see this coming up on the list. Let's help new contributors who are not aware of past discussions by clearly documenting our past consensus. Helped-by: brian m. carlson <sandals@crustytoothpaste.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 9a2fb14 commit 4413ddb

File tree

2 files changed

+27
-0
lines changed

2 files changed

+27
-0
lines changed

Documentation/gitfaq.adoc

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,21 @@ Windows would be the configuration `"C:\Program Files\Vim\gvim.exe" --nofork`,
8383
which quotes the filename with spaces and specifies the `--nofork` option to
8484
avoid backgrounding the process.
8585

86+
[[sign-off]]
87+
Why not have `commit.signoff` and other configuration variables?::
88+
As it makes it harder to argue against one who tells the court
89+
"the log message of the commit ends with a `Signed-off-by`
90+
trailer by person X, but it is very plausible that it was done
91+
by inertia without person X really intending to certify what
92+
DCO says, hence the `Signed-off-by` trailer is meaningless", if
93+
we add more publicized ways to add sign-off automatically. Git
94+
does not, and will not, have a configuration variable to
95+
enable the `--signoff` command line option it by default.
96+
+
97+
There exists `format.signoff`, but that is a historical mistake, and
98+
it is not an excuse to pile on more mistakes of the same kind on top.
99+
100+
86101
Credentials
87102
-----------
88103

Documentation/signoff-option.adoc

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,3 +16,15 @@ endif::git-commit[]
1616
+
1717
The `--no-signoff` option can be used to countermand an earlier `--signoff`
1818
option on the command line.
19+
+
20+
As it makes it harder to argue against one who tells the court "the
21+
log message of the commit ends with a `Signed-off-by` trailer by person
22+
X, but it is very plausible that it was done by inertia without person
23+
X really intending to certify what DCO says, hence the `Signed-off-by`
24+
trailer is meaningless", if we add more publicized ways to add
25+
sign-off automatically. Git does not, and will not, have a
26+
configuration variable to enable the `--signoff` command line option
27+
it by default.
28+
+
29+
There exists `format.signoff`, but that is a historical mistake, and
30+
it is not an excuse to pile on more mistakes of the same kind on top.

0 commit comments

Comments
 (0)