Skip to content

Commit 7929502

Browse files
Fix nil pointer dereference in completion handler
The CompleteParams.Context field is optional (marked omitempty) and can be nil when clients don't send it. The code was accessing Context.Arguments directly without checking if Context was nil first, causing a panic. This fix adds a nil check for Context before accessing Arguments.
1 parent ab23070 commit 7929502

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

pkg/github/repository_resource_completions.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,10 @@ func RepositoryResourceCompletionHandler(getClient GetClientFn) func(ctx context
3333

3434
argName := req.Params.Argument.Name
3535
argValue := req.Params.Argument.Value
36-
resolved := req.Params.Context.Arguments
37-
if resolved == nil {
36+
var resolved map[string]string
37+
if req.Params.Context != nil && req.Params.Context.Arguments != nil {
38+
resolved = req.Params.Context.Arguments
39+
} else {
3840
resolved = map[string]string{}
3941
}
4042

0 commit comments

Comments
 (0)