From cf50fd2d3d999c4ca8f0423b5af5e5ab19d3d0c3 Mon Sep 17 00:00:00 2001 From: Nicolas Ayral Seydoux Date: Tue, 25 Nov 2025 13:21:58 +0100 Subject: [PATCH 1/2] Add Node 24 support --- .github/workflows/ci.yml | 4 ++-- .github/workflows/e2e-node.yml | 2 +- package-lock.json | 2 +- package.json | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 13f527c..9ef12e7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,7 @@ jobs: matrix: # We test against different OSes, because the build toolchain has OS-specific dependencies. os: ["ubuntu-latest", "windows-latest", "macos-latest"] - node-version: ["22.x", "20.x"] + node-version: ["20.x", "22.x", "24.x"] steps: - uses: actions/checkout@v6 - uses: actions/setup-node@v6 @@ -30,7 +30,7 @@ jobs: - run: npm run test # Upload coverage for sonarcube (only matching OS and one node version required) - uses: actions/upload-artifact@v5 - if: ${{ matrix.node-version == '22.x' }} + if: ${{ matrix.node-version == '24.x' }} with: name: code-coverage-${{ matrix.os }}-${{matrix.node-version}} path: coverage/ diff --git a/.github/workflows/e2e-node.yml b/.github/workflows/e2e-node.yml index 74c5002..fb42370 100644 --- a/.github/workflows/e2e-node.yml +++ b/.github/workflows/e2e-node.yml @@ -19,7 +19,7 @@ jobs: strategy: matrix: os: [ubuntu-latest] - node-version: ["22.x", "20.x"] + node-version: ["20.x", "22.x", "24.x"] environment-name: ["ESS PodSpaces", "ESS Release-2-3", "ESS Next"] experimental: [false] steps: diff --git a/package-lock.json b/package-lock.json index 4bb1cee..95ecce5 100644 --- a/package-lock.json +++ b/package-lock.json @@ -29,7 +29,7 @@ "typescript": "^5.9.3" }, "engines": { - "node": "^20.0.0 || ^22.0.0" + "node": "^20.0.0 || ^22.0.0 || ^24.0.0" } }, "node_modules/@aashutoshrathi/word-wrap": { diff --git a/package.json b/package.json index e971c04..11c2d6d 100644 --- a/package.json +++ b/package.json @@ -64,6 +64,6 @@ "typescript": "^5.9.3" }, "engines": { - "node": "^20.0.0 || ^22.0.0" + "node": "^20.0.0 || ^22.0.0 || ^24.0.0" } } From 6d5d94faefb537075981f8792c2a95bdeda34adf Mon Sep 17 00:00:00 2001 From: Nicolas Ayral Seydoux Date: Tue, 25 Nov 2025 13:29:01 +0100 Subject: [PATCH 2/2] Fix sonar artifact name --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9ef12e7..9abaebd 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -47,7 +47,7 @@ jobs: fetch-depth: 0 - uses: actions/download-artifact@v6 with: - name: code-coverage-ubuntu-latest-22.x + name: code-coverage-ubuntu-latest-24.x path: coverage/ - uses: SonarSource/sonarqube-scan-action@fd88b7d7ccbaefd23d8f36f73b59db7a3d246602 # v5 env: