Optimize current workspace checks

Author: joshuajaco

lib/rules/no-cross-imports.js

@@ -106,6 +106,8 @@ module.exports.create = (context) => {
     workspaces,
     context.getFilename(),
     ({ node, value, path, currentWorkspace }) => {
+      if (isSubPath(currentWorkspace.location, path)) return;
+
       forbidden
         .filter(
           filterSharedPackagesInCurrentScope(
@@ -117,7 +119,6 @@ module.exports.create = (context) => {
         .forEach(({ package: { name }, location }) => {
           if (
             name !== currentWorkspace.package.name &&
-            !isSubPath(currentWorkspace.location, path) &&
             (isWorkspacePath(name, value) || isSubPath(location, path))
           ) {
             context.report({

lib/rules/no-relative-imports.js

@@ -23,12 +23,13 @@ module.exports.create = (context) => {
     workspaces,
     context.getFilename(),
     ({ node, path, start, end, currentWorkspace }) => {
+      if (isSubPath(currentWorkspace.location, path)) return;
+
       workspaces.forEach(({ package: { name }, location }) => {
         if (
           name !== path &&
           name !== currentWorkspace.package.name &&
-          isSubPath(location, path) &&
-          !isSubPath(currentWorkspace.location, path)
+          isSubPath(location, path)
         ) {
           context.report({
             node,

lib/rules/require-dependency.js

@@ -28,6 +28,8 @@ module.exports.create = (context) => {
     workspaces,
     context.getFilename(),
     ({ node, value, path, currentWorkspace }) => {
+      if (isSubPath(currentWorkspace.location, path)) return;
+
       workspaces.forEach(({ package: { name }, location }) => {
         const {
           dependencies = {},
@@ -38,7 +40,6 @@ module.exports.create = (context) => {
 
         if (
           name !== currentWorkspace.package.name &&
-          !isSubPath(currentWorkspace.location, path) &&
           (isWorkspacePath(name, value) || isSubPath(location, path)) &&
           !Object.keys(dependencies).includes(name) &&
           !Object.keys(peerDependencies).includes(name) &&