AC-14557:: False positives in the backward-incompatible changes report (SVC)

Author: cod62627

src/Analyzer/ClassMethodAnalyzer.php

@@ -266,8 +266,24 @@ protected function reportChanged($report, $contextBefore, $contextAfter, $method
                         $beforeParam = $paramsBefore[$i];
                         $afterParam = $paramsAfter[$i];
 
+                     //   $beforeParam->
+
                         $beforeType = $beforeParam->type;
                         $afterType = $afterParam->type;
+                      //  $beforeParam->default->
+
+                        $beforeNullable = $this->isNullable($beforeType);
+                        $afterNullable = $this->isNullable($afterType);
+
+                        $beforeTypeName = $this->getTypeName($beforeType);
+                        $afterTypeName = $this->getTypeName($afterType);
+
+                        if ($beforeNullable !== $afterNullable && $beforeTypeName === $afterTypeName) {
+                            echo "️Nullable type change detected for parameter \${$beforeParam->var->name}:\n";
+                            echo "Before: " . ($beforeNullable ? '?' : '') . $beforeTypeName . "\n";
+                            echo "After: " . ($afterNullable ? '?' : '') . $afterTypeName . "\n";
+                        }
+
 
                         $beforeDefaultIsNull = isset($beforeParam->default) && $beforeParam->default->value === null;
                         print_r("Default value: $beforeParam->default->value\n");
@@ -421,6 +437,19 @@ protected function reportChanged($report, $contextBefore, $contextAfter, $method
         }
     }
 
+    private function isNullable($type): bool {
+        return $type instanceof \PhpParser\Node\NullableType;
+    }
+
+    private function getTypeName($type): ?string {
+        if ($type instanceof \PhpParser\Node\NullableType) {
+            return $type->type instanceof \PhpParser\Node\Identifier ? $type->type->name : null;
+        } elseif ($type instanceof \PhpParser\Node\Identifier) {
+            return $type->name;
+        }
+        return null; // For union types or no type
+    }
+
     /**
      * Checks if return type declaration or annotation was changed
      *