AC-14557:: False positives in the backward-incompatible changes report (SVC)

Author: cod62627

src/Analyzer/ClassMethodAnalyzer.php

@@ -41,6 +41,7 @@
 use PHPSemVerChecker\Operation\ClassMethodParameterTypingRemoved;
 use PHPSemVerChecker\Operation\ClassMethodRemoved;
 use PHPSemVerChecker\Report\Report;
+use Magento\SemanticVersionChecker\Operation\ClassMethodParameterTypingChangedNullable;
 
 /**
  * Class method analyzer.
@@ -258,29 +259,26 @@ protected function reportChanged($report, $contextBefore, $contextAfter, $method
                     $report->add($this->context, $data);
                     $signatureChanged = true;
                 } elseif ($signatureChanges['parameter_typing_changed']) {
-                    $paramBefore = $paramsBefore[$signatureChanges['changed_param_index']];
-                    $paramAfter = $paramsAfter[$signatureChanges['changed_param_index']];
 
                     if (
-                        $paramAfter->type instanceof NullableType &&
-                        !($paramBefore->type instanceof NullableType)
+                        $signatureChanges['parameter_nullable_type_added'] ||
+                        $signatureChanges['parameter_nullable_type_removed']
                     ) {
-                        $data = new \Magento\SemanticVersionChecker\Operation\ClassMethodParameterTypingChangedNullable(
+                        $data = new ClassMethodParameterTypingChangedNullable(
                             $this->context,
                             $this->fileAfter,
                             $contextAfter,
                             $methodAfter
                         );
-                        $report->add($this->context, $data);
                     } else {
                         $data = new ClassMethodParameterTypingChanged(
                             $this->context,
                             $this->fileAfter,
                             $contextAfter,
                             $methodAfter
                         );
-                        $report->add($this->context, $data);
                     }
+                    $report->add($this->context, $data);
                     $signatureChanged = true;
                 }
 

src/Comparator/Signature.php

@@ -130,26 +130,39 @@ public static function analyze(array $parametersA, array $parametersB): array
         $changes = array_merge($changes, [
             'parameter_typing_added'          => false,
             'parameter_typing_removed'        => false,
-            'parameter_typing_changed'        => false
+            'parameter_typing_changed'        => false,
+            'parameter_nullable_type_added' => false,
+            'parameter_nullable_type_removed' => false,
+            'changed_param_index' => 0
         ]);
         $lengthA = count($parametersA);
         $lengthB = count($parametersB);
 
         $iterations = min($lengthA, $lengthB);
         for ($i = 0; $i < $iterations; ++$i) {
+
+            $typeBefore = $parametersA[$i]->type;
+            $typeAfter = $parametersB[$i]->type;
             // Re-implement type checking to handle type changes as a single operation instead of both add and remove
             if (Type::get($parametersA[$i]->type) !== Type::get($parametersB[$i]->type)) {
                 // This section changed from parent::analyze() to handle typing changes
                 if ($parametersA[$i]->type !== null && $parametersB[$i]->type !== null) {
                     $changes['parameter_typing_changed'] = true;
+                    // Custom: detect nullable added
+                    if ($typeBefore instanceof \PhpParser\Node\NullableType && !$typeAfter instanceof \PhpParser\Node\NullableType) {
+                        $changes['parameter_nullable_type_removed'] = true;
+                        $changes['changed_param_index'] = $i;
+                    } elseif (!$typeBefore instanceof \PhpParser\Node\NullableType && $typeAfter instanceof \PhpParser\Node\NullableType) {
+                        $changes['parameter_nullable_type_added'] = true;
+                        $changes['changed_param_index'] = $i;
+                    }
                 } elseif ($parametersA[$i]->type !== null) {
                     $changes['parameter_typing_removed'] = true;
                 } elseif ($parametersB[$i]->type !== null) {
                     $changes['parameter_typing_added'] = true;
                 }
             }
         }
-
         return $changes;
     }
 }