AC-14557:: False positives in the backward-incompatible changes report (SVC)

Author: cod62627

src/Analyzer/ClassMethodAnalyzer.php

@@ -259,10 +259,7 @@ protected function reportChanged($report, $contextBefore, $contextAfter, $method
                     $report->add($this->context, $data);
                     $signatureChanged = true;
                 } elseif ($signatureChanges['parameter_typing_changed']) {
-                    if (
-                        $signatureChanges['parameter_nullable_type_added']
-                        || $signatureChanges['parameter_nullable_type_removed']
-                    ) {
+                    if ($signatureChanges['parameter_nullable_type_added']) {
                         $data = new ClassMethodParameterTypingChangedNullable(
                             $this->context,
                             $this->fileAfter,
@@ -468,8 +465,7 @@ private function isReturnsEqualByNullability(ClassMethod $before, ClassMethod $a
      */
     private function getDocReturnDeclaration(ClassMethod $method)
     {
-        if (
-            ($parsedComment = $method->getAttribute('docCommentParsed'))
+        if (($parsedComment = $method->getAttribute('docCommentParsed'))
             && isset($parsedComment['return'])
         ) {
             if ($parsedComment['return'][0] instanceof NullableType) {

src/Comparator/Signature.php

@@ -147,14 +147,8 @@ public static function analyze(array $parametersA, array $parametersB): array
                 if ($parametersA[$i]->type !== null && $parametersB[$i]->type !== null) {
                     $changes['parameter_typing_changed'] = true;
                     // Custom: detect nullable added
-                    if (
-                        $typeBefore instanceof \PhpParser\Node\NullableType
+                    if ($typeBefore instanceof \PhpParser\Node\NullableType
                         && !$typeAfter instanceof \PhpParser\Node\NullableType
-                    ) {
-                        $changes['parameter_nullable_type_removed'] = true;
-                    } elseif (
-                        !$typeBefore instanceof \PhpParser\Node\NullableType
-                        && $typeAfter instanceof \PhpParser\Node\NullableType
                     ) {
                         $changes['parameter_nullable_type_added'] = true;
                     }