AC-14557:: False positives in the backward-incompatible changes report (SVC)

Author: cod62627

composer.json

@@ -13,7 +13,7 @@
         "laminas/laminas-stdlib": "^3.18",
         "nikic/php-parser": "^4.19",
         "phpstan/phpdoc-parser": "^0.5.5",
-        "sabre/xml": "~4.0.6",
+        "sabre/xml": "~4.0.5",
         "symfony/console": "~6.4.17",
         "symfony/string": "~6.4.15",
         "tomzx/php-semver-checker": "^0.16.0",

composer.lock

@@ -260,8 +260,7 @@ protected function reportChanged($report, $contextBefore, $contextAfter, $method
                     $signatureChanged = true;
                 } elseif ($signatureChanges['parameter_typing_changed']) {
 
-                    if (
-                        $signatureChanges['parameter_nullable_type_added'] ||
+                    if ($signatureChanges['parameter_nullable_type_added'] ||
                         $signatureChanges['parameter_nullable_type_removed']
                     ) {
                         $data = new ClassMethodParameterTypingChangedNullable(
@@ -469,8 +468,7 @@ private function isReturnsEqualByNullability(ClassMethod $before, ClassMethod $a
      */
     private function getDocReturnDeclaration(ClassMethod $method)
     {
-        if (
-            ($parsedComment = $method->getAttribute('docCommentParsed'))
+        if (($parsedComment = $method->getAttribute('docCommentParsed'))
             && isset($parsedComment['return'])
         ) {
             if ($parsedComment['return'][0] instanceof NullableType) {

src/Analyzer/ClassMethodAnalyzer.php

@@ -132,8 +132,7 @@ public static function analyze(array $parametersA, array $parametersB): array
             'parameter_typing_removed'        => false,
             'parameter_typing_changed'        => false,
             'parameter_nullable_type_added' => false,
-            'parameter_nullable_type_removed' => false,
-            'changed_param_index' => 0
+            'parameter_nullable_type_removed' => false
         ]);
         $lengthA = count($parametersA);
         $lengthB = count($parametersB);
@@ -151,10 +150,8 @@ public static function analyze(array $parametersA, array $parametersB): array
                     // Custom: detect nullable added
                     if ($typeBefore instanceof \PhpParser\Node\NullableType && !$typeAfter instanceof \PhpParser\Node\NullableType) {
                         $changes['parameter_nullable_type_removed'] = true;
-                        $changes['changed_param_index'] = $i;
                     } elseif (!$typeBefore instanceof \PhpParser\Node\NullableType && $typeAfter instanceof \PhpParser\Node\NullableType) {
                         $changes['parameter_nullable_type_added'] = true;
-                        $changes['changed_param_index'] = $i;
                     }
                 } elseif ($parametersA[$i]->type !== null) {
                     $changes['parameter_typing_removed'] = true;

src/Comparator/Signature.php

@@ -36,7 +36,6 @@ class ClassMethodParameterTypingChangedNullable extends ClassMethodOperationUnar
         'M119' => Level::MAJOR
     ];
 
-
     /**
      * @var string
      */