Skip to content

Commit 9776512

Browse files
authored
[NAVAND-3671] Turf radians, degrees, and bearing methods: added tests and update docs (#1613)
1 parent e5f63f2 commit 9776512

File tree

3 files changed

+67
-6
lines changed

3 files changed

+67
-6
lines changed

services-turf/src/main/java/com/mapbox/turf/TurfMeasurement.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,8 @@ private TurfMeasurement() {
4949
*
5050
* @param point1 first point used for calculating the bearing
5151
* @param point2 second point used for calculating the bearing
52-
* @return bearing in decimal degrees
53-
* @see <a href="http://turfjs.org/docs/#bearing">Turf Bearing documentation</a>
54-
* @since 1.3.0
52+
* @return bearing in decimal degrees, between -180 and 180 degrees (positive clockwise)
53+
* @see <a href="https://turfjs.org/docs/api/bearing">Turf Bearing documentation</a>
5554
*/
5655
public static double bearing(@NonNull Point point1, @NonNull Point point2) {
5756

services-turf/src/test/java/com/mapbox/turf/TurfConversionTest.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,23 @@ public class TurfConversionTest extends TestUtils {
4545
@Rule
4646
public ExpectedException thrown = ExpectedException.none();
4747

48+
@Test
49+
public void degreesToRadians() {
50+
assertEquals(1, TurfConversion.degreesToRadians(57.295), 0.0001);
51+
assertEquals(3.1416, TurfConversion.degreesToRadians(180), 0.0001);
52+
assertEquals(2.1817 , TurfConversion.degreesToRadians(125), 0.0001);
53+
assertEquals(0, TurfConversion.degreesToRadians(360), 0.0001);
54+
assertEquals(0, TurfConversion.degreesToRadians(0), 0.0001);
55+
}
56+
57+
@Test
58+
public void radiansToDegrees() {
59+
assertEquals(57.295, TurfConversion.radiansToDegrees(1), 0.01);
60+
assertEquals(180, TurfConversion.radiansToDegrees(3.1416), 0.01);
61+
assertEquals(125, TurfConversion.radiansToDegrees(2.1817), 0.01);
62+
assertEquals(0, TurfConversion.radiansToDegrees(0), 0.01);
63+
}
64+
4865
@Test
4966
public void radiansToDistance() {
5067
assertEquals(

services-turf/src/test/java/com/mapbox/turf/TurfMeasurementTest.java

Lines changed: 48 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,54 @@ public class TurfMeasurementTest extends TestUtils {
6060

6161
@Test
6262
public void testBearing() {
63-
Point pt1 = Point.fromLngLat(-75.4, 39.4);
64-
Point pt2 = Point.fromLngLat(-75.534, 39.123);
65-
assertNotEquals(TurfMeasurement.bearing(pt1, pt2), 0, DELTA);
63+
assertEquals(
64+
90,
65+
TurfMeasurement.bearing(
66+
Point.fromLngLat(0, 0),
67+
Point.fromLngLat(10, 0)
68+
),
69+
DELTA
70+
);
71+
assertEquals(
72+
-90,
73+
TurfMeasurement.bearing(
74+
Point.fromLngLat(0, 0),
75+
Point.fromLngLat(-10, 0)
76+
),
77+
DELTA
78+
);
79+
assertEquals(
80+
0,
81+
TurfMeasurement.bearing(
82+
Point.fromLngLat(0, 0),
83+
Point.fromLngLat(0, 10)
84+
),
85+
DELTA
86+
);
87+
assertEquals(
88+
180,
89+
TurfMeasurement.bearing(
90+
Point.fromLngLat(0, 0),
91+
Point.fromLngLat(0, -10)
92+
),
93+
DELTA
94+
);
95+
assertEquals(
96+
-135.43,
97+
TurfMeasurement.bearing(
98+
Point.fromLngLat(0, 0),
99+
Point.fromLngLat(-10, -10)
100+
),
101+
0.01
102+
);
103+
assertEquals(
104+
44.56,
105+
TurfMeasurement.bearing(
106+
Point.fromLngLat(0, 0),
107+
Point.fromLngLat(10, 10)
108+
),
109+
0.01
110+
);
66111
}
67112

68113
@Test

0 commit comments

Comments
 (0)