Skip to content

Add ILoggerFactory to StreamableHttpServerTransport #1208

@halter73

Description

@halter73

We cannot always bubble up unhandled exceptions through the public API now that code can continue running after

I think we're going to have to bite the bullet and add a new constructor to StreamableHttpServerTransport that takes an optional ILoggerFactory, so we can at least log errors if _sseEventStreamWriter!.DisposeAsync() throws in HandleStreamWriterDisposalAsync.

We don't have to do it in this PR, but I think we should follow up quickly if not.

Originally posted by @halter73 in #1077 (comment)

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions