Skip to content

Commit 3e9b130

Browse files
authored
Merge pull request #19 from openpatch/copilot/fix-max-update-depth-error
Fix infinite loop in LearningMap component caused by unstable useEffect dependencies
2 parents fdf5868 + 2cd7aa9 commit 3e9b130

File tree

3 files changed

+1
-52
lines changed

3 files changed

+1
-52
lines changed

packages/learningmap/src/LearningMap.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ export function LearningMap({
124124
root.dispatchEvent(new CustomEvent("change", { detail: minimalState }));
125125
}
126126
}
127-
}, [nodes, onChange, getViewport, getRoadmapState]);
127+
}, [nodes, onChange]);
128128

129129
const defaultEdgeOptions = {
130130
animated: false,

packages/learningmap/src/autoLayoutElk.ts

Lines changed: 0 additions & 43 deletions
This file was deleted.

packages/learningmap/src/editorStore.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -319,18 +319,10 @@ export const useEditorStore = create<EditorState>()(
319319
setSelectedNodeId: (selectedNodeId) =>
320320
set({
321321
selectedNodeId,
322-
nodes: get().nodes.map((n) => ({
323-
...n,
324-
selected: n.id === selectedNodeId,
325-
})),
326322
}),
327323
setSelectedNodeIds: (selectedNodeIds) =>
328324
set({
329325
selectedNodeIds,
330-
nodes: get().nodes.map((n) => ({
331-
...n,
332-
selected: selectedNodeIds.includes(n.id),
333-
})),
334326
}),
335327
setSelectedEdge: (selectedEdge) => set({ selectedEdge }),
336328
setNextNodeId: (nextNodeId) => set({ nextNodeId }),

0 commit comments

Comments
 (0)