do not save if no changes

Author: mikebarkmin

.changeset/happy-eels-wish.md

@@ -0,0 +1,5 @@
+---
+"learningmap-studio": patch
+---
+
+Do not save if there are no changes

platforms/vscode/src/LearningmapEditorProvider.ts

@@ -1,11 +1,13 @@
-import * as vscode from 'vscode';
+import * as vscode from "vscode";
 
 /**
  * Provider for learningmap custom editor.
  * Handles the webview that displays the LearningMapEditor component.
  */
-export class LearningmapEditorProvider implements vscode.CustomTextEditorProvider {
-  private static readonly viewType = 'learningmap.editor';
+export class LearningmapEditorProvider
+  implements vscode.CustomTextEditorProvider
+{
+  private static readonly viewType = "learningmap.editor";
   private activeWebviewPanel: vscode.WebviewPanel | undefined;
 
   constructor(private readonly context: vscode.ExtensionContext) {}
@@ -16,7 +18,7 @@ export class LearningmapEditorProvider implements vscode.CustomTextEditorProvide
   public sendCommandToActiveEditor(command: string): void {
     if (this.activeWebviewPanel) {
       this.activeWebviewPanel.webview.postMessage({
-        type: 'command',
+        type: "command",
         command: command,
       });
     }
@@ -28,25 +30,25 @@ export class LearningmapEditorProvider implements vscode.CustomTextEditorProvide
   public async resolveCustomTextEditor(
     document: vscode.TextDocument,
     webviewPanel: vscode.WebviewPanel,
-    _token: vscode.CancellationToken
+    _token: vscode.CancellationToken,
   ): Promise<void> {
     // Track this as the active webview panel
     this.activeWebviewPanel = webviewPanel;
-    
+
     // Clear active panel when disposed
     webviewPanel.onDidDispose(() => {
       if (this.activeWebviewPanel === webviewPanel) {
         this.activeWebviewPanel = undefined;
       }
     });
-    
+
     // Update active panel on focus
     webviewPanel.onDidChangeViewState(() => {
       if (webviewPanel.active) {
         this.activeWebviewPanel = webviewPanel;
       }
     });
-    
+
     // Setup initial webview content
     webviewPanel.webview.options = {
       enableScripts: true,
@@ -60,7 +62,7 @@ export class LearningmapEditorProvider implements vscode.CustomTextEditorProvide
     const updateWebview = () => {
       isUpdatingFromDocument = true;
       webviewPanel.webview.postMessage({
-        type: 'update',
+        type: "update",
         content: document.getText(),
       });
       // Reset flag after a short delay
@@ -73,38 +75,47 @@ export class LearningmapEditorProvider implements vscode.CustomTextEditorProvide
     updateWebview();
 
     // Listen for changes in the document (from external sources)
-    const changeDocumentSubscription = vscode.workspace.onDidChangeTextDocument(e => {
-      if (e.document.uri.toString() === document.uri.toString() && e.contentChanges.length > 0) {
-        // Only update if change was from external source (not from us)
-        if (!isUpdatingFromDocument) {
-          updateWebview();
+    const changeDocumentSubscription = vscode.workspace.onDidChangeTextDocument(
+      (e) => {
+        if (
+          e.document.uri.toString() === document.uri.toString() &&
+          e.contentChanges.length > 0
+        ) {
+          // Only update if change was from external source (not from us)
+          if (!isUpdatingFromDocument) {
+            updateWebview();
+          }
         }
-      }
-    });
+      },
+    );
 
     // Handle document save event
-    const saveDocumentSubscription = vscode.workspace.onWillSaveTextDocument(async e => {
-      if (e.document.uri.toString() === document.uri.toString()) {
-        // Wait for the save event to complete
-        e.waitUntil(new Promise<void>((resolve) => {
-          // Send save command to webview
-          webviewPanel.webview.postMessage({
-            type: 'command',
-            command: 'save',
-          });
-          
-          // Wait a bit for the webview to respond
-          setTimeout(() => {
-            resolve();
-          }, 100);
-        }));
-      }
-    });
+    const saveDocumentSubscription = vscode.workspace.onWillSaveTextDocument(
+      async (e) => {
+        if (e.document.uri.toString() === document.uri.toString()) {
+          // Wait for the save event to complete
+          e.waitUntil(
+            new Promise<void>((resolve) => {
+              // Send save command to webview
+              webviewPanel.webview.postMessage({
+                type: "command",
+                command: "save",
+              });
+
+              // Wait a bit for the webview to respond
+              setTimeout(() => {
+                resolve();
+              }, 100);
+            }),
+          );
+        }
+      },
+    );
 
     // Listen for messages from the webview
-    webviewPanel.webview.onDidReceiveMessage(async e => {
+    webviewPanel.webview.onDidReceiveMessage(async (e) => {
       switch (e.type) {
-        case 'change':
+        case "change":
           // Content changed in the webview - update the document to mark it as dirty
           // Set flag to prevent circular updates
           isUpdatingFromDocument = true;
@@ -114,12 +125,12 @@ export class LearningmapEditorProvider implements vscode.CustomTextEditorProvide
             isUpdatingFromDocument = false;
           }, 200);
           return;
-        case 'save':
+        case "save":
           if (!isUpdatingFromDocument) {
             await this.saveDocument(document, e.content);
           }
           return;
-        case 'ready':
+        case "ready":
           // Webview is ready, send initial content
           updateWebview();
           return;
@@ -136,17 +147,25 @@ export class LearningmapEditorProvider implements vscode.CustomTextEditorProvide
   /**
    * Write out the JSON to a given document.
    */
-  private async saveDocument(document: vscode.TextDocument, json: any): Promise<void> {
+  private async saveDocument(
+    document: vscode.TextDocument,
+    json: any,
+  ): Promise<void> {
     const edit = new vscode.WorkspaceEdit();
 
     // Format the JSON with 2-space indentation
     const text = JSON.stringify(json, null, 2);
 
+    if (document.getText() == text) {
+      // No changes
+      return;
+    }
+
     // Replace the entire document
     edit.replace(
       document.uri,
       new vscode.Range(0, 0, document.lineCount, 0),
-      text
+      text,
     );
 
     await vscode.workspace.applyEdit(edit);
@@ -158,10 +177,10 @@ export class LearningmapEditorProvider implements vscode.CustomTextEditorProvide
   private getHtmlForWebview(webview: vscode.Webview): string {
     // Get URIs for scripts and styles
     const scriptUri = webview.asWebviewUri(
-      vscode.Uri.joinPath(this.context.extensionUri, 'dist', 'webview.js')
+      vscode.Uri.joinPath(this.context.extensionUri, "dist", "webview.js"),
     );
     const styleUri = webview.asWebviewUri(
-      vscode.Uri.joinPath(this.context.extensionUri, 'dist', 'webview.css')
+      vscode.Uri.joinPath(this.context.extensionUri, "dist", "webview.css"),
     );
 
     // Use a nonce to only allow specific scripts to be run
@@ -201,7 +220,7 @@ function getNonce() {
   // Generate a cryptographically secure random string
   // This works in both Node.js and browser environments
   const array = new Uint32Array(8);
-  if (typeof crypto !== 'undefined' && crypto.getRandomValues) {
+  if (typeof crypto !== "undefined" && crypto.getRandomValues) {
     // Browser or modern Node.js with Web Crypto API
     crypto.getRandomValues(array);
   } else {
@@ -210,5 +229,5 @@ function getNonce() {
       array[i] = Math.floor(Math.random() * 0xffffffff);
     }
   }
-  return Array.from(array, num => num.toString(16).padStart(8, '0')).join('');
+  return Array.from(array, (num) => num.toString(16).padStart(8, "0")).join("");
 }