[Element Deletion] Deletion of folders with sub-folders needs to be possible

[markus-moser]

At the moment when I try to delete a nested folder I get this error:

{"jobRunId":1444,"jobRunName":"studio_ee_job_delete_assets","ownerId":20,"status":"finished_with_errors","messages":["Element with type folder with ID 5254 could not be deleted: Element has existing children Stack trace: #0 \/var\/www\/html\/dev\/pimcore\/studio-backend-bundle\/src\/ExecutionEngine\/AutomationAction\/AbstractHandler.php(114): Pimcore\\Bundle\\GenericExecutionEngineBundle\\Messenger\\Handler\\AbstractAutomationActionHandler->abortAction('studio_ee_eleme...', Array, 'studio', 'Pimcore\\\\Bundle\\\\...')#1 \/var\/www\/html\/dev\/pimcore\/studio-backend-bundle\/src\/Element\/ExecutionEngine\/AutomationAction\/Messenger\/Handler\/ElementDeleteHandler.php(99): Pimcore\\Bundle\\StudioBackendBundle\\ExecutionEngine\\AutomationAction\\AbstractHandler->abort(Object(Pimcore\\Bundle\\StudioBackendBundle\\ExecutionEngine\\Model\\AbortActionData))#2 \/var\/www\/html\/vendor\/symfony\/messenger\/Middleware\/HandleMessageMiddleware.php(152): Pimcore\\Bundle\\StudioBackendBundle\\Element\\ExecutionEngine\\AutomationAction\\Messenger\\Handler\\ElementDeleteHandler->__invoke(Object(Pimcore\\Bundle\\StudioBackendBundle\\Element\\ExecutionEngine\\AutomationAction\\Messenger\\Messages\\ElementDeleteMessage))#3 \/var\/www\/html\/vendor\/symfony\/messenger\/Middleware\/HandleMessageMiddleware.php(91): Symfony\\Component\\Messenger\\Middleware\\HandleMessageMiddleware->callHandler(Object(Closure), Object(Pimcore\\Bundle\\StudioBackendBundle\\Element\\ExecutionEngine\\AutomationAction\\Messenger\\Messages\\ElementDeleteMessage), NULL, NULL)#4 \/var\/www\/html\/vendor\/symfony\/messenger\/Middleware\/SendMessageMiddleware.php(71): Symfony\\Component\\Messenger\\Middleware\\HandleMessageMiddleware->handle(Object(Symfony\\Component\\Messenger\\Envelope), Object(Symfony\\Component\\Messenger\\Middleware\\TraceableStack))#5 \/var\/www\/html\/vendor\/pimcore\/pimcore\/bundles\/GenericExecutionEngineBundle\/src\/Messenger\/Middleware\/StepConditionMiddleware.php(41): Symfony\\Component\\Messenger\\Middleware\\SendMessageMiddleware->handle(Object(Symfony\\Component\\Messenger\\Envelope), Object(Symfony\\Component\\Messenger\\Middleware\\TraceableStack))#6 \/var\/www\/html\/vendor\/pimcore\/pimcore\/lib\/Messenger\/Middleware\/CollectGarbageMiddleware.php(27): Pimcore\\Bundle\\GenericExecutionEngineBundle\\Messenger\\Middleware\\StepConditionMiddleware->handle(Object(Symfony\\Component\\Messenger\\Envelope), Object(Symfony\\Component\\Messenger\\Middleware\\TraceableStack))#7 \/var\/www\/html\/vendor\/symfony\/messenger\/Middleware\/FailedMessageProcessingMiddleware.php(34): Pimcore\\Messenger\\Middleware\\CollectGarbageMiddleware->handle(Object(Symfony\\Component\\Messenger\\Envelope), Object(Symfony\\Component\\Messenger\\Middleware\\TraceableStack))#8 \/var\/www\/html\/vendor\/symfony\/messenger\/Middleware\/DispatchAfterCurrentBusMiddleware.php(68): Symfony\\Component\\Messenger\\Middleware\\FailedMessageProcessingMiddleware->handle(Object(Symfony\\Component\\Messenger\\Envelope), Object(Symfony\\Component\\Messenger\\Middleware\\TraceableStack))#9 \/var\/www\/html\/vendor\/symfony\/messenger\/Middleware\/RejectRedeliveredMessageMiddleware.php(41): Symfony\\Component\\Messenger\\Middleware\\DispatchAfterCurrentBusMiddleware->handle(Object(Symfony\\Component\\Messenger\\Envelope), Object(Symfony\\Component\\Messenger\\Middleware\\TraceableStack))#10 \/var\/www\/html\/vendor\/symfony\/messenger\/Middleware\/AddBusNameStampMiddleware.php(37): Symfony\\Component\\Messenger\\Middleware\\RejectRedeliveredMessageMiddleware->handle(Object(Symfony\\Component\\Messenger\\Envelope), Object(Symfony\\Component\\Messenger\\Middleware\\TraceableStack))#11 \/var\/www\/html\/vendor\/symfony\/messenger\/Middleware\/TraceableMiddleware.php(40): Symfony\\Component\\Messenger\\Middleware\\AddBusNameStampMiddleware->handle(Object(Symfony\\Component\\Messenger\\Envelope), Object(Symfony\\Component\\Messenger\\Middleware\\TraceableStack))#12 \/var\/www\/html\/vendor\/symfony\/messenger\/MessageBus.php(70): Symfony\\Component\\Messenger\\Middleware\\TraceableMiddleware->handle(Object(Symfony\\Component\\Messenger\\Envelope), Object(Symfony\\Component\\Messenger\\Middleware\\TraceableStack))#13 \/var\/www\/html\/vendor\/symfony\/messenger\/RoutableMessageBus.php(54): Symfony\\Component\\Messenger\\MessageBus->dispatch(Object(Symfony\\Component\\Messenger\\Envelope), Array)#14 \/var\/www\/html\/vendor\/symfony\/messenger\/Worker.php(159): Symfony\\Component\\Messenger\\RoutableMessageBus->dispatch(Object(Symfony\\Component\\Messenger\\Envelope))#15 \/var\/www\/html\/vendor\/symfony\/messenger\/Worker.php(108): Symfony\\Component\\Messenger\\Worker->handleMessage(Object(Symfony\\Component\\Messenger\\Envelope), 'pimcore_generic...')#16 \/var\/www\/html\/vendor\/symfony\/messenger\/Command\/ConsumeMessagesCommand.php(244): Symfony\\Component\\Messenger\\Worker->run(Array)#17 \/var\/www\/html\/vendor\/symfony\/console\/Command\/Command.php(326): Symfony\\Component\\Messenger\\Command\\ConsumeMessagesCommand->execute(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))#18 \/var\/www\/html\/vendor\/symfony\/console\/Application.php(1096): Symfony\\Component\\Console\\Command\\Command->run(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))#19 \/var\/www\/html\/vendor\/symfony\/framework-bundle\/Console\/Application.php(126): Symfony\\Component\\Console\\Application->doRunCommand(Object(Symfony\\Component\\Messenger\\Command\\ConsumeMessagesCommand), Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))#20 \/var\/www\/html\/vendor\/symfony\/console\/Application.php(324): Symfony\\Bundle\\FrameworkBundle\\Console\\Application->doRunCommand(Object(Symfony\\Component\\Messenger\\Command\\ConsumeMessagesCommand), Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))#21 \/var\/www\/html\/vendor\/symfony\/framework-bundle\/Console\/Application.php(80): Symfony\\Component\\Console\\Application->doRun(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))#22 \/var\/www\/html\/vendor\/symfony\/console\/Application.php(175): Symfony\\Bundle\\FrameworkBundle\\Console\\Application->doRun(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))#23 \/var\/www\/html\/vendor\/symfony\/runtime\/Runner\/Symfony\/ConsoleApplicationRunner.php(49): Symfony\\Component\\Console\\Application->run(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))#24 \/var\/www\/html\/vendor\/autoload_runtime.php(29): Symfony\\Component\\Runtime\\Runner\\Symfony\\ConsoleApplicationRunner->run()#25 \/var\/www\/html\/bin\/console(20): require_once('\/var\/www\/html\/v...')#26 {main}","Element with type folder with ID 5084 could not be deleted: Element has existing children Stack trace: #0 \/var\/www\/html\/dev\/pimcore\/studio-backend-bundle\/src\/ExecutionEngine\/AutomationAction\/AbstractHandler.php(114): Pimcore\\Bundle\\GenericExecutionEngineBundle\\Messenger\\Handler\\AbstractAutomationActionHandler->abortAction('studio_ee_eleme...', Array, 'studio', 'Pimcore\\\\Bundle\\\\...')#1 \/var\/www\/html\/dev\/pimcore\/studio-backend-bundle\/src\/Element\/ExecutionEngine\/AutomationAction\/Messenger\/Handler\/ElementDeleteHandler.php(83): Pimcore\\Bundle\\StudioBackendBundle\\ExecutionEngine\\AutomationAction\\AbstractHandler->abort(Object(Pimcore\\Bundle\\StudioBackendBundle\\ExecutionEngine\\Model\\AbortActionData))#2 \/var\/www\/html\/vendor\/symfony\/messenger\/Middleware\/HandleMessageMiddleware.php(152): Pimcore\\Bundle\\StudioBackendBundle\\Element\\ExecutionEngine\\AutomationAction\\Messenger\\Handler\\ElementDeleteHandler->__invoke(Object(Pimcore\\Bundle\\StudioBackendBundle\\Element\\ExecutionEngine\\AutomationAction\\Messenger\\Messages\\ElementDeleteMessage))#3 \/var\/www\/html\/vendor\/symfony\/messenger\/Middleware\/HandleMessageMiddleware.php(91): Symfony\\Component\\Messenger\\Middleware\\HandleMessageMiddleware->callHandler(Object(Closure), Object(Pimcore\\Bundle\\StudioBackendBundle\\Element\\ExecutionEngine\\AutomationAction\\Messenger\\Messages\\ElementDeleteMessage), NULL, NULL)#4 \/var\/www\/html\/vendor\/symfony\/messenger\/Middleware\/SendMessageMiddleware.php(71): Symfony\\Component\\Messenger\\Middleware\\HandleMessageMiddleware->handle(Object(Symfony\\Component\\Messenger\\Envelope), Object(Symfony\\Component\\Messenger\\Middleware\\TraceableStack))#5 \/var\/www\/html\/vendor\/pimcore\/pimcore\/bundles\/GenericExecutionEngineBundle\/src\/Messenger\/Middleware\/StepConditionMiddleware.php(41): Symfony\\Component\\Messenger\\Middleware\\SendMessageMiddleware->handle(Object(Symfony\\Component\\Messenger\\Envelope), Object(Symfony\\Component\\Messenger\\Middleware\\TraceableStack))#6 \/var\/www\/html\/vendor\/pimcore\/pimcore\/lib\/Messenger\/Middleware\/CollectGarbageMiddleware.php(27): Pimcore\\Bundle\\GenericExecutionEngineBundle\\Messenger\\Middleware\\StepConditionMiddleware->handle(Object(Symfony\\Component\\Messenger\\Envelope), Object(Symfony\\Component\\Messenger\\Middleware\\TraceableStack))#7 \/var\/www\/html\/vendor\/symfony\/messenger\/Middleware\/FailedMessageProcessingMiddleware.php(34): Pimcore\\Messenger\\Middleware\\CollectGarbageMiddleware->handle(Object(Symfony\\Component\\Messenger\\Envelope), Object(Symfony\\Component\\Messenger\\Middleware\\TraceableStack))#8 \/var\/www\/html\/vendor\/symfony\/messenger\/Middleware\/DispatchAfterCurrentBusMiddleware.php(68): Symfony\\Component\\Messenger\\Middleware\\FailedMessageProcessingMiddleware->handle(Object(Symfony\\Component\\Messenger\\Envelope), Object(Symfony\\Component\\Messenger\\Middleware\\TraceableStack))#9 \/var\/www\/html\/vendor\/symfony\/messenger\/Middleware\/RejectRedeliveredMessageMiddleware.php(41): Symfony\\Component\\Messenger\\Middleware\\DispatchAfterCurrentBusMiddleware->handle(Object(Symfony\\Component\\Messenger\\Envelope), Object(Symfony\\Component\\Messenger\\Middleware\\TraceableStack))#10 \/var\/www\/html\/vendor\/symfony\/messenger\/Middleware\/AddBusNameStampMiddleware.php(37): Symfony\\Component\\Messenger\\Middleware\\RejectRedeliveredMessageMiddleware->handle(Object(Symfony\\Component\\Messenger\\Envelope), Object(Symfony\\Component\\Messenger\\Middleware\\TraceableStack))#11 \/var\/www\/html\/vendor\/symfony\/messenger\/Middleware\/TraceableMiddleware.php(40): Symfony\\Component\\Messenger\\Middleware\\AddBusNameStampMiddleware->handle(Object(Symfony\\Component\\Messenger\\Envelope), Object(Symfony\\Component\\Messenger\\Middleware\\TraceableStack))#12 \/var\/www\/html\/vendor\/symfony\/messenger\/MessageBus.php(70): Symfony\\Component\\Messenger\\Middleware\\TraceableMiddleware->handle(Object(Symfony\\Component\\Messenger\\Envelope), Object(Symfony\\Component\\Messenger\\Middleware\\TraceableStack))#13 \/var\/www\/html\/vendor\/symfony\/messenger\/RoutableMessageBus.php(54): Symfony\\Component\\Messenger\\MessageBus->dispatch(Object(Symfony\\Component\\Messenger\\Envelope), Array)#14 \/var\/www\/html\/vendor\/symfony\/messenger\/Worker.php(159): Symfony\\Component\\Messenger\\RoutableMessageBus->dispatch(Object(Symfony\\Component\\Messenger\\Envelope))#15 \/var\/www\/html\/vendor\/symfony\/messenger\/Worker.php(108): Symfony\\Component\\Messenger\\Worker->handleMessage(Object(Symfony\\Component\\Messenger\\Envelope), 'pimcore_generic...')#16 \/var\/www\/html\/vendor\/symfony\/messenger\/Command\/ConsumeMessagesCommand.php(244): Symfony\\Component\\Messenger\\Worker->run(Array)#17 \/var\/www\/html\/vendor\/symfony\/console\/Command\/Command.php(326): Symfony\\Component\\Messenger\\Command\\ConsumeMessagesCommand->execute(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))#18 \/var\/www\/html\/vendor\/symfony\/console\/Application.php(1096): Symfony\\Component\\Console\\Command\\Command->run(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))#19 \/var\/www\/html\/vendor\/symfony\/framework-bundle\/Console\/Application.php(126): Symfony\\Component\\Console\\Application->doRunCommand(Object(Symfony\\Component\\Messenger\\Command\\ConsumeMessagesCommand), Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))#20 \/var\/www\/html\/vendor\/symfony\/console\/Application.php(324): Symfony\\Bundle\\FrameworkBundle\\Console\\Application->doRunCommand(Object(Symfony\\Component\\Messenger\\Command\\ConsumeMessagesCommand), Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))#21 \/var\/www\/html\/vendor\/symfony\/framework-bundle\/Console\/Application.php(80): Symfony\\Component\\Console\\Application->doRun(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))#22 \/var\/www\/html\/vendor\/symfony\/console\/Application.php(175): Symfony\\Bundle\\FrameworkBundle\\Console\\Application->doRun(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))#23 \/var\/www\/html\/vendor\/symfony\/runtime\/Runner\/Symfony\/ConsoleApplicationRunner.php(49): Symfony\\Component\\Console\\Application->run(Object(Symfony\\Component\\Console\\Input\\ArgvInput), Object(Symfony\\Component\\Console\\Output\\ConsoleOutput))#24 \/var\/www\/html\/vendor\/autoload_runtime.php(29): Symfony\\Component\\Runtime\\Runner\\Symfony\\ConsoleApplicationRunner->run()#25 \/var\/www\/html\/bin\/console(20): require_once('\/var\/www\/html\/v...')#26 {main}"],"notifyAll":false}

[github-actions]

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

[lukmzig]

I cannot reproduce this, not locally nor on nightly unfortunately.

We use GDI to get the children IDs as we defined: https://github.com/pimcore/studio-backend-bundle/blob/1.x/src/DataIndex/Service/ElementSearchService.php#L70

Then when the element is being deleted, we double check if something changed as this is ASYNC (maybe someone created element in the folder meanwhile) - in this case the folder should not be deleted: https://github.com/pimcore/studio-backend-bundle/blob/1.x/src/Element/Service/ElementDeleteService.php#L172

If your index do not have latest data (does not reflect DB data) the issue might occur. Thats just an idea why this might have happened.

[markus-moser]

I agree, it's hard to reproduce, but sometimes it happens. Still no idea when, but let's see how often this happens or if we find a way to reproduce it.