fix: resolve type errors in auto-delete and protection features

- Fix LocalTime conversion in base.go and entity_storage.go (use .Time field)
- Fix CLI actions.go to use pointer for Protected field
- Fix routes.go to use updatedClone.Protected for telemetry event
- Add thinclones import and DestroyOptions parameter in auto_delete.go
- Fix clone_test.go to handle Protected pointer properly

Author: claude

engine/cmd/cli/commands/clone/actions.go

@@ -184,8 +184,9 @@ func update(cliCtx *cli.Context) error {
 		return err
 	}
 
+	protected := cliCtx.Bool("protected")
 	updateRequest := types.CloneUpdateRequest{
-		Protected: cliCtx.Bool("protected"),
+		Protected: &protected,
 	}
 
 	cloneID := cliCtx.Args().First()

engine/internal/cloning/base.go

@@ -852,7 +852,7 @@ func (c *Base) destroyScheduledClones(ctx context.Context) {
 				continue
 			}
 
-			if time.Time(*clone.DeleteAt).After(now) {
+			if clone.DeleteAt.Time.After(now) {
 				continue
 			}
 

engine/internal/cloning/entity_storage.go

@@ -287,7 +287,7 @@ func (es *EntityStorage) GetExpiredBranches() []*BranchMeta {
 
 	for _, meta := range es.branches {
 		if meta.DeleteAt != nil && meta.AutoDeleteMode != models.AutoDeleteOff {
-			if time.Time(*meta.DeleteAt).Before(now) {
+			if meta.DeleteAt.Time.Before(now) {
 				expired = append(expired, meta)
 			}
 		}
@@ -306,7 +306,7 @@ func (es *EntityStorage) GetExpiredSnapshots() []*SnapshotMeta {
 
 	for _, meta := range es.snapshots {
 		if meta.DeleteAt != nil && meta.AutoDeleteMode != models.AutoDeleteOff {
-			if time.Time(*meta.DeleteAt).Before(now) {
+			if meta.DeleteAt.Time.Before(now) {
 				expired = append(expired, meta)
 			}
 		}

engine/internal/srv/auto_delete.go

@@ -12,6 +12,7 @@ import (
 
 	"gitlab.com/postgres-ai/database-lab/v3/internal/cloning"
 	"gitlab.com/postgres-ai/database-lab/v3/internal/provision/pool"
+	"gitlab.com/postgres-ai/database-lab/v3/internal/provision/thinclones"
 	"gitlab.com/postgres-ai/database-lab/v3/internal/webhooks"
 	"gitlab.com/postgres-ai/database-lab/v3/pkg/log"
 	"gitlab.com/postgres-ai/database-lab/v3/pkg/models"
@@ -224,7 +225,7 @@ func (s *Server) processExpiredSnapshots(ctx context.Context) {
 
 		log.Msg(fmt.Sprintf("Scheduled snapshot %q is going to be removed (deleteAt: %s)", meta.ID, meta.DeleteAt.Time.Format(time.RFC3339)))
 
-		if err := fsm.DestroySnapshot(meta.ID); err != nil {
+		if err := fsm.DestroySnapshot(meta.ID, thinclones.DestroyOptions{}); err != nil {
 			log.Errf("failed to destroy scheduled snapshot %q: %v", meta.ID, err)
 			continue
 		}
@@ -295,7 +296,7 @@ func (s *Server) forceDeleteSnapshot(ctx context.Context, fsm pool.FSManager, sn
 		}
 	}
 
-	if err := fsm.DestroySnapshot(snapshotID); err != nil {
+	if err := fsm.DestroySnapshot(snapshotID, thinclones.DestroyOptions{}); err != nil {
 		return fmt.Errorf("failed to destroy snapshot: %w", err)
 	}
 

engine/internal/srv/routes.go

@@ -822,7 +822,7 @@ func (s *Server) patchClone(w http.ResponseWriter, r *http.Request) {
 
 	s.tm.SendEvent(context.Background(), telemetry.CloneUpdatedEvent, telemetry.CloneUpdated{
 		ID:        util.HashID(cloneID),
-		Protected: patchClone.Protected,
+		Protected: updatedClone.Protected,
 	})
 
 	if err := api.WriteJSON(w, http.StatusOK, updatedClone); err != nil {

engine/pkg/client/dblabapi/clone_test.go

@@ -366,7 +366,9 @@ func TestClientUpdateClone(t *testing.T) {
 		err = json.Unmarshal(requestBody, &updateRequest)
 		require.NoError(t, err)
 
-		cloneModel.Protected = updateRequest.Protected
+		if updateRequest.Protected != nil {
+			cloneModel.Protected = *updateRequest.Protected
+		}
 
 		// Prepare response.
 		responseBody, err := json.Marshal(cloneModel)
@@ -388,8 +390,9 @@ func TestClientUpdateClone(t *testing.T) {
 	c.client = mockClient
 
 	// Send a request.
+	protectedFalse := false
 	newClone, err := c.UpdateClone(context.Background(), cloneModel.ID, types.CloneUpdateRequest{
-		Protected: false,
+		Protected: &protectedFalse,
 	})
 	require.NoError(t, err)