Strip noexcept from cpp17 function type bindings#5992
Draft
Skylion007 wants to merge 4 commits intopybind:masterfrom
Draft
Strip noexcept from cpp17 function type bindings#5992Skylion007 wants to merge 4 commits intopybind:masterfrom
Skylion007 wants to merge 4 commits intopybind:masterfrom
Conversation
Skylion007
force-pushed
the
skylion007/cpp17-claude-noexcept-2026-02-20
branch
from
a7a3ed9 to
e8b0584
Compare
Skylion007
force-pushed
the
skylion007/cpp17-claude-noexcept-2026-02-20
branch
from
e8b0584 to
b303194
Compare
Skylion007
force-pushed
the
skylion007/cpp17-claude-noexcept-2026-02-20
branch
from
ad30bc0 to
f530adb
Compare
Skylion007
commented
Feb 20, 2026
|
|
||
| template <typename Derived, typename Return, typename Class, typename... Args> | ||
| auto method_adaptor(Return (Class::*pmf)(Args...) const & noexcept) | ||
| -> Return (Derived::*)(Args...) const & noexcept { |
Collaborator
Author
There was a problem hiding this comment.
I think I need to add tests for '&&' here i guess. Otherwise the fall through the perfect forwarding template... Sigh... I'll try construct some tests later I guess.
Skylion007
commented
Feb 20, 2026
| return pmf; | ||
| } | ||
|
|
||
| template <typename Derived, typename Return, typename Class, typename... Args> |
Collaborator
Author
There was a problem hiding this comment.
Maybe able to massively simplify this with a macro...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix issue #2234 . Fix overloading to accept noexcept function types too and strip them. Mostly authored by ClaudeCode.
Suggested changelog entry: