Skip to content

Commit 4fba85b

Browse files
Apply suggestions from code review
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
1 parent d06c052 commit 4fba85b

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

.github/CONTRIBUTING.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,12 @@ Please be aware that our workflow does deviate slightly from the typical GitHub
1818
project. Details on how to properly submit a pull request are covered in
1919
[Lifecycle of a Pull Request](https://devguide.python.org/pullrequest/).
2020
We utilize various bots and status checks to help with this, so do follow the
21-
comments they leave and their "Details" links, respectively. A key point of
22-
our workflow that is not covered by a bot or status check is that all
23-
discussions that are not directly related to the code in the pull request
24-
should happen on the [issue tracker](https://devguide.python.org/tracker/).
21+
comments they leave and their "Details" links, respectively.
22+
23+
The final key part of our workflow is that all discussions that are not
24+
directly related to the code in the pull request should happen on the
25+
[issue tracker](https://devguide.python.org/tracker/), generally in the
26+
pull request's parent issue.
2527

2628

2729
## Setting Expectations

getting-started/git-boot-camp.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -611,7 +611,7 @@ When a pull request submitter has enabled the `Allow edits from maintainers`_
611611
option, Python Core Developers may decide to make any remaining edits needed
612612
prior to merging themselves, rather than asking the submitter to do them. This
613613
can be particularly appropriate when the remaining changes are bookkeeping
614-
items.
614+
items like updating a news entry.
615615

616616
.. _Allow edits from maintainers: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork
617617

0 commit comments

Comments
 (0)