Merge pull request #32 from rameel/backport-advsimd

Backport ExtractMostSignificantBits

Author: rameel

Ramstack.Globbing.Tests/Ramstack.Globbing.Tests.csproj

@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFrameworks>net6.0;net7.0</TargetFrameworks>
+    <TargetFramework>net6.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
     <LangVersion>preview</LangVersion>

Ramstack.Globbing.Tests/SimdConfigurationTests.cs

@@ -15,6 +15,7 @@ public void VerifySimdConfiguration()
             Assert.That(Sse2.IsSupported, Is.False);
             Assert.That(Sse41.IsSupported, Is.False);
             Assert.That(Avx2.IsSupported, Is.False);
+            Assert.That(AdvSimd.Arm64.IsSupported, Is.False);
             Assert.That(AdvSimd.IsSupported, Is.False);
         }
 

Ramstack.Globbing/Internal/PathHelper.cs

@@ -334,7 +334,7 @@ public PathSegmentIterator() =>
 
             while ((int)_position < length)
             {
-                if ((Avx2.IsSupported || Sse2.IsSupported || AdvSimd.IsSupported) && _mask != 0)
+                if ((Avx2.IsSupported || Sse2.IsSupported || AdvSimd.Arm64.IsSupported) && _mask != 0)
                 {
                     var offset = BitOperations.TrailingZeroCount(_mask);
                     if (AdvSimd.IsSupported)
@@ -446,8 +446,7 @@ public PathSegmentIterator() =>
                     if (_mask == 0)
                         _position += Vector128<ushort>.Count;
                 }
-                #if NET7_0_OR_GREATER
-                else if (AdvSimd.IsSupported && (int)_position + Vector128<ushort>.Count <= length)
+                else if (AdvSimd.Arm64.IsSupported && (int)_position + Vector128<ushort>.Count <= length)
                 {
                     var chunk = LoadVector128(ref source, _position);
                     var backslashMask = CreateBackslash128Bitmask(flags);
@@ -466,15 +465,24 @@ public PathSegmentIterator() =>
                     // This avoids reloading SIMD registers and repeating comparisons
                     // on the same chunk of data.
                     //
-                    _mask = comparison.ExtractMostSignificantBits();
+                    _mask = ExtractMostSignificantBits(comparison);
 
                     //
                     // Advance position to the next chunk when no separators found
                     //
                     if (_mask == 0)
                         _position += Vector128<ushort>.Count;
+
+                    [MethodImpl(MethodImplOptions.AggressiveInlining)]
+                    static uint ExtractMostSignificantBits(Vector128<ushort> v)
+                    {
+                        var sum = AdvSimd.Arm64.AddAcross(
+                            AdvSimd.ShiftLogical(
+                                AdvSimd.And(v, Vector128.Create((ushort)0x8000)),
+                                Vector128.Create((short)-15, -14, -13, -12, -11, -10, -9, -8)));
+                        return sum.ToScalar();
+                    }
                 }
-                #endif
                 else
                 {
                     for (; (int)_position < length; _position++)

Ramstack.Globbing/Ramstack.Globbing.csproj

@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFrameworks>net6.0;net7.0</TargetFrameworks>
+    <TargetFramework>net6.0</TargetFramework>
     <Description>Fast and zero-allocation .NET globbing library for matching file paths using glob patterns.</Description>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>