[Bug]: Projects referencing projects using ReactiveUI.SourceGenerators failing to build

[MartinFayRAX]

Describe the bug 🐞

I've just noticed a build problem when a library-not-referencing-RxUI (Library1) references once which does i.e.:
Application (references ReactiveUI.WPF)
|
Library1 (doesn't reference ReactiveUI.WPF) <- And when I add a reference to RxUI it works!
|
Library2 (references ReactiveUI.WPF)

The produces error CS0400:
"The type or namespace name 'Splat' could not be found in the global namespace (are you missing an assembly reference?)"

(And NCrunch output references IViewForGenerator)

Step to reproduce

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Reproduction repository

https://github.com/reactiveui/ReactiveUI

Expected behavior

This should happen...

Screenshots 🖼️

No response

IDE

No response

Operating system

No response

Version

No response

Device

No response

ReactiveUI Version

No response

Additional information ℹ️

No response

[MartinFayRAX]

I should clarify that Splat is a transitive dependency via RxUI, I added the "unnecessary" reference to RxUI to side-step taking a direct dependency on Splat (and so needing to manage the version of that in addition to RxUI).

[glennawatson]

What version of ReactiveUI are you using? (bed time for me so won't respond immediately)

[MartinFayRAX]

Sorry I was quite sloppy with the report!

<PackageVersion Include="ReactiveUI.SourceGenerators" Version="2.6.1" />
<PackageVersion Include="ReactiveUI.WPF" Version="22.3.1" />

[glennawatson]

Yeah we got a new beta of reactiveui which is about to become the full release after we fix the documented changes. So just wanted to work out if it was a beta issue or not.

I'll have a play tomorrow for you and see what I can find.

[MartinFayRAX]

(Posting here because I have a suspicion this is somewhat related...)

I'm seeing loads of warnings, since updating some projects to use ReactiveUI.SourceGenerators:
warning RXUISG0020: [Reactive] requires the property to be partial and the containing type to be partial so source generation can run.

These are flagging code in projects still using ReactiveUI.Fody... so are all projects being scanned not just those referencing ReactiveUI.SourceGenerators?

[MartinFayRAX]

btw no big hurry I have workarounds.

[glennawatson]

Have to got PrivateAssets set to all on the project reference element in the csproj file similar to the readme. Without it everything will propogate down

[MartinFayRAX]

Thanks Glenn, that absolutely makes sense, code generator packages would typically have PrivateAssets="all" set. Quick test suggests this has solved both issues.

However, I'm not sure where this is mentioned, does not appear on the page https://github.com/reactiveui/ReactiveUI.SourceGenerators?tab=readme-ov-file#readme that I can see? (And I think this is the same text shown in the Nuget Package Manager?)

Significant gotcha potential here, no idea if there's any way to flag this when building?

GitHub

GitHub - reactiveui/ReactiveUI.SourceGenerators: Use source generators to generate objects.

Use source generators to generate objects. . Contribute to reactiveui/ReactiveUI.SourceGenerators development by creating an account on GitHub.

[glennawatson]

Apparently not no. Used to be I think. Let's leave this issue open as a reminder to properly document it.

[MartinFayRAX]

Thank you for your startlingly rapid help!