Skip to content

Commit 9f2c368

Browse files
authored
Separate GitHub Actions job for format, lint, and type check (#15)
Move format, lint, and type check to a separate GitHub Actions job. This is partly because some of these steps are a little slow so it's better if they're running parallel, but also it's annoying to lose a whole test run when something dumb like a lint problem fails the job early. Now, we still see the lint failure, but get to see test failures in case we have any of those.
1 parent d7a4f23 commit 9f2c368

File tree

1 file changed

+22
-9
lines changed

1 file changed

+22
-9
lines changed

.github/workflows/ci.yaml

Lines changed: 22 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -53,15 +53,6 @@ jobs:
5353
- name: Rye sync
5454
run: rye sync
5555

56-
- name: Format check
57-
run: rye fmt --check
58-
59-
- name: Lint
60-
run: rye lint
61-
62-
- name: Type check
63-
run: make type-check
64-
6556
- name: Build
6657
run: rye build
6758

@@ -122,3 +113,25 @@ jobs:
122113

123114
- name: Run examples
124115
run: rye run python3 -m examples.all
116+
117+
format_lint_and_type_check:
118+
runs-on: ubuntu-latest
119+
120+
steps:
121+
- name: Checkout
122+
uses: actions/checkout@v4
123+
124+
- name: Install Rye
125+
uses: eifinger/setup-rye@v3
126+
127+
- name: Rye sync
128+
run: rye sync
129+
130+
- name: Format check
131+
run: rye fmt --check
132+
133+
- name: Lint
134+
run: rye lint
135+
136+
- name: Type check
137+
run: make type-check

0 commit comments

Comments
 (0)