Update remaining crates to edition 2021.#621
Conversation
wt
force-pushed
the
upgrade_to_edition_2021
branch
from
c7c2f57 to
ff1f7c7
Compare
|
Looks like MSRV would need to be moved to 1.68 for this. Would that be acceptable? Why, you ask? |
wt
force-pushed
the
upgrade_to_edition_2021
branch
4 times, most recently
from
82f2868 to
c0c13ca
Compare
|
There were some other issues that required 1.71 instead of 1.68. |
wt
force-pushed
the
upgrade_to_edition_2021
branch
from
c0c13ca to
53f07a1
Compare
wt
force-pushed
the
upgrade_to_edition_2021
branch
5 times, most recently
from
d1c5d99 to
967980e
Compare
xtask/Cargo.toml
Outdated
| [package] | ||
| name = "xtask" | ||
| version = "0.0.0" | ||
| version = "0.0.1" |
There was a problem hiding this comment.
This is just tooling for the repo, so it can stay at 0.0.0
There was a problem hiding this comment.
I backed out the version change.
Also, the version attribute is optional and defaults to 0.0.0. Should we just remove that line altogether?
There was a problem hiding this comment.
I’d rather leave it in, but that’s a pretty weak preference.
wt
force-pushed
the
upgrade_to_edition_2021
branch
from
967980e to
5906a32
Compare
MSRV needs to move to 1.71 for this to work since there are deps that depend on that version.
wt
force-pushed
the
upgrade_to_edition_2021
branch
from
5906a32 to
3796cc3
Compare
|
I don't think we strictly require a vote to update the MSRV, but I'll leave this open for a few days in case anyone wants to chime in or comment. |
4 participants
This pushes the crates that are still listed as edition 2018 to 2021. I test built all of them.
@jonathanpallant adds:
I think we need input from the whole team for an MSRV bump. This PR moves us to 1.71.