-
Notifications
You must be signed in to change notification settings - Fork 16
Open
Labels
good first issueGood for newcomersGood for newcomers
Description
Summary
The global DELETE /faults?status= endpoint lacks a test that verifies the status filter actually works (e.g. inject a confirmed fault → DELETE with ?status=pending → verify the confirmed fault still exists). Current integration tests only check that 204 is returned, because demo nodes continuously re-report faults making absence checks flaky.
Proposed solution (optional)
Add a C++ unit test (~30-50 lines) with a mock fault manager:
- Mock
list_faults()to return known faults with different statuses - Call
handle_clear_all_faults_globalwith?status=pending - Verify
clear_fault()was only called on pending faults
Existing patterns in test_fault_manager.cpp can be reused — no new test infrastructure needed.
Additional context (optional)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers