Fix: tsconfig is always overwritten by default

Author: 1aron

packages/techor/src/commands/build.ts

@@ -25,6 +25,7 @@ import { nodeResolve } from '@rollup/plugin-node-resolve'
 import commonjs from '@rollup/plugin-commonjs'
 import swc from '../plugins/swc'
 import preserveDirectives from 'rollup-plugin-preserve-directives'
+import { getTsconfig, TsConfigJson } from 'get-tsconfig'
 
 declare type OutputResult = (BuildOutputOptions & { artifact: (RollupOutputAsset | RollupOutputChunk) })
 declare type BuildOutputOptions = BuildCommonOptions & { output: RollupOutputOptions }
@@ -60,6 +61,18 @@ export default async function build() {
             process.env.NODE_ENV = 'production'
         }
 
+        const tsconfigFile = config.build.swc.tsconfigFile || config.build.tsconfig
+        let tsconfig: TsConfigJson
+        if (tsconfigFile) {
+            if (tsconfigFile === true) {
+                tsconfig = getTsconfig('.')?.config
+            } else {
+                tsconfig = getTsconfig(tsconfigFile)?.config
+                if (!tsconfig) {
+                    tsconfig = getTsconfig('.')?.config
+                }
+            }
+        }
         if (process.env.DEBUG) console.log('[techor] cmdConfig', cmdConfig)
         const pkg: PackageJson = readJSONFileSync('package.json') || {}
         const { dependencies, peerDependencies, optionalDependencies, types } = pkg
@@ -139,18 +152,16 @@ export default async function build() {
                 } as RollupInputOptions, config.build.input)
                 buildOptions.input.input = entries
                 buildOptions.input.external = (config.build.input.external && !forceBundle) && getWideExternal(config.build.input.external)
-                const extendedSWCOptions: Config['build']['swc'] = extend(
-                    config.build.swc, { tsconfigFile: config.build.tsconfig } as Config['build']['swc'])
+                const extendedSWCOptions: Config['build']['swc'] = extend(config.build.swc, { tsconfigFile: config.build.tsconfig } as Config['build']['swc'])
                 if (extendedBuild.minify) {
                     extendedSWCOptions.minify = true
-
                 } else {
                     delete extendedSWCOptions.minify
                     delete extendedSWCOptions.jsc.minify
                 }
                 (buildOptions.input.plugins as RollupInputPluginOption[]).unshift(
                     ...[
-                        swc(extendedSWCOptions),
+                        swc(extendedSWCOptions, tsconfig),
                         config.build.commonjs && commonjs(config.build.commonjs),
                         config.build.nodeResolve && nodeResolve(config.build.nodeResolve),
                         config.build.esmShim && esmShim(),

packages/techor/src/plugins/swc.ts

@@ -1,6 +1,6 @@
 import type { Plugin } from 'rollup'
-import { getTsconfig } from 'get-tsconfig'
-import { Options as SWCOptions, transform } from '@swc/core'
+import { getTsconfig, TsConfigJson } from 'get-tsconfig'
+import { JscTarget, Options as SWCOptions, transform } from '@swc/core'
 import extend from '@techor/extend'
 import { FilterPattern, createFilter } from '@rollup/pluginutils'
 
@@ -10,29 +10,30 @@ export type Options = SWCOptions & {
     tsconfigFile?: string | boolean
 }
 
-export default function swc({ tsconfigFile, include, exclude, minify, ...options }: Options = {}): Plugin {
+export default function swc({ tsconfigFile, include, exclude, minify, ...options }: Options = {}, tsconfig: TsConfigJson): Plugin {
     const filter = createFilter(include, exclude)
-    const compilerOptions = tsconfigFile === false ? {} : getTsconfig('.', tsconfigFile === true ? undefined : tsconfigFile)?.config?.compilerOptions || {}
     let swcOptions = {
         jsc: {
-            target: compilerOptions.target,
             parser: {},
             transform: {}
         }
     } as SWCOptions
-    if (compilerOptions.experimentalDecorators) {
+    swcOptions = extend(swcOptions, options)
+    if (tsconfig?.compilerOptions?.experimentalDecorators) {
         swcOptions.jsc.parser.decorators = true
         swcOptions.jsc.transform.legacyDecorator = true
-        swcOptions.jsc.transform.decoratorMetadata = compilerOptions.emitDecoratorMetadata
+        swcOptions.jsc.transform.decoratorMetadata = tsconfig?.compilerOptions.emitDecoratorMetadata
     }
-    if (compilerOptions.jsx) {
+    if (tsconfig?.compilerOptions?.jsx) {
         swcOptions.jsc.transform.react = {
-            pragma: compilerOptions.jsxFactory,
-            pragmaFrag: compilerOptions.jsxFragmentFactory,
-            importSource: compilerOptions.jsxImportSource,
+            pragma: tsconfig?.compilerOptions.jsxFactory,
+            pragmaFrag: tsconfig?.compilerOptions.jsxFragmentFactory,
+            importSource: tsconfig?.compilerOptions.jsxImportSource,
         }
     }
-    swcOptions = extend(swcOptions, options)
+    if (tsconfig?.compilerOptions?.target) {
+        swcOptions.jsc.target = tsconfig?.compilerOptions.target.toLocaleLowerCase() as JscTarget
+    }
     return {
         name: 'techor-swc',
         async transform(code, id) {

packages/techor/tests/pnpm-lock.yaml

@@ -0,0 +1,9 @@
+{
+    "name": "@test/target-es5",
+    "version": "1.0.0",
+    "private": true,
+    "main": "dist/index.cjs",
+    "files": [
+        "dist"
+    ]
+}

packages/techor/tests/target-es5/package.json

@@ -0,0 +1,7 @@
+function getUserName(name?: string | null) {
+    const displayName = name ?? 'Guest'
+    return `Hello, ${displayName}!`
+}
+
+console.log(getUserName('JoyHe'))
+console.log(getUserName())

packages/techor/tests/target-es5/src/index.ts

@@ -0,0 +1,20 @@
+import { execSync } from 'node:child_process'
+import { readFileSync } from 'node:fs'
+import { join } from 'node:path'
+import dedent from 'ts-dedent'
+
+beforeAll(() => {
+    execSync('tsx ../../src/bin build', { cwd: __dirname, stdio: 'inherit' })
+})
+
+test('main', () => {
+    expect(readFileSync(join(__dirname, './dist/index.cjs'), 'utf-8')).toContain(dedent`
+    'use strict';
+
+    function getUserName(name) {
+        var displayName = name !== null && name !== void 0 ? name : 'Guest';
+        return "Hello, ".concat(displayName, "!");
+    }
+    console.log(getUserName('JoyHe'));
+    console.log(getUserName());`)
+})

packages/techor/tests/target-es5/test.ts

@@ -0,0 +1,14 @@
+{
+    "extends": "../../../../tsconfig.json",
+    "compilerOptions": {
+        "baseUrl": ".",
+        "outDir": "dist",
+        "target": "ES5"
+    },
+    "include": [
+        "src/**/*"
+    ],
+    "exclude": [
+        "src/**/*.test.ts"
+    ]
+}

packages/techor/tests/target-es5/tsconfig.json

@@ -0,0 +1,13 @@
+{
+    "extends": "../../../../tsconfig.json",
+    "compilerOptions": {
+        "baseUrl": ".",
+        "outDir": "dist"
+    },
+    "include": [
+        "src/**/*"
+    ],
+    "exclude": [
+        "src/**/*.test.ts"
+    ]
+}